| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
unset inappropriate execute bits
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I imagine these date back to old Subversion days and are probably the
result of inadvertent commits from Windows users with vcs client
configs.
having the bit set isn't really harmful most of the time,
but it's just not right, and it makes the files stand out in directory
listings for no reason
|
|\ \
| | |
| | | |
SI-9369 Fix pattern matcher warnings for diamond shaped inheritance.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A previous optimization (d44a86f432a7f9ca250b014acdeab02ac9f2c304) for
pattern matcher exhaustivity checks used a smarter encoding to ensure
that the scrutinee can be equal to one child only.
However, in case of traits between the root and leave type, a child can
be of several types and these types should not be in a mutually exclusive
group. A simple solution (hat tip to retronym) is to just put traits
and classes into separate groups.
|
|\ \
| | |
| | | |
SI-9407 Vector implementation bit-shift bugfix
|
| |/
| |
| |
| |
| |
| | |
Fixed logically incorrect or unnecessary code in Vector as reported by Dirk Toewe.
No tests. Because of the size of the vectors, tests would be impractically slow. Also, the logic is quite clear: when you are recursing through a tree, using the wrong bit shift means you hit the wrong part of the tree, and when you create and then always overwrite a mutable var, you should just not do it to begin with.
|
|\ \
| | |
| | | |
Performance optimization - Iterator
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rewrite of span to avoid double-indirection of `.buffered` and to avoid use of `mutable.Queue` unless it is absolutely necessary. Rewrite of `span` and `dropWhile` to also avoid `.buffered` (less DRY but single vs. double indirection and object allocation).
Performance improvements:
```
method reason
=========== ===============================================================
collect 2.3x faster on small collections, 1.5x on large
span 1.6-1.7x faster on small collections
0.85x-1.8x slower/faster on large collections
depending on how much must be cached (0.85x all, 1.8x none)
dropWhile 1.2x faster on small collections, half the garbage
```
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Tightened up bytecode, logic, and/or performance by using local return instead of a mutable variable in several methods.
Performance/bytecode size improvements (smaller bytecode = better inlining)
```
method reason
=========== ===============================================================
flatMap hasNext bytecode 34 bytes down from 62
find bytecode 41 bytes instead of 53
indexWhere 1.5x faster on small collections (some contexts)
indexOf bytecode 89 bytes instead of 110
```
|
|\ \ \
| | | |
| | | | |
fix typos/spelling
|
| | | | |
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Link to completed value classes SIP page instead of pending version
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Re-enable tree checkers
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
My expectation is that tree checkers are re-typechecking the trees
and making sure they are consistent. Unfortunately, following
patch aced32d05c97651534f468bc9a475ea5f6ae75b8, the call to
clearType() was removed, thus the typer no longer recursed inside
the trees, rendering the type checkers framework useless.
This is an attempt to make the tree checkers run again, by resetting
the type of a tree before the call to super.typed, thus allowing the
typer to actually visit the entire tree (not just the outer package
definition).
The work was prompted by SI-9442, where the type checkers would
gladly allow validate the inconsistent trees.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
SI-9442 Fix the uncurry-erasure types
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Using the "uncurry-erased" type (the one after the uncurry phase) can
lead to incorrect tree transformations. For example, compiling:
```
def foo(c: Ctx)(l: c.Tree): Unit = {
val l2: c.Tree = l
}
```
Results in the following AST:
```
def foo(c: Ctx, l: Ctx#Tree): Unit = {
val l$1: Ctx#Tree = l.asInstanceOf[Ctx#Tree]
val l2: c.Tree = l$1 // no, not really, it's not.
}
```
Of course, this is incorrect, since `l$1` has type `Ctx#Tree`, which is
not a subtype of `c.Tree`.
So what we need to do is to use the pre-uncurry type when creating
`l$1`, which is `c.Tree` and is correct. Now, there are two
additional problems:
1. when varargs and byname params are involved, the uncurry
transformation desugares these special cases to actual
typerefs, eg:
```
T* ~> Seq[T] (Scala-defined varargs)
T* ~> Array[T] (Java-defined varargs)
=>T ~> Function0[T] (by name params)
```
we use the DesugaredParameterType object (defined in
scala.reflect.internal.transform.UnCurry) to redo this desugaring
manually here
2. the type needs to be normalized, since `gen.mkCast` checks this
(no HK here, just aliases have to be expanded before handing the
type to `gen.mkAttributedCast`, which calls `gen.mkCast`)
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update Java and Sun URLs to replacement Java and Oracle URLs
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
For each URL
- Where it redirected the target of the redirection was used
- Where is no longer existed a replacement was selected
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
SI-9424 Clarify behavior of PriorityQueue toString
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Clarified that PriorityQueue will not print in order and gave an example of a workaround if one needs it.
Documentation change only; no tests.
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Improve comment in Option.collect example
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-6636 Fix macro expansion in toolboxes
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Format and content enhance README.md
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace bullet points with tables for
- Review labels
- Command overviews
Rescue sbt section from midst of Ant section.
Syntax correct use of ANT_OPTS.
Synchronise IntelliJ menu path to 14.1.
Update OSS repo name. The Central Repository was formerly known
as Maven Central.
Standardise on @-mention instead of @mention.
Mark unfinished section with TODO.
Include a few other minor improvements.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add link to online version of Programming in Scala
|
| | |_|_|/ /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-9450 Fix triple quoted strings in REPL :power mode
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some extra synthetic code generated under this mode failed to escape
input before adding it to a literal string. It used to get away with
this most of the time by triple quoting the literal.
This commit reuses Scala string escaping logic buried in `Constant`
to do this properly. Actually, the proper approach would be to build
the synthetic code with trees and quasiquotes, and avoid the mess
of stringly-genererated code.
I threw in some defensive hygiene for the reference to `Nil` while
I was in the neighbourhood.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
SI-8346 Re-established soundness of toSet (element type widening)
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
toSet needs to rebuild some child classes, but not others, as toSet is
allowed to widen element types (which the invariant Set normally cannot do),
and some sets rely upon their invariance. Thus, sets that rely upon their
invariance now rebuild themselves into a generic set upon toSet, while those
that do not just sit there.
Note: there was a similar patch previously that fixed the same problem, but
this is a reimplementation to circumvent license issues.
Note: the newBuilder method was benchmarked as (surprisingly!) the most
efficient way to create small sets, so it is used where sets may need to
be rebuild.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Fix typos in spec, docs and comments
|
| | | | |
| | | | |
| | | | |
| | | | | |
Since it's a private method, it's safe to just rename it.
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Sync commit advice to README.md and fix Scabot URL
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
CONTRIBUTING.md offered different advice on commit subject line length
to README.md. Align CONTRIBUTING to README.
Fix Scabot repo URL
|
|\| | | |
| |_|/ /
|/| | | |
Extend documentation contacts
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Revert "SI-8346 Rebuild invariant sets in #toSet, avoiding CCE"
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix documentation of Stream.filter introduced in 13f30c
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Fix method name reference in Predef documentation
|
|/ / |
|
|\ \
| | |
| | | |
Improved error message for "filename too long" build errors
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When building on ecryptfs filenames can be limited to ~142 characters.
This limit doesn't take long to hit and can leave the the user with a
hard to diagnosis error message. Some legacy file systems will have
similarly small limits. This just adds a hint that the error might
be related to the underlying fs.
|
|\ \ \
| |_|/
|/| | |
Fix tracing of implicit search under -Ytyper-debug
|