summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* SI-5378, unsoundness with type bounds in refinements.Paul Phillips2013-01-094-48/+135
| | | | | | | | | | | | | | | | | As the comment says: Not enough to look for abstract types; have to recursively check the bounds of each abstract type for more abstract types. Almost certainly there are other exploitable type soundness bugs which can be seen by bounding a type parameter by an abstract type which itself is bounded by an abstract type. SPECIAL: BUY ONE UNSOUNDNESS, GET ONE FREE In refinement types, only the first parameter list of methods was being analyzed for unsound uses of abstract types. Second parameter list and beyond had free unsoundness reign. That bug as well is fixed here.
* SI-6566, unsoundness with alias variance.Paul Phillips2013-01-0914-14/+70
| | | | | | | This wasn't as bad as it could have been. All these changes plug soundness holes in trunk. Mostly we're looking at type aliases which were merely protected when they had to be protected[this] not to allow unsound variance crossover.
* Boosted test coverage.Paul Phillips2013-01-095-0/+601
|
* Handle variance exclusions in a less ad hoc manner.Paul Phillips2013-01-092-16/+29
|
* Eliminated redundant validateVariance.Paul Phillips2013-01-092-81/+61
| | | | It had repeated all the TypeMap logic. I made it a TypeMap.
* Sweeping up in Variances.Paul Phillips2013-01-091-19/+15
|
* Move isFinalType logic to Symbol.Paul Phillips2013-01-092-3/+12
| | | | It's strictly based on the symbol, not the type.
* Move escaping local logic into VarianceValidator.Paul Phillips2013-01-092-15/+19
|
* Eliminated VariantTypeMap.Paul Phillips2013-01-095-119/+98
| | | | | Made variance tracking a constructor parameter to TypeMap. Eliminated more variance duplication.
* Functionalization of Variance code.Paul Phillips2013-01-091-29/+32
|
* Moved VariantTypeMap into Variances.Paul Phillips2013-01-092-71/+74
|
* Moved Variances into SymbolTable.Paul Phillips2013-01-094-21/+25
| | | | So I can centralize all the redundant variance code.
* Relocated redundant variance checking code.Paul Phillips2013-01-092-151/+154
| | | | | | | | | The variance code in Refchecks is 75+% redundant with our eventually canonical variance traversing code now in Variances, but as usual it is time consuming to stamp out this damaging redundancy so for the moment I am simply moving it into close proximity with def variancesInType to abet future work.
* Incorporated Variance value class in Variances.Paul Phillips2013-01-0913-187/+134
| | | | | No one will ever know what it took for me to refine Variances into its current condition. A LONELY QUEST.
* Created value class Variance.Paul Phillips2013-01-091-0/+85
| | | | | | | | | This will be instead of passing numbers like -1 and 1 around, also instead of a variety of named constants like AnyVariance and CoVariance, and also instead of sometimes using the flags Flag.COVARIANT and Flag.CONTRAVARIANT for things. 1, 2, 3, go-type-safety-rah!
* Merge pull request #1871 from adriaanm/merge-2.10.xAdriaan Moors2013-01-0840-128/+404
|\ | | | | Merge 2.10.x
| * Merge branch '2.10.x'Adriaan Moors2013-01-0840-128/+404
|/| | | | | | | | | | | | | | | | | | | | | | | | | Patches applied: - rename of `dropRepeatedParamType` to `dropIllegalStarTypes` -- required since 8886d22cd6 - fixed test/files/neg/t6406-regextract.flags -- how could this have worked before? Conflicts: src/compiler/scala/tools/nsc/interpreter/TypeStrings.scala src/library/scala/collection/LinearSeqOptimized.scala src/library/scala/util/Properties.scala test/files/run/streams.check test/files/run/streams.scala
| * Merge pull request #1843 from JamesIry/SI-6915_2.10.xAdriaan Moors2013-01-073-3/+3
| |\ | | | | | | SI-6915 Updates copyright properties to 2002-2013
| | * SI-6915 Updates copyright properties to 2002-2013James Iry2013-01-043-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | The .scala header files had the right copyright dates but properties used to generate the information in e.g. "scala -version" hadn't been updated. review @adriaanm
| * | Merge pull request #1842 from adriaanm/backport-1821Paul Phillips2013-01-062-1/+6
| |\ \ | | | | | | | | Backport 1821
| | * | avoid reflect overhead of certain array instantiationsAdriaan Moors2013-01-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the manifests for Any, Object/AnyRef, AnyVal, Null and Nothing now have their `newArray` methods overridden to avoid reflective overhead of array instantiation. (backport of 45ef0514e, part 2)
| | * | proper elementClass for WrappedArrayAdriaan Moors2013-01-041-1/+1
| | | | | | | | | | | | | | | | (backport of 45ef0514e, part 1)
| * | | Merge pull request #1834 from paulp/issue/6897Paul Phillips2013-01-062-1/+10
| |\ \ \ | | | | | | | | | | SI-6897, lubs and varargs star.
| | * | | SI-6897, lubs and varargs star.Paul Phillips2012-12-312-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | Don't allow lubs to calculate refinement types which contain a varargs star outside of legal varargs star position.
| * | | | Merge pull request #1835 from paulp/issue/6896Paul Phillips2013-01-063-11/+21
| |\ \ \ \ | | | | | | | | | | | | SI-6896, spurious warning with overloaded main.
| | * | | | SI-6896, spurious warning with overloaded main.Paul Phillips2012-12-313-11/+21
| | |/ / / | | | | | | | | | | | | | | | | | | | | Make sure there's no legit main signature before issuing any warnings about missing main methods.
| * | | | Merge pull request #1840 from paulp/issue/6911Paul Phillips2013-01-064-73/+122
| |\ \ \ \ | | | | | | | | | | | | SI-6911, regression in generated case class equality.
| | * | | | SI-6911, regression in generated case class equality.Paul Phillips2013-01-034-73/+122
| | | |/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caught out by the different semantics of isInstanceOf and pattern matching. trait K { case class CC(name: String) } object Foo extends K object Bar extends K Foo.CC("a") == Bar.CC("a") That expression is supposed to be false, and with this commit it is once again.
| * | | | Merge pull request #1841 from adriaanm/rebase-6827-2.10.xAdriaan Moors2013-01-043-2/+49
| |\ \ \ \ | | |_|_|/ | |/| | | Fix Iterator#copyToArray (fixes SI-6827).
| | * | | Fix Iterator#copyToArray (fixes SI-6827).Erik Osheim2013-01-043-2/+49
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As pointed out in #scala, when using a non-zero start it's possible to get an ArrayIndexOutOfBoundsException due to an incorrect bounds check. This patch fixes this, as well as another potential bounds error, and adds test cases. Incorporates some other suggestions by Som-Snytt to ensure that callers will get useful error messages in cases where the start parameter is wrong (negative or out-of-array-bounds). Review by @som-snytt.
| * | | Merge pull request #1739 from jedesah/Array_optPaul Phillips2013-01-043-0/+29
| |\ \ \ | | |/ / | |/| | SI-5017 Poor performance of :+ operator on Arrays
| | * | SI-5017 Poor performance of :+ operator on ArraysJean-Remi Desjardins2012-12-233-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Control performance of :+ and +: operator on my machine were 700-800 ms After adding size hint on the implementation in SeqLike, it went down to 500-600 ms But with specialixed implementation in ArrayOps, brings it down to 300-400 ms Unfortunatly, this method will only be called when the Array object is being referenced directly as it's type, but that should be the case enough times to justify the extra method. I ended up removing the sizeHint in SeqLike because it made the execution of the "benchmark" slower when the Array was being manipulated as a Seq. Side note: Interestingly enough, the benchmark performed better on my virtualized Fedora 17 with JDK 7 than natively on Mac OS X with JDK 6
| * | | Merge pull request #1822 from paulp/issue/6194Paul Phillips2013-01-033-2/+15
| |\ \ \ | | |_|/ | |/| | SI-6194, repl crash.
| | * | SI-6194, repl crash.Paul Phillips2012-12-273-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | Always a bad idea to use replaceAll on unknown strings, as we saw here when windows classpaths arrived containing escape-requiring backslashes.
| * | | Merge pull request #1824 from paulp/pr/partest-likes-deprecationPaul Phillips2012-12-319-5/+8
| |\ \ \ | | | | | | | | | | Remove -deprecation from partest default options.
| | * | | Remove -deprecation from partest default options.Paul Phillips2012-12-279-5/+8
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | Who knows why it was ever like this; it's not like anyone sees the deprecation warnings. In PR #1807 there is now a test which depends on partest not making this move, so it's a good time to finally expunge it.
| * | | Merge pull request #1720 from soc/SI-6746Paul Phillips2012-12-301-1/+1
| |\ \ \ | | | | | | | | | | SI-6746 Fixes MANIFEST.MF package entry (s.r.makro -> s.r.macros)
| | * | | SI-6746 Fixes MANIFEST.MF package entry (s.r.makro -> s.r.macros)Simon Ochsenreither2012-12-061-1/+1
| | | | |
| * | | | Merge pull request #1792 from ybr/minordocimprovementPaul Phillips2012-12-281-1/+1
| |\ \ \ \ | | | | | | | | | | | | Stream.zip naturalsEx example does not compile => remove extra zip call
| | * | | | Stream.zip naturalsEx example does not compile => remove extra zip callybr2012-12-201-1/+1
| | | | | |
| * | | | | Merge pull request #1828 from paulp/pr/stream-lengthComparePaul Phillips2012-12-286-23/+71
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | SI-6415, Stream#lengthCompare
| | * | | | LinearSeq lengthCompare without an iterator.Paul Phillips2012-12-283-22/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Had to fix up an iffy test: not only was it testing undefined behavior, it demanded just the right numbers be printed in a context where all negative or positive numbers are equivalent. It's the ol' "get them coming and going" trick.
| | * | | | SI-6415, overly eager evaluation in Stream.Jean-Remi Desjardins2012-12-284-13/+57
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The lengthCompare method in LinearSeqOptimized was looking one step further than it needed to in order to give the correct result, which was creating some unwanted side effects related to Streams.
| * | | | Merge pull request #1801 from paulp/issue/6829Paul Phillips2012-12-265-3/+121
| |\ \ \ \ | | | | | | | | | | | | SI-6829, NPE during erroneous compilation.
| | * | | | SI-6829, SI-6788, NPEs during erroneous compilation.Paul Phillips2012-12-245-3/+121
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Have to intercept trees which have a null type due to errors before they leave the warm confines of 'def typed' because from that point everything assumes tree.tpe != null.
| * | | | Merge pull request #1799 from paulp/pr/check-thread-accessPaul Phillips2012-12-231-1/+0
| |\ \ \ \ | | | | | | | | | | | | Remove stray debugging output line.
| | * | | | Remove stray debugging output line.Paul Phillips2012-12-221-1/+0
| |/ / / / | | | | | | | | | | | | | | | I finally reached my "CHECK THREAD ACCESS" limit.
| * | | | Merge pull request #1687 from scalamacros/topic/unchecked-pattern-matchPaul Phillips2012-12-201-1/+5
| |\ \ \ \ | | | | | | | | | | | | fixes the unchecked warning in quick.comp
| | * | | | SI-6338 fixes the unchecked warning in quick.compEugene Burmako2012-12-061-1/+5
| | | |/ / | | |/| | | | | | | | | | | | | | | | | All those months when I thought it was yet another spurious error in the new pattern matcher...
* | | | | Merge pull request #1817 from scalamacros/topic/introduce-top-levelv2.11.0-M1Eugene Burmako2013-01-0638-51/+430
|\ \ \ \ \ | | | | | | | | | | | | adds c.introduceTopLevel
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 02:29:50 +0000