| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Fix for a bug in CharArrayReader which made triple quoted strings
fail to parse sometimes. Note: when the temptation strikes to adjust
for special cases by letting the regular case happen and subsequently
attempting to fix the ball of mutation by selectively applying what
seems like the inverse operation, please consider the possibility that
this is not the optimal approach. Closes SI-4785, no review.
|
|
|
|
|
|
| |
Better error message for case class/object match confusion. Closes
SI-4879, no review.
|
|
|
|
|
|
| |
Avoid some spurious errors after a cyclical reference error. Closes
SI-2388, no review.
|
|
|
|
|
|
| |
Improved structural type error messages, and other error message related
boosts. Closes SI-4877, review by odersky.
|
|
|
|
|
|
|
|
| |
Fixed bug in the disambiguation of f(foo='bar') style method calls in
the presence of overloading, parameterization, and by-name arguments.
Took the opportunity to clean things up a little bit. Closes SI-4592,
review by rytz.
|
|
|
|
|
|
|
| |
Disallowed implicit modifier on auxiliary constructors, since it either
silently accomplishes nothing or crashes the compiler. If it should do
something useful let me know. Closes SI-4882, review by odersky.
|
|
|
|
|
|
|
|
| |
Don't want to chase NPEs around for the rest of my life. Created
"NoCompilationUnit" and "NoSourceFile" objects to represent not-present
versions of these items. Seems a lot better than null. References
SI-4859, got past NPE only to uncover the actual problem. No review.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attacked classpaths to get "." off of it when it's not actually
specified. The commit makes me nervous, but there's no invisible way to
fix something like this.
** Attention, this commit changes classpath handling **
We desperately need some way of testing that the classpath has certain
qualities and does not have others; partest is not that way. Closes
SI-4857, no review.
|
| |
|
| |
|
|
|
|
|
| |
Oops, let unnecessary boxing creep into that last commit, no review.
|
|
|
|
|
|
|
| |
Rewrote the case class synthetic equals method to be more efficient and
to cause fewer problems for compiler hackers who are always saying stuff
like "the only place this comes up is case class equals..." No review.
|
|
|
|
|
|
|
|
|
| |
Reverting the inline exception handlers while I figure out what is
breaking the bytecode. (doesn't seem obvious, might take some time to
figure it out)
No review.
|
| |
|
|
|
|
|
| |
Cleanups in synthetic method generation, no review.
|
|
|
|
|
| |
Issue a warning about classes/objects inside package objects, no review.
|
|
|
|
|
|
|
|
| |
Cleanups in Namers and AddInterfaces emerging from bugfixing attempts
and comprehension pursuits. I appear to have accidentally fixed at least
one bug, as there are new (correct) warnings when building the compiler
involving permanently hidden imports. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a command line script to ~/tools to count flag usages. I'm
checking this in less out of the enormous demand for flag counting
scripts than because I wanted to lower the barrier to people writing
reusable bash scripts.
*** DO YOU WANT TO WRITE NICE BASH SCRIPTS? ***
*** Look at tools/flag-usages.sh ***
*** It's easy to understand and full of helpful comments! ***
I'm not making any claims here about having massive bash expertise,
but I know a lot of people resist learning any of it (I was once like
you) so I wanted to lower the barrier a little. Because as a mechanism
for the composition and modification of the world of existing tools,
nothing comes close to the shell. And I know many of us write way too
many one-offs which we delete in shame and horror shortly after their
immediate purpose is served.
No review. (I should say r-e-v-i-e-w by everyone but I'm sure it would
give me a nice pile of crucible errors.)
|
|
|
|
|
|
|
| |
Adds version information from @migration and @deprecated to ScalaDoc.
Adds support for @migration in Symbols and MemberEntity. Contributed by
Simon Ochsenreither. Review by heathermiller.
|
|
|
|
|
|
| |
Finished up some backend cleanups I'd had lying around since scala days.
No review.
|
|
|
|
|
|
|
|
|
| |
Took a different tack on avoiding unnecessarily final bytecode methods
after discovering the inliner is not a fan of any reduction in finality.
Restored the application of the lateFINAL flag in makeNotPrivate, and
switched to sorting out who is ACC_FINAL and who isn't in genjvm. Review
by dragos.
|
|
|
|
|
|
| |
Made error messages like "object List is not a value" be a little more
helpful about why that is. No review.
|
|
|
|
|
|
| |
Minor changes to the Scaladoc stylesheets, as suggested by Simon
Ochsenreither. Closes SI-4499. No review.
|
|
|
|
|
|
|
|
| |
Merged enhancements made to scaladoc filter panel by Ruediger Keller.
Enhancements include faster filtering, automatically focused text input
field, improved searching (no regex syntax, so now its possible to
search for members like ++). No review.
|
| |
|
|
|
|
|
| |
Rename a file to celebrate our glorious ant overlords, no review.
|
|
|
|
|
| |
A couple low impact cleanups/optimizations, no review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tired of ugly-printing in the repl, I sort of finished some old code for
pretty printing token streams. It is at least a lot prettier than it
once was, and I threw in some power mode helpers. Now you can do this.
% scala -Dscala.repl.power
Welcome to Scala version 2.10.0.r25427-b20110801144412 (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_26).
// .u turns a string into an URL like .r does into
a regex, and .pp pretty prints the url scala>
"https://raw.github.com/scalaz/scalaz/master/example/src/main/scala/scal
az/example/ExampleIteratee.scala".u.pp package scalaz.example
object ExampleIteratee {
def main (args: Array[String]) = run
import scalaz._
import Scalaz._
import IterV._
[etc it's all there in real life]
}
No review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sped up traversal over mutable maps by a factor of two.
There was this comment in HashTable explaining why foreach was
implemented in terms of iterator. /*
* We should implement this as a primitive operation over the
* underlying array, but it can cause a behaviour change in edge cases
* where:
* - Someone modifies a map during iteration
* - The insertion point is close to the iteration point.
*/
Item 1: foreach and iterator didn't behave the same if the map was
mutated in the midst of the traversal anyway. Item 2: protecting some
particular undefinition of inherently undefined behavior is a pretty
unconvincing reason to impose a 2x penalty on foreach.
Here are the before/after times for traversing the keys with foreach
vs. with iterator. Same impact on values and on the map itself. The
benchmark code is included in this commit.
before: foreach 143700900 iterator 143848900
after: foreach 67024400 iterator 144890300
Respecting the fact that this might be causing some behavior somewhere
to change, even though it would be pretty sick to be relying upon it,
** ATTENTION! POSSIBLE BEHAVIOR CHANGE! **
Review by dragos.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
output generation (but only then, since otherwise we're not creating the
jar):
1) -Xmain-class foo.Bar will give the jar a Main-Class of foo.Bar 2)
Alternatively, if there is only one runnable program, that will be
the Main-Class 3) Always, the jar's manifest will have an entry for
Scala-Compiler-Version.
Not very relatedly, a warning is now issued when a module has a main
method but a runnable program will not be generated. Closes SI-4861.
This represents an opening step toward automatically recognizing
mismatched bytecode situations: coarse, but useful and safe. Review by
mirco.
|
|
|
|
|
| |
Some additions to definitions for recognizing main methods, no review.
|
| |
|
|
|
|
|
|
|
|
| |
LiftCode works again, now integrated with new reflection library.
Other changes: def Literal(x: Any) has been deprecated, and all its uses removed.
Modifiers has lost positions as fourth case class argument; is now a field, mirroring Tree.pos (this removes junk in patterns and makes reification simpler). Review by extempore.
|
| |
|
|
|
|
|
|
| |
One last build fix for our poor java5 build servers with their
String.isEmpty confusion, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- Update Scaladoc for LinkedList and for some of the functions/operators
- that it inherits. Completed Scaladoc for append Added example
- in GenSeqLike for apply. Added $collectExample to collect in
- GenTraversableLike and supplied an actual example in LinkedList
Contributed by Donald McLean.
|
|
|
|
|
|
|
|
| |
Move vector descrition from the obejct to the class, where it actually
makes sense. Preserve previously existing attribute definitions.
Contributed by Daniel C. Sobral
|
|
|
|
|
| |
Moved test out of pending, closes SI-3628, no review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following up on things that -Xlint told me, sometimes because Mr. Linty
was being sensible and other times just to shut him up so we can hear
better in the future.
- made xml.Equality public because it occurs in public method signatures
- made some actor classes with inaccessible-unoverridable methods final
- eliminated a bunch of "dead code follows" warnings by deleting the
dead code which really did follow - improved the reliability of warnings
about inaccessible types
For the changes in actors, review by phaller.
|
|
|
|
|
|
| |
Disabled all the old scala.reflect._ tests which are now crash-failing,
no review.
|
| |
|
|
|
|
|
|
|
| |
Fixing the very broken build (was going for "compiling" mostly because
I can't be sure what to do with some of this) really this code is
certainly not correct, please review by odersky.
|
| |
|
|
|
|
|
|
|
| |
Discovered through jsuereth's work that a file I should have removed
way back in r17897 slipped the noose. Your free ride ends here,
midpapi10.jar. No review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Ywarn-adapted-args // also included in -Xlint
-Yno-adapted-args
The former warns when a () is inserted or an argument list is implicitly
tupled. The latter errors under the same conditions. Using these options
I found several bugs in the distribution which would otherwise be nearly
impossible to spot. These bugs were innocuous (I think) but similar bugs
could easily be (and have been) otherwise.
Certain particularly threatening scenarios are at minimum warned about
regardless of options given. Closes SI-4851, no review.
|
|
|
|
|
|
|
|
| |
Turned off the notFINAL flag which was applied to expanded name methods
due to java breakage, on the principle of "first, do no harm." If there
is some rationale why these methods must be made final, let's at least
get it documented. Review by dragos.
|
|
|
|
|
|
|
|
| |
Expression type argument instantiation should not fail in a context
expecting Unit if there is any valid instantiation, because value
discarding should kick in and offer a literal (). Closes SI-4853, review
by odersky.
|
|
|
|
|
|
| |
New starr based on r25394 to make the starr liberator's job easier, no
review.
|