| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |/
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
not tested for performance, but shouldn't add any memory overhead
see https://github.com/adriaanm/scala/commit/44362c557f for an example usage
|
| | | |/
| | | |
| | | |
| | | | |
Eliminated the spurious warnings and made the code easier to follow.
|
| | |/
| | |
| | |
| | | |
shutdown test more resilient on slow machines.
|
| | |\
| | | |
| | | | |
disable version numbers on windows, they're broken.
|
| | |/ |
|
| | | |
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Initially motivated by SI-5580, then just motivated. I broke up
the opaquely named JavaConversions and JavaConverters into the following
traits encapsulating some permutation of
{ to java, to scala, bidirectional }
{ wrappers, decorators }
I named everything consistently in terms of either Wrappers
or Decorators. Decorators install those asJava/asScala methods
onto collections of the right kind; Wrappers hide the process.
JavaConversions then reduces to an object which (ill-advisedly)
extends both WrapAsJava and WrapAsScala. And JavaConverters is
an object extending DecorateAsScala and DecorateAsJava. However
other more clearly named vals exist in the newly created
scala.collection.convert package object.
val decorateAsJava = new DecorateAsJava { }
val decorateAsScala = new DecorateAsScala { }
val decorateAll = new DecorateAsJava with DecorateAsScala { }
val wrapAsJava = new WrapAsJava { }
val wrapAsScala = new WrapAsScala { }
val wrapAll = new WrapAsJava with WrapAsScala { }
So for instance to import asScala decorators, and only those:
scala> import scala.collection.convert.decorateAsScala._
import scala.collection.convert.decorateAsScala._
scala> new java.util.ArrayList[String].asScala groupBy (x => x)
res0: scala.collection.immutable.Map[String,scala.collection.mutable.Buffer[String]] = Map()
I propose we put those vals or a subset of them in the scala
package object rather than way down in scala.collection.convert.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Lub explosions mean we can't expect sane types in error messages.
Defend against the insane.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Tried to paint a picture of how one might synthesize an implicit
method to accompany an implicit class.
|
| | | | |
|
| | | | |
|
| | |/ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After hours of debugging and understanding all the root causes why
scaladoc is rummaging through the current directory for classes, I
decided to treat the symptoms rather than the cause. I'll document
the decision here in case anyone is interested:
- in order to find documentable entities, scaladoc exhaustively
looks at all the symbols starting from the root package and going
all the way to the leaves, visiting all classes in the classpath
- if the classpath is empty, scaladoc and scalac add "." as the
default classpath. This leads to scaladoc going on a class hunting
spree in the current directory. If it happens that the current
directory contains package objects and they're not in the expected
path (like scala.tools.nsc in build/quick/classes/.../nsc) errors
start to pop up
- scalac is also affected by this, but to a more limited scope,
since it will lazily expand packages whenever necessary. To show
this, run the repl in the root directory of the scala source code,
after compiling scala:
scala> import build.quick.classes.compiler.scala.tools.nsc._
error: error while loading package, class file './build/quick/classes/
compiler/scala/tools/nsc/package.class' contains wrong package package
The cleanest solution I can see now is to look at the tree resulting
from compilation and use it for guidance -- I will look into this.
|
| |
| |
| |
| | |
Feel the bugs falling away.
|
| |
| |
| |
| | |
This reverts commit d8ba5d091e5641553b438ef9930a6023a2709dcd.
|
| |
| |
| |
| |
| |
| |
| | |
Pattern matcher! Totally unrelated to irrefutability, the pattern matcher
at some point stopped sorting its lookup switch cases, and the butterfly's
wings flapped enough to swap two cases. Now they're sorted in ascending
order like they're supposed to be.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fewer deprecation warnings, prettier trees, prettier
symbols, more polished error messages.
Oh the interesting people you meet handling warnings, I
feel sorry for you all that I get to do it all the time.
One of the characters I met invited me into the "Dead Code
Society" and that's what I'm doing on Tuesdays now. No of
course you haven't, it's a SECRET society.
|
| |
| |
| |
| | |
Concluded String->String would be more useful more often.
|
| |
| |
| |
| |
| | |
Temporary reversion of irrefutability commits in interests
of stable milestone. Expect to restore shortly.
|
| |\ \
| | | |
| | | |
| | | | |
'adriaanm/topic/virtpatmat' and 'vjovanov/actor-hierarchy' into develop
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Internal nodes added so methods relevant to akka can be overridden.
Review by: @phaller
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
this way we don't end up with fresh, incompatible, skolems for every branch, but a neatly packed existential
you get much nicer lubs this way -- threw in a fast path (I hope) that avoids lubbing when unnecessary (same types)
since lub isn't robust enough to deal with the result of packedType,
and we only really need the trivial case (S =:= T), special case it for now
... don't pack in ifs after typer, also only when virtPatmat
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
no need for the clunky repackExistential
pack the type of each case instead, since the skolems we've created shouldn't last beyond the case anyway
this way we don't end up with fresh, incompatible, skolems for every case, but a neatly packed existential
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
typedMatchAnonFun is called from typedFunction when the function's body is a match
this is work-in-progres: the compiler currently won't bootstrap under -Yvirtpatmat
see also the pending test
make sure to use the right context in typeFunction when the body is a Match
when typer is set up for type checking a Function, the current owner is the symbol for the function,
but we'll type check a Block(List(ClassDef(cd)), New(cd)) when the function is a match,
and the function symbol is nowhere to be found, so go to outer context
in patmatvirt:
- simplified default case gen (no need for a Casegen instance)
- using CASE | SYNTHETIC to detect generated matches (for switches) and avoid typing them endlessly
more uniform, and necessary for new-style anon Function class instance gen for matches
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
when an unapply returns Option[T] where T is some ProductN, does that mean the unapply
returns 1 result, i.e., that T, or did it mean to return N results?
to disambiguate, falling back to stricter spec-adherence, which requires T be exactly TupleN for N results
for now, allow extractor result to be any product, not just tuple
|
| | |/
| | |
| | |
| | | |
it's a warning on new patmat -- TODO: dig deeper
|
| | |\ \
| | | | |
| | | | |
| | | | | |
'VladUreche/issue/5248' and 'VladUreche/issue/5054-usecase-cleanup2' into develop
|
| | | | |\
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
test/scaladoc/scala/html/HtmlFactoryTest.scala
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
and fixed a pesky crash in the syntax highlighting caused by invalid
chars (0x0E) in MarkupParser.scala.
|
| | | | | | |
|
| | | |/ /
| | |/| | |
|
| | |\ \ \
| | | |/ /
| | |/| | |
Yet another attempt to make the version a good one
|
| | |/ /
| | | |
| | | |
| | | |
| | | | |
This fixes the git commit drift issue and gives us enough granularity
to make releases at any time that are cronologically increasing.
|
| | | |
| | | |
| | | |
| | | | |
Looks like I got that irrefutability bug too.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rather than withFilter, for a subset of for comprehension structures.
Not sure if this was somewhat by design - only seems possible because
refchecks was only looking for nme.filter, not nme.withFilter, so
perhaps this was intended as some secret irrefutability backchannel?
Really have to document that sort of thing if it's intentional. I
assumed it wasn't and unified everything.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The parser has always been confused about tuple patterns in
for comprehensions. It thinks it can fail to recognize an
irrefutable pattern and have it removed in refchecks, but it
is sadly mistaken, because the unnecessary filter has a tendency
to fail the compile in typer.
Look more intently for irrefutable patterns and don't insert
the unnecessary filter. Closes SI-5589, SI-1336.
|
| | |\ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Scala actors are now in scala-actors.jar. Changes that were done are:
- Fixed partest to include actors library for various test usages
- Created the entry for the new jar in build.xml
- Added maven entries for scala actors
Review by: @jsuereth
|
| | |\ \ \ |
|
| | | |/ /
| | | | |
| | | | |
| | | | |
| | | | | |
extrapolate GADT skolems: only complicate types when needed
make sure we only deskolemize GADT skolems after typedCase
|
| | | | |
| | | | |
| | | | |
| | | | | |
So colors can come through unscathed.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Drawing on the previous, a half-decade overdue overhaul of
NodePrinters. Now with colors if you like colors.
% scalac -Xprint:all -Yshow-trees -Dscala.colors a.scala
Am heading toward general purpose color configuration.
|
| | |/ /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I noticed that if we gave Ident a "qualifier" method which is
always EmptyTree, a whole bunch of code could be simplified.
A transparent subclass of Apply which preserves the source
level "new" a little longer than never.
Since productPrefix is tied up in reification - and oh I
detest this "String"-based programming, we shouldn't have to
wait until everyone learns this independently to change it -
I added "printingPrefix" to Tree, which defaults to
productPrefix but can be changed without breaking reify.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Removed Timeout from the library. Each library should provide its own implementation of Timeout
- Removed duration package object and replaced it with regular object
- Removed usages of post Java 1.5 TimeUnit members
- Added factory methods for FiniteDuration
- Cleaned up some unnecessary comments
- Merged duration DSL with Duration.scala file
Review by: @phaller
|