| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Another lap around the track with generic signatures. At the root of the
issue reported in #4214 is our old friend (fondly remembered from the
days of primitive equality) boxed/primitive unification.
// scala
trait T[A] {
def f(): A
}
// the generic signature spec doesn't allow for parameterizing
// on primitive types, so this cannot remain Char. However
// translating it to Character, as was done, also has issues.
class C extends T[Char] {
def f(): Char = 'a'
}
// Note that neither of the signatures for f, the implementation // or
the bridge method, matches the type parameter. Generic interfaces in
class: T<java.lang.Character> Generic signatures: public char C.f()
public java.lang.Object C.f()
After this commit, primitive type parameters are translated into Object
instead of the boxed type. It was martin's idea, so no review. Closes
#4214.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Long overdue rehaul of presentation compiler tests. Added support for
options file, and switched simple-tests to use the STARR library on the
test classpath.
Put any options you need passed to the presentation compiler in a file
with the same name as the test, ending in '.opts'. Currently it's used
to set the -bootclasspath for simple-tests. Check the contents of
simple-tests.opts for all the options.
IMPORTANT: when committing a new STARR, you need to check this test.
Most likely, you *will* break it otherwise.
review by extempore
|
|
|
|
|
|
|
| |
Break 9 tests, fix 9 tests, realize you broke the test you checked in
between +9 and -9. Fix that and generalize the repl tests a little. I
think we're all the way there. No review.
|
| |
|
| |
|
|
|
|
|
| |
Attempting to fix half my recently imposed breakage. No review.
|
|
|
|
|
|
|
|
|
| |
Altered a check for impl classes to look at the name instead of the
flags, since the flags are wrong. Obviously we should fix the flags or
otherwise better address. Note that the test is well intentioned but
doesn't actually fail with older versions; the crash is not easy to
reproduce even when I simulate the whole repl. Review by dragos.
|
|
|
|
|
|
| |
A fix for ListBuffer's iterator not to blow up when values are changed
during iteration. No review.
|
|
|
|
|
| |
No review.
|
|
|
|
|
| |
about how to obtain a String and how not to. Closes #4297, no review.
|
| |
|
|
|
|
|
|
|
| |
lazy val calls shouldn't be included in pure expressions in general.
closes 4047. fixed also bug in optimizer (was eliminating a.foo call in
the test). review by dragos
|
|
|
|
|
| |
in future attempts. Closes #4291, references #4214, no review.
|
|
|
|
|
|
|
| |
[scaladoc] Comments for lazy vals are printed in documentation. Solution
is hack around issue in compiler's analyser. Closes #3790. Review by
plocinic.
|
|
|
|
|
|
| |
[scaladoc] No companion linking is attempted from inner object to
abstract type member. Closes #4180. No review.
|
|
|
|
|
|
| |
[scaladoc] Specializes upper and lower bounds of abstract type members
and variables to local class context. Closes #3982. No review.
|
|
|
|
|
|
| |
[scaladoc] The "inherited" filter work correctly for inner classes and
object. Closes #3775. No review.
|
|
|
|
|
| |
[scaladoc] Unsightly hack in Scaladoc to close #4086. Review by odersky.
|
|
|
|
|
| |
(only to make you aware of the commit message in r24263.)
|
|
|
|
|
|
| |
[scaladoc] Fixes the way default values and annotations are output in
Scaladoc. Closes #4167. No review.
|
|
|
|
|
|
|
|
| |
[scaladoc] Changed TreeFactory so that it doesn't consume exceptions.
Required fixes to makeAnnotation and makeTree which were throwing
exceptions as a matter of fact. Also code refactoring around annotations
and trees. Closes #4284. No review.
|
|
|
|
|
| |
Partial revert of r24325; tryToSetFromPropertyValue is used by Eclipse.
|
| |
|
|
|
|
|
|
|
| |
Added daemonized() method to ProcessBuilder so I can do things like
start fsc without the jvm failing to exit. More logging to fsc. scala -e
'5' now works again. Closes #4254, review by harrah.
|
| |
|
|
|
|
|
| |
No review.
|
| |
|
|
|
|
|
|
| |
Closes #4202 and removes empty TreeHashMap (superseded by HashMap
implementation). No review
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default. The -toolcp option now works. -D and -J options are passed
as arguments to the runner program as well as to the underlying JVM,
because they may be needed for such things as fsc talking to a server
compiler. Added a new Settings type for -D and -J options. Deleted some
dead settings code.
There are dummy settings for -toolcp and -nobootcp so they can be seen
in the help output, which needs a big cleanup.
No review.
|
| |
|
|
|
|
|
|
| |
changed test output and comment, because mixed in fields and methods no
longer get a generic signature. Review by extempore.
|
| |
|
|
|
|
|
|
|
|
| |
Fixed a bug where newly introduced type parameters didn't have all the
substitutions done correctly. Fixes #4266.
No review.
|
|
|
|
|
|
| |
Attempt to fix #4214 by avoiding signature generation for mixed in and
bridge methods.
|
| |
|
|
|
|
|
|
| |
Moved delayedInit Application to App; reinstantiated 2.8.1 Application
and deprecated it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
from one AST snapshot to the next, it displays the nodes which had until
so recently been decorated with it.
It's quite the symbol whisperer now, try it.
scalac -Yshow-syms bippy.scala
No review.
|
|
|
|
|
| |
Making parsing more interruptible + better timing info in logs.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved unlift to the Function companion object, which might have been
better in the first place. Had to make a minor change to genprod, and
then I couldn't escape that unscathed. Finished the not very complete
undertaking I found there to update the scaladoc. Lots of little changes
to the generated text and code.
I changed genprod to only put a unique stamp on Function0 so we can stop
having a 100 file diff everytime an i is dotted somewhere.
Closes #3825, no review.
|
|
|
|
|
|
|
|
| |
Observed that some historical issues with package objects no longer seem
so issuey. In the interests of keeping the arbitrary limitations to a
minimum, re-enabled case classes in package objects (see #2130, #3437.)
Closes #3437, review by odersky.
|
|
|
|
|
|
| |
a trait so it had a chance of being mixed into another class as directed
in the doc comment in question. Closes #4087, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on the frequency with which I hear questions about it and similar,
this error message assumes too much understanding.
scala> scala.collection.mutable.MultiMap(1, 2, 3) <console>:8: error:
value MultiMap is not a member of package scala.collection.mutable
Now it says:
scala> scala.collection.mutable.MultiMap(1, 2, 3) <console>:8: error:
object MultiMap is not a member of package scala.collection.mutable
Note: trait MultiMap exists, but it has no companion object.
No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rediscovering that transpose sometimes throws an exception on irregular
lists and sometimes returns an irregular result (depending on whether
the first collection is the longest or not) indicated that this needs a
better resolution than the status quo. Determination: as long as we're
throwing an exception on any invalid input, we should throw an exception
on all invalid input, so that's what it does now. I postpone any attempt
to offer a variation accepting a "hole value". Closes #3597, review by
community.
|
| |
|
| |
|
| |
|