| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
| |
Expanded the range of a warning, and made suppressed warnings visible.
Modified the positioning of "permanently hidden" errors so that when
there is more than one, the later ones are not ignored. Also changed the
error suppression code to emit the error anyway if -Ydebug was given (it
is prefixed with "[suppressed] ".) Since I can't be the only one who
wondered where his errors were vanishing to. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reversed the values of "is" and "is not" in recent for comprehension
deprecation.
DO NOT BLOW HATCH
REPEAT
DO NOT BLOW HATCH
"Roger! Hatch blown."
Events reveal it was all baby, no bathwater. It turns out that the
specification is merely a document, not infallible holy writ as we
had all previously believed. So it is not the ABSENCE of val in a for
comprehension assignment which is deprecated, it is the PRESENCE of val.
Summarizing again, more accurately perhaps:
for (x <- 1 to 5 ; y = x) yield x+y // THAT's the one
for (val x <- 1 to 5 ; y = x) yield x+y // fail
for (val x <- 1 to 5 ; val y = x) yield x+y // fail
for (x <- 1 to 5 ; val y = x) yield x+y // deprecated
No review.
|
| |
|
|
|
|
| |
Optimizations for Seq's implementations of sequence search algorithms.
Contributed by Rex Kerr. Closes SI-4828, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the classes and objects which are defined in package objects out.
In principle this is something you should be able to do. In practice
right now it means bugs, to no advantage.
I also deprecated RangeUtils, an unused, undocumented trait in the
immutable package. It seems like there is a ton of stuff in the public
API which should not be in the public API. It's really tedious having to
go through a whole deprecation cycle to dispose of what could have been
an internal-only class (and was presumably intended as such given the
the absence of documentation.)
No review.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Adds documentation to the scala.math package object. Contributed by
Christian Krause. No review.
|
| |
|
|
|
|
|
| |
have lived through before: java5 wrongly prints "volatile" next to
bridge methods, because ACC_BRIDGE uses the same bit as ACC_VOLATILE.
Result: partest failure! No review.
|
| | |
|
| |
|
|
|
|
| |
Fix java signature generation for traits: no classes as parents. Closes
SI-4891, review by grek.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't discard deprecation/unchecked warnings regardless of settings.
Changed warnings code to accumulate them rather than thoughtlessly
discarding them and issuing its well-known taunt. In the repl you can
take advantage of this with the :warnings command, which will show the
suppressed warnings from the last line which had any. Be advised that at
the moment it has some issues: unchecked warnings aren't making it out,
and near repl startup neither are deprecation warnings, so don't open a
bunch of tickets please.
References SI-4594, no review.
|
| |
|
|
|
|
| |
Big cleanups in the tracing utility and its usage for signature tracing.
To assist in my current java signature thrill-o-rama. No review.
|
| |
|
|
|
|
|
| |
Removed unused import in collection.immutable.WrappedString.
No review.
|
| |
|
|
|
| |
update on this matter is yet to come, no review.
|
| |
|
|
|
|
|
|
|
| |
Looks like there was a little baby in the parser bathwater, or at least
some bathwater still in the general shape of a baby. Apparently both
old forms weren't deprecated. The spec does not suggest that the 'val'
in for comprehension assignment is optional, but clearly it can't go
anywhere for a while yet regardless. Will seek clarification. No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
Made the thread behavior of the repl a little bit configurable. Every
line will run in the same thread:
scala -Dscala.repl.no-threads
This mechanism is likely to change. Repl is obscenely overdue for a
config file. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When I tried to remove the old for comprehension syntax in r24958, I
managed to instead only remove the deprecation warnings. No wonder it
went so smoothly. Sorry to get your hopes up only to execute you, old
syntax. Now the for comprehensions have to get it right:
for (x <- 1 to 5 ; y = x) yield x+y // nope
for (val x <- 1 to 5 ; y = x) yield x+y // nope
for (val x <- 1 to 5 ; val y = x) yield x+y // nope
for (x <- 1 to 5 ; val y = x) yield x+y // that's the one
No review.
|
| |
|
|
|
|
|
| |
Fixing all the tests and source which still use the old for
comprehension syntax with vals where there are no vals and no vals where
there are vals. No review.
|
| |
|
|
|
|
|
|
|
|
| |
Fix for a bug in CharArrayReader which made triple quoted strings
fail to parse sometimes. Note: when the temptation strikes to adjust
for special cases by letting the regular case happen and subsequently
attempting to fix the ball of mutation by selectively applying what
seems like the inverse operation, please consider the possibility that
this is not the optimal approach. Closes SI-4785, no review.
|
| |
|
|
|
|
| |
Better error message for case class/object match confusion. Closes
SI-4879, no review.
|
| |
|
|
|
|
| |
Avoid some spurious errors after a cyclical reference error. Closes
SI-2388, no review.
|
| |
|
|
|
|
| |
Improved structural type error messages, and other error message related
boosts. Closes SI-4877, review by odersky.
|
| |
|
|
|
|
|
|
| |
Fixed bug in the disambiguation of f(foo='bar') style method calls in
the presence of overloading, parameterization, and by-name arguments.
Took the opportunity to clean things up a little bit. Closes SI-4592,
review by rytz.
|
| |
|
|
|
|
|
| |
Disallowed implicit modifier on auxiliary constructors, since it either
silently accomplishes nothing or crashes the compiler. If it should do
something useful let me know. Closes SI-4882, review by odersky.
|
| |
|
|
|
|
|
|
| |
Don't want to chase NPEs around for the rest of my life. Created
"NoCompilationUnit" and "NoSourceFile" objects to represent not-present
versions of these items. Seems a lot better than null. References
SI-4859, got past NPE only to uncover the actual problem. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Attacked classpaths to get "." off of it when it's not actually
specified. The commit makes me nervous, but there's no invisible way to
fix something like this.
** Attention, this commit changes classpath handling **
We desperately need some way of testing that the classpath has certain
qualities and does not have others; partest is not that way. Closes
SI-4857, no review.
|
| | |
|
| | |
|
| |
|
|
|
| |
Oops, let unnecessary boxing creep into that last commit, no review.
|
| |
|
|
|
|
|
| |
Rewrote the case class synthetic equals method to be more efficient and
to cause fewer problems for compiler hackers who are always saying stuff
like "the only place this comes up is case class equals..." No review.
|
| |
|
|
|
|
|
|
|
| |
Reverting the inline exception handlers while I figure out what is
breaking the bytecode. (doesn't seem obvious, might take some time to
figure it out)
No review.
|
| | |
|
| |
|
|
|
| |
Cleanups in synthetic method generation, no review.
|
| |
|
|
|
| |
Issue a warning about classes/objects inside package objects, no review.
|
| |
|
|
|
|
|
|
| |
Cleanups in Namers and AddInterfaces emerging from bugfixing attempts
and comprehension pursuits. I appear to have accidentally fixed at least
one bug, as there are new (correct) warnings when building the compiler
involving permanently hidden imports. No review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a command line script to ~/tools to count flag usages. I'm
checking this in less out of the enormous demand for flag counting
scripts than because I wanted to lower the barrier to people writing
reusable bash scripts.
*** DO YOU WANT TO WRITE NICE BASH SCRIPTS? ***
*** Look at tools/flag-usages.sh ***
*** It's easy to understand and full of helpful comments! ***
I'm not making any claims here about having massive bash expertise,
but I know a lot of people resist learning any of it (I was once like
you) so I wanted to lower the barrier a little. Because as a mechanism
for the composition and modification of the world of existing tools,
nothing comes close to the shell. And I know many of us write way too
many one-offs which we delete in shame and horror shortly after their
immediate purpose is served.
No review. (I should say r-e-v-i-e-w by everyone but I'm sure it would
give me a nice pile of crucible errors.)
|
| |
|
|
|
|
|
| |
Adds version information from @migration and @deprecated to ScalaDoc.
Adds support for @migration in Symbols and MemberEntity. Contributed by
Simon Ochsenreither. Review by heathermiller.
|
| |
|
|
|
|
| |
Finished up some backend cleanups I'd had lying around since scala days.
No review.
|
| |
|
|
|
|
|
|
|
| |
Took a different tack on avoiding unnecessarily final bytecode methods
after discovering the inliner is not a fan of any reduction in finality.
Restored the application of the lateFINAL flag in makeNotPrivate, and
switched to sorting out who is ACC_FINAL and who isn't in genjvm. Review
by dragos.
|
| |
|
|
|
|
| |
Made error messages like "object List is not a value" be a little more
helpful about why that is. No review.
|
| |
|
|
|
|
| |
Minor changes to the Scaladoc stylesheets, as suggested by Simon
Ochsenreither. Closes SI-4499. No review.
|
| |
|
|
|
|
|
|
| |
Merged enhancements made to scaladoc filter panel by Ruediger Keller.
Enhancements include faster filtering, automatically focused text input
field, improved searching (no regex syntax, so now its possible to
search for members like ++). No review.
|
| | |
|
| |
|
|
|
| |
Rename a file to celebrate our glorious ant overlords, no review.
|
| |
|
|
|
| |
A couple low impact cleanups/optimizations, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tired of ugly-printing in the repl, I sort of finished some old code for
pretty printing token streams. It is at least a lot prettier than it
once was, and I threw in some power mode helpers. Now you can do this.
% scala -Dscala.repl.power
Welcome to Scala version 2.10.0.r25427-b20110801144412 (Java HotSpot(TM) 64-Bit Server VM, Java 1.6.0_26).
// .u turns a string into an URL like .r does into
a regex, and .pp pretty prints the url scala>
"https://raw.github.com/scalaz/scalaz/master/example/src/main/scala/scal
az/example/ExampleIteratee.scala".u.pp package scalaz.example
object ExampleIteratee {
def main (args: Array[String]) = run
import scalaz._
import Scalaz._
import IterV._
[etc it's all there in real life]
}
No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sped up traversal over mutable maps by a factor of two.
There was this comment in HashTable explaining why foreach was
implemented in terms of iterator. /*
* We should implement this as a primitive operation over the
* underlying array, but it can cause a behaviour change in edge cases
* where:
* - Someone modifies a map during iteration
* - The insertion point is close to the iteration point.
*/
Item 1: foreach and iterator didn't behave the same if the map was
mutated in the midst of the traversal anyway. Item 2: protecting some
particular undefinition of inherently undefined behavior is a pretty
unconvincing reason to impose a 2x penalty on foreach.
Here are the before/after times for traversing the keys with foreach
vs. with iterator. Same impact on values and on the map itself. The
benchmark code is included in this commit.
before: foreach 143700900 iterator 143848900
after: foreach 67024400 iterator 144890300
Respecting the fact that this might be causing some behavior somewhere
to change, even though it would be pretty sick to be relying upon it,
** ATTENTION! POSSIBLE BEHAVIOR CHANGE! **
Review by dragos.
|
