| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
| |
TypeTag.String is removed because it's unclear whether it should point to
scala.Predef.String or to java.lang.String. ClassTag.String is removed to
be consistent with TypeTag.String.
This requires re-bootstrapping, because Definitions.scala in locker
expects classTag[String] being automatically generated, whereas starr
disagrees with locker on how to generate that class tag.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) type ClassManifest[T] = ClassTag[T] (solves a problem
with toArray[T: ClassManifest] defined on most of the collections;
if these types weren't aliases, then we won't be able to change
the signature of that method to toArray[T: ClassTag], because
that would break source compatibility for those who override
toArray in their custom collections)
2) Compiler-generated manifests no longer trigger deprecation warnings
(this is implemented by using ClassManifestFactory instead of ClassManifest
and ManifestFactory instead of Manifest)
3) Deprecation messages got improved to reflect the changes
that were introduced in 2.10.0-M4.
|
| |\
| |
| | |
SI-4176 A repeat dose of repeated parameter type sanitization.
|
| | |
| |
| |
| |
| |
| |
| | |
- During eta expansion, treat parameters of type A* as Seq[A]
- Do the same for method/class parameters as referred to by an Ident.
Also fixes SI-5967, which shows up during pattern matching.
|
| |\ \
| | |
| | | |
SI-5932 Tone down non-sensible == warning with refinements.
|
| | | |
| | |
| | |
| | | |
Errs on the side of avoiding false positives.
|
| |/ / |
|
| |\ \
| | |
| | | |
Revert pull request #720 (CPS: enable return expressions in CPS code if ...
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
are in tail position)
Reverts commit 0ada0706746c9c603bf5bc8a0e6780e5783297cf.
Reverts commit 51c92f02229098d0b402a65a72267f7a17984022.
Reverts commit cdfbe8e39fbbec00c969cd74f117ae410b98b40b.
Reverts commit 796024c7429a03e974a7d8e1dc5c80b84f82467d.
|
| |\ \ \
| | | |
| | | | |
Don't just swallow `Throwables` while parsing bytecode. Print a warning
|
| | | | |
| | | |
| | | | |
This has caused hours of debugging, to find out that 'package X does not have a member Y' were caused by a `NullPointerException`.
|
| |\ \ \ \
| | | | |
| | | | | |
Fix range positions when applying anonymous classes.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
@odersky
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
patmat bugfixes and minor clean ups
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
one of the most boring sealed types imaginable, but a sealed type all the same
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
the fix in 0cffdf38d9 was brain dead (only looking at the first argument of the ctor, rather than the first argument list)
the reasoning was that we should not look at the MethodType of the constructor,
but at the argument types directly (since going through the method type would flip variance,
though the ctor arguments are conceptually in covariant positions here)
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
patmat:
- remove Var's unused 'checked' member; subsumed by 'domain'
- updated docs: no longer using isSuccess in __match
typers: clean up indentation, swap ifs to failure-first
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Closes SI-5148.
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Unfortunately we have to wrap transform to catch all
the MissingRequirementErrors exceptions (wrapped in TypeErrors).
This is because we force the info of the symbol in a couple of
places and we would have to catch all/some of them
(and remove the duplicates as well which really becomes messy).
Review by @axel22.
|
| |\ \ \ \
| | | | |
| | | | | |
emit JVM InnerClasses attribute for bean info classes
|
| | | |_|/
| |/| | |
|
| | |/ /
|/| | |
|
| |\ \ \
| | | |
| | | | |
Statistics improvements and bug fixes.
|
| | | | |
| | | |
| | | |
| | | | |
Added compile-time option hotEnabled to Statistics that can be used to count very high frequency methods with 0 overhead for the disabled case. Fixed problem with weak maps that caused some timers to be discarded prematurely before they could be printed. Fixed problem with accouning for stacked timers.
|
| |\ \ \ \
| |/ / /
|/| | | |
Minor followup on SI-4842: remove awkward condition. Review by @retronym
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | | |
SI-5966 Fix eta expansion for repeated parameters with zero arguments.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Reworks part of e33901 / SI-5610, which was inserting an <empty> tree
as an argument in this case, which turns into a null in icode.
|
| |\ \ \ \
| |_|_|/
|/| | | |
SI-5968 Eliminate spurious exhaustiveness warning with singleton types.
|
| | | | |
| | | |
| | | |
| | | | |
A singleton type is a type ripe for enumeration.
|
| |\ \ \ \
| | | | |
| | | | | |
Added a key comment.
|
| | |/ / /
| | | |
| | | |
| | | |
| | | | |
The commit message from f4d2678c42 works a lot better up close
and personal with the change.
|
| |\ \ \ \
| |/ / /
|/| | | |
SI-4989 Reject super.x if an intermediate class declares x abstract.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is in line with Java's treatment. Without this, an AbstractMethodError
is thrown at runtime.
|
| |\ \ \ \
| |_|_|/
|/| | | |
Fix SI-5284.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The problem was the false assumption that methods specialized
on their type parameter, such as this one:
class Foo[@spec(Int) T](val x: T) {
def bar[@spec(Int) S >: T](f: S => S) = f(x)
}
have their normalized versions (`bar$mIc$sp`) never called
from the base specialization class `Foo`.
This meant that the implementation of `bar$mIc$sp` in `Foo`
simply threw an exception.
This assumption is not true, however. See this:
object Baz {
def apply[T]() = new Foo[T]
}
Calling `Baz.apply[Int]()` will create an instance of the
base specialization class `Foo` at `Int`.
Calling `bar` on this instance will be rewritten by
specialization to calling `bar$mIc$sp`, hence the error.
So, we have to emit a valid implementation for `bar`,
obviously.
Problem is, such an implementation would have conflicting
type bounds in the base specialization class `Foo`, since
we don't know if `T` is a subtype of `S = Int`.
In other words, we cannot emit:
def bar$mIc$sp(f: Int => Int) = f(x) // x: T
without typechecking errors.
However, notice that the bounds are valid if and only if
`T = Int`. In the same time, invocations of `bar$mIc$sp` will only
be emitted in callsites where the type bounds hold.
This means we can cast the expressions in method applications
to the required specialized type bound.
The following changes have been made:
1) The decision of whether or not to create a normalized
version of the specialized method is not done on the
`conflicting` relation anymore.
Instead, it's done based on the `satisfiable` relation,
which is true if there is possibly an instantiation of
the type parameters where the bounds hold.
2) The `satisfiable` method has a new variant called
`satisfiableConstraints`, which does unification to
figure out how the type parameters should be instantiated
in order to satisfy the bounds.
3) The `Duplicators` are changed to transform a tree
using the `castType` method which just returns the tree
by default.
In specialization, the `castType` in `Duplicators` is overridden,
and uses a map from type parameters to types.
This map is obtained by `satisfiableConstraints` from 2).
If the type of the expression is not equal to the expected type,
and this map contains a mapping to the expected type, then
the tree is cast, as discussed above.
Additional tests added.
Review by @dragos
Review by @VladUreche
Conflicts:
src/compiler/scala/tools/nsc/transform/SpecializeTypes.scala
src/compiler/scala/tools/nsc/typechecker/Duplicators.scala
|
| |\ \ \ \
| |_|_|/
|/| | | |
SI-2807 Resurrect and refine the promiscuous catch warning.
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous incarnation didn't survive 4fb3473.
This version can be cleared by using a typed pattern: `catch { case _: Throwable => }`.
This is motivated by the recent appearance of such a catch in `util.Try`, and by battle
scars left by one too many processes bravely but stupidly catching and logging OutOfMemoryErrors.
-Y status has been skipped: this warning is enabled by default and can only be silenced
with use of a typed pattern.
|
| |\ \ \
| | | |
| | | | |
Issue/hardening compiling with newer sources
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
When a symbol needed in Definitions is loaded, it may be that the corresponding source is newer than
the classfile. That will send it to `compileLate`, but no phase is yet set. We simply add it to the
compilation pipeline and continue gracefully.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
The parser special-cases primitive types. For comparing the name, it relied on having the symbols
for primitive types already loaded, which is not always the case. The presentation compiler
may parse sources for, say, scala.Int, and therefore the symbol for Int may not be yet available.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
When the presentation compiler needs a SourceLoader, instead of immediately adding the file
to the compilation round it uses a fast parser to create symbols for all top-level class definitions.
The fast parser assumes Scala sources, which is not always the case.
|
| |\ \ \ \
| | | | |
| | | | | |
SI-4842 Forbid access to in-construction this in self-constructor args
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
The check was already in place for direct calls to the super constructor.
Without this additional check, ExplicitOuter crashes, as it doesn't create
an $outer pointer for the constructor-arg scoped inner object, but expects
one to exist when transforming the Outer.this reference.
|
| |\ \ \ \
| |_|_|/
|/| | | |
SI-5617 Better error message for "x overrides nothing".
|
| | |/ /
| | |
| | |
| | | |
"It looks like you're trying to override a method", notes Clippy.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As usual, .tpe -> .tpeHK. As a side note following an old theme,
if symbols of type parameters knew that they were symbols of type
parameters, they could call tpeHK themselves rather than every call
site having to do it. It's the operation which injects dummies which
should require explicit programmer action, not the operation which
faithfully reproduces the unapplied type. Were it that way, errors could
be caught much more quickly via ill-kindedness.
Seems like an improvement over lurking compiler crashes at every call
to tparam.tpe.
|
| |\ \ \
| | | |
| | | | |
Fix SI-4541.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Catch type errors when duplicating trees.
In this case, to access a protected member from a specialized
class is an error, so we would have to make the member public
anyway.
Better it is then to report an error and have the user make the
field public explicitly.
Review by @dragos.
|
