| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Reverts r23174, which I believe will bring the build back to life. It
only chokes under -optimise. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patches for #3887 and #3888, but I determined that I could achieve the
same effect by deleting a bunch of code, so I did. This left only a few
lines in TransMatch, so I eliminated it, which led me to remember that
many places still reference non-existent phase transmatch, so those were
updated. Notes:
* This swaps equality tests on stable identifier patterns. They
have never conformed to the spec (as noted long ago in ticket #785)
which says "The pattern matches any value v such that r == v" whereas
until now the test being performed was v == r.
* An issue was introduced with specialization in that the implementation
of "isTupleType" in Definitions relied upon sym == TupleClass(elems.length).
This test is untrue for specialized tuples, causing mysterious behavior
because only some tuples are specialized. There is now "isTupleTypeOrSubtype"
although it seems likely the former implementation is unnecessary.
The issue is sidestepped if one uses "getProductArgs" to retrieve the element
types because it sifts through the base types for the Product symbol.
Closes #3887 and #3888, review by dmharrah.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes a bunch of private functions which are never called. While based
on the nature of "private" one can generally feel pretty good that such
a thing is safe, there is always a chance the author had some future use
in mind. On that note I draw your attention in particular to:
(martin) Typers#stabilizedType: it "sounds" important, but most of it
has been commented out since 2007 and the little stub part is a never
called private.
(iulian) SpecializeTypes#makeTypeArguments: similarly sounds like a
cornerstone of a transformation until one notices it isn't used.
Unused methods are "attractive nuisances" for anyone (like myself) who
has to figure out how the compiler works by studying the compiler, for
reasons which are no doubt obvious. No review except as noted.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
zippedWithIndex and zippedAll added to ParIterable. ZippedAll view
reimplemented. No review
|
| |
|
|
|
|
| |
Adds a zip for ParIterables + a new Zipped view for ParSeqView and
ParIterableView + a bench test. No review
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Revert "CPI -> SCPI to (hopefully) fix scaladoc failure in nightly.
probably indicates a bug in scaladoc or the type checker or the spec,
since abstract type members seem to be allowed in objects inconsistently
across these three. no review."
that was a little too hasty.. SCPI was already defined somewhere
This reverts commit 165424cd9175d7e6d33bc541f2aff2575ee31121.
|
| |
|
|
|
|
|
|
| |
CPI -> SCPI to (hopefully) fix scaladoc failure in nightly. probably
indicates a bug in scaladoc or the type checker or the spec, since
abstract type members seem to be allowed in objects inconsistently
across these three. no review.
|
| |
|
|
|
|
| |
Added an override to immutable.IndexedSeq#toIndexedSeq which returns
itself. Closes #3732, no review.
|
| |
|
|
|
| |
no review.
|
| |
|
|
|
|
| |
Reimplementing parallel views to solve several performance glitches. No
review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Changed Seq#distinct to use a mutable hashset rather than an immutable
one in a var. The benchmarks are not close: it's anywhere from 2 to 3
times faster this way. Majority of the credit goes to Tiark for slyly
leaving a comment where I could see it.
TR: should use mutable.HashSet?
PP: yes. yes we should.
Review by community.
|
| |
|
|
|
|
| |
Tail recursive implementation of mapConserve, submitted by Eric
Willigers. Closes #2411, review by malayeri.
|
| | |
|
| |
|
|
|
|
| |
Fixed an issue with ListSet getting confused about what goes forward and
what goes backward. No review.
|
| |
|
|
|
|
| |
Refactorings to make iterators required by task objects less restricted.
No review
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tweaks to ListSet to make it less pathological in its outlook. We
can see some modest improvements in run time and answer quality via the
enclosed test case:
// with this patch: 2.250s elapsed, assertions pass.
// without this patch: 51.441s elapsed, and it's
a mercy killing: java.lang.StackOverflowError at
scala.collection.immutable.ListSet$Node.contains(ListSet.scala:117) at
scala.collection.immutable.ListSet$Node.contains(ListSet.scala:117)
Closes #3822, review by community.
|
| |
|
|
|
|
|
| |
Does what can probably be done about strange iterator exhaustion
behavior. Maybe we should start thinking about iteratees... Closes
#3760, no review.
|
| |
|
|
|
|
| |
Modified XMLEventReader to write dummy <ignore/> tag only once.
Contributed by Jean-Laurent Huynh, reviewed by extempore. Closes #3840.
|
| |
|
|
|
|
| |
support in MarkupParser to use a Queue instead of a Stream. Contributed
by Jean-Laurent Huynh, reviewed by extempore. Closes #3720.
|
| |
|
|
|
|
| |
but remains open until we determine how to handle jagged lists. No
review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Transform-derived traits within view resisted evaluating the entire
sequence on a toString call, but the original view returned from a call
to .view did not. This has a particularly bad result in the case of
Stream, as for instance:
Stream from 1 view
would enter infiniteloopiland in the repl despite the fact that it
should be doubly resistant to eager evaluation.
Review by prokopec.
|
| |
|
|
|
|
| |
Gave StringBuilder a StringLike parent as endorsed by martin in
http://www.scala-lang.org/node/6893 . Review by odersky.
|
| |
|
|
|
|
|
| |
Added implicits to create Orderings from java's Comparable and
Comparator interfaces. Also some cleanup in Sorting. Review by
community.
|
| |
|
|
|
|
|
|
| |
Stream gets a specialized, extra-lazy Iterator so it can iterate as
lazily as it traverses. Patch submitted by "Eastsun": probably not
his real name, but that's what we call him. Closes #3273, review by
prokopec.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Interpreted absence of any objections in mailing list thread
http://www.scala-lang.org/node/7398 as implicit encouragement to
proceed. Adds complementary implicits to Predef such that the eight
primitive types are both boxed and unboxed as the occasion demands.
Review by odersky.
|
| | |
|
| |
|
|
|
|
|
| |
Proposed implementation of 'unlift' on Function1, the inverse function
of PartialFunction#lift. Review by rytz and other interested parties.
References #3825, but not closing until this is further considered.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Fixes infinite loop when appending a ListBuffer to itself. Review by
extempore.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Brought the files in scala.collection.interfaces up to date,
for whatever purpose they may someday serve. Also deprecated
Seq.findIndexOf, which is identical to indexWhere and must have been
overlooked when deprecations were being handed out. No review.
|
| |
|
|
|
|
|
| |
Makes utility methods in the ArrayStack companion object private.
No review.
|
| | |
|
| | |
|
| | |
|
| | |
|
