| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
Fixed a failure output regression I introduced working around a process
bug. Unrolled the code I'd put in to work around the now-fixed process
bug. No review.
|
| |
|
|
|
|
|
|
|
|
| |
Enhancing the repl-testing code by turning it into a transcript
producing machine. "Here's some code." "Here's a transcript!" "Good day
to you, sir!" "No, good day to YOU!"
These changes are awesome. Look at the checkfile diffs for god's sake,
they'll make you weep with joy. No review.
|
| |
|
|
|
|
| |
Fixing the scalap test rig to work like other test types so it doesn't
break the distribution build. No review.
|
| |
|
|
|
|
| |
Spiced up the signature test infrastructure a bunch, wrote some more
tests, restored the tests in pending. No review.
|
| |
|
|
|
|
|
|
|
|
| |
Not yet learned my lesson about partest and empty directories. Rather
than reapply that bandaid, went after partest. Attempts to make partest
ignore empty directories. Discover directory tests aren't run when the
command line tool is used, make them run like everyone else. Find more
tests which due to misplacement are silently ignored, move them into
tested locations. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I'm laptop only so there's some chance this will incur temporary
breakage, but it needs committing.]
Heading off gratuitous complications which haven't yet shipped, I
eliminated the -jar startup option in favor of doing what we already do,
figuring it out. So now all these things work.
scala foo/bar.scala // if file is a script or has one main method
scala foo.Bar // if it has a legal main method scala foo.jar // if it
has a legal MainClass attribute
Also changed "-savecompiled" to "-save" and given scala source called
foo.scala, generate foo.jar rather than foo.scala.jar. Cleaned up a
bunch of related code and further polished the scala startup message.
And unbroke choice settings and improved that error too, which closes
#3849.
While trying to write a test for the choice setting, was reminded that
partest just discards invalid flags files. Made it fail instead, which
closes #3712. Fixed the new failures that revealed. No review.
|
| |
|
|
|
|
|
|
|
| |
Always forget that checking system properties causes exceptions in
applets and such. Made the system property wrapper wrap its access
checks in some more wrapping. I spent a long time trying to write a
test for the security manager but it's hopeless without knowing all the
details of the test environment. Closes #4346, no review.
|
| |
|
|
|
|
|
|
|
|
|
| |
warnings due to my changing a map from mutable to immutable (which
ought to be the good direction) because "def update" still lingers on
immutable maps. I counted the days elapsed since it was marked for death
(before 2.8.0) and added in the bugliness of what I was looking at and
bid it farewell.
Now removed: def update on immutable maps. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all view classes now list parents like
trait Appended[B >: A] extends super.Appended[B] with Transformed[B]
instead of the former
trait Appended[B >: A] extends Transformed[B] with super.Appended[B]
because as it was, the implementation of foreach in
TraversableViewLike#Transformed was repeatedly trumping overrides found
in e.g. IterableLike. This change was not without its own consequences,
and much of the rest of the patch is dealing with that. A more general
issue is clearly revealed here: there is no straightforward way to deal
with trait composition and overrides when some methods should prefer B
over A and some the reverse. (It's more like A through Z in this case.)
That closes #4279, with some views being five orders of magnitude slower
than necessary. There is a test that confirms they'll stay performance
neighbors.
In the view classes (Zipped, Mapped, etc.) I attended to them with
comb and brush until they were reasonably consistent. I only use
"override" where necessary and throw in some "final" in the interests
of trying to anchor the composition outcome. I also switched the
newSliced, newZipped, etc. methods to use early init syntax since a
number have abstract vals and I found at least one bug originating with
uninitialized access.
There was a piece of a parallel collections scalacheck test failing,
which
I disabled out of expedience - am emailing prokopec.
There is plenty of work left to do but paulp must get back to other 2.9
issues. This is the Zurich->SF airplane patch. No review.
|
| |
|
|
|
|
| |
More signature work arising from actually looking at the signatures.
Slightly improved the coverage of the tests. No review.
|
| |
|
|
|
|
|
| |
Break 9 tests, fix 9 tests, realize you broke the test you checked in
between +9 and -9. Fix that and generalize the repl tests a little. I
think we're all the way there. No review.
|
| |
|
|
|
|
|
|
| |
Added new setting -Ygen-javap, which takes a directory as an argument
and generates javap output for every generated classfile. There is still
a lot of noise in a diff: still todo is postprocessing the output to
remove diff-noise-generating numbers and such. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I chased a lot of ghosts before finding the real culprit for why partest
failures have been unfailing.
Process(Seq("bash", "-c", "exit 42")) ! // 42 Process(Seq("bash",
"-c", "exit 42")) #> logFile ! // 0
That behavior is not yet fixed, but I altered partest not to use #> and
fixed the test which should have been failing but wasn't. Closes #4227,
no review.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
partest --grep has never worked quite right (at least not in the
"sideported" version.) Now it looks harder for matching tests: the check
file or any java or scala source file can match. And directory based
tests will be properly included. Try it out:
test/partest --grep java
No review.
|
| | |
|
| |
|
|
|
| |
things which used it to use sys.process. No review.
|
| |
|
|
|
| |
Made partest update a checkfile even if it doesn't exist. No review.
|
| | |
|
| | |
|
| |
|
|
|
| |
multiple-reporting-of-failures bug. No review.
|
| | |
|
| |
|
|
|
|
| |
One element of the partest situation: Reporting and recovering correctly
when the compiler crashes. No review.
|
| |
|
|
|
|
|
|
| |
Added specialized test to ant build, and ported old specialized 'run'
tests to check the number of boxings.
No review.
|
| |
|
|
|
|
|
|
|
|
| |
Added a new test group - specialized.
Modified partest to add a jar with instrumented classes to classpath when compiling and running tests.
Added a primary version of the instrumented BoxesRuntime, and a script to produce a jar for it.
Added the 'speclib' folder to partest files, which contains the jar with the instrumented classes.
Review by dragos.
|
| |
|
|
|
|
|
|
| |
prejudice and puts the new process code to work instead. There are still
a couple bugs on my short term partest list. If this commit causes some
weird issue which only arises on virtualized windows you can expect to
hear from me next by postcard from st. lucia. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Imported sbt.Process into trunk, in the guise of package
scala.sys.process. It is largely indistinguishable from the version in
sbt, at least from the outside.
Also, I renamed package system to sys. I wanted to do that from the
beginning and the desire has only grown since then. Sometimes a short
identifier is just critical to usability: with a function like error("")
called from hundreds of places, the difference between system.error and
sys.error is too big. sys.error and sys.exit have good vibes (at least
as good as the vibes can be for functions which error and exit.)
Note: this is just the first cut. I need to check this in to finish
fixing partest. I will be going over it with a comb and writing
documentation which will leave you enchanted, as well as removing other
bits which are now redundant or inferior. No review.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
StreamAppender is the leader among suspicious things which look like
they freeze things, so I started ripping it out. Again. No review.
|
| |
|
|
|
|
|
|
|
|
| |
down the long and freezy road once again. With this patch you can send a
SIGHUP to partest and it will spew a bunch of internal state. It is also
possible I fixed the underlying issue by cleaning up the super fragile
dependence on counters never getting the least bit off track. If fixed,
it'll still be fun to send signals. If not, this will be coming in handy
reeeeeal soon. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mopping up after the deprecation of exit and error. It is decidedly
non-trivial (at least for the IDE-impaired) to be completely sure of
which error function was being called when there were about twenty with
the same signature in trunk and they are being variously inherited,
imported, shadowed, etc. So although I was careful, the possibility
exists that something is now calling a different "error" function than
before. Caveat programmer.
(And let's all make it our policy not to name anything "error" or "exit"
from here on out....) No review.
|
| |
|
|
|
|
|
| |
You shall not pass the testing stage when abort crashes the resident
compiler. previously it succeeded even though the error message was
printed. Review by phaller
|
| |
|
|
|
|
| |
(apparently) the bug which has had me chasing concurrency ghosts
throughout the haunted castle. No review.
|
| |
|
|
|
|
| |
partest sets javaccmd system property when running tests. Review by
dragos.
|
| | |
|
| |
|
|
|
|
|
|
| |
Ported --update-check from partest-alternative to partest actual. Once
again all can daily demonstrate their amazing resolve by not mass
updating checkfiles by the hundreds with whatever the current output
happens to be. No review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Some exception handling fixes in parallel collections. Fixed some
regressions. Fixed some tests.
No review.
|
| |
|
|
|
|
| |
One more partest fix where output was redirected using a global
variable, causing errors with multiple actors. Review by plocinic
|
| |
|
|
|
|
|
|
|
| |
Log file is printed now right away if:
- test fails due to an exception thrown in the a test
- test fails due to a ScalaCheck test fail
- test fails due to compiler errors in ScalaCheck tests
Review by extempore.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Solved issues with fork join pool creators, and the issue with
scalacheck output.
Done by Philipp and me.
Review by phaller.
|
| |
|
|
|
|
|
| |
Fixed a scalacheck test group "test entire subdirectory" problem. It's
now possible to add scalacheck tests consisting of multiple files. No
review.
|
| | |
|
| |
|
|
|
|
| |
Fixes the way results of Scalatest are checked by Partest. Contributed
by Kato Kazuyoshi. Review by phaller.
|
| |
|
|
|
|
| |
Enabled partest to run entire directories for scalacheck test group.
Review by extempore.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Couldn't bear to see sbt seemingly so close but still unable to run
tests. Made some progress but bogged down in scalacheck when I realized
things were farther from working than I'd thought. Please forgive this
brief expression of frustration, because the despair is palpable:
the weeks of work I did on partest was apparently of no interest,
and now I'm in here having to fix the same partest bugs again, in a
more virulent form. They've evolved into some kind of ant-partest-sbt
artificial creature, more fearsome than any one of them could be under
its own power.
Did we not know we have a whole directory full of pretty code like this?
List(
"Scala compiler classes in: " + testBuildDir,
"Scala version is: " + nsc.Properties.versionMsg,
"Scalac options are: " + universe.scalacOpts,
"Java binaries in: " + javaBin,
"Java runtime is: " + javaInfoString,
"Java runtime options: " + (Process.javaVmArguments mkString " "),
"Javac options are: " + universe.javacOpts,
"Java options are: " + universe.javaOpts,
"Source directory is: " + src,
"Selected categories: " + (selectedCategories mkString " "),
""
) mkString "\n"
It's src/partest-alternative in case anyone wants to consider any of it.
At the very least there are individual files or functions which could be
cherry picked.
-- This patch contains: --
Readability efforts. Twelve parameter functions whose last six
parameters are "true,true,failedOnly,true,false,log" are pretty
challenging to work with.
Changes to the environment variables sbt was setting to look a bit more
like what partest expects and will crash without.
Sets partest.debug=true if the sbt logger level is at Debug.
On my machine all test groups except scalacheck appear to run to
completion.
Review by moix. (Hello, moix! I am available for assistance if you are
in the market for it. You have brought us long suffering ant-ers to the
brink of sbt goodness: and now, we enter the fray!)
|
| |
|
|
|
|
| |
Unbroke the command line ~/test/partest tool, which was displeased at
being unable to find scalacheck.jar. No review.
|
| |
|
|
|
|
|
| |
Partest changes - partest now uses scalacheck.jar from the build/pack dir.
Review by phaller.
|
