| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following up on things that -Xlint told me, sometimes because Mr. Linty
was being sensible and other times just to shut him up so we can hear
better in the future.
- made xml.Equality public because it occurs in public method signatures
- made some actor classes with inaccessible-unoverridable methods final
- eliminated a bunch of "dead code follows" warnings by deleting the
dead code which really did follow - improved the reliability of warnings
about inaccessible types
For the changes in actors, review by phaller.
|
| | |
|
| |
|
|
|
|
|
| |
Fixing the very broken build (was going for "compiling" mostly because
I can't be sure what to do with some of this) really this code is
certainly not correct, please review by odersky.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Ywarn-adapted-args // also included in -Xlint
-Yno-adapted-args
The former warns when a () is inserted or an argument list is implicitly
tupled. The latter errors under the same conditions. Using these options
I found several bugs in the distribution which would otherwise be nearly
impossible to spot. These bugs were innocuous (I think) but similar bugs
could easily be (and have been) otherwise.
Certain particularly threatening scenarios are at minimum warned about
regardless of options given. Closes SI-4851, no review.
|
| |
|
|
|
|
|
|
| |
Turned off the notFINAL flag which was applied to expanded name methods
due to java breakage, on the principle of "first, do no harm." If there
is some rationale why these methods must be made final, let's at least
get it documented. Review by dragos.
|
| |
|
|
|
|
|
|
| |
Expression type argument instantiation should not fail in a context
expecting Unit if there is any valid instantiation, because value
discarding should kick in and offer a literal (). Closes SI-4853, review
by odersky.
|
| |
|
|
|
| |
Remove sigint handler on repl exit as a sanity check, no review.
|
| | |
|
| |
|
|
|
|
| |
Scaladoc shouldn't drop type arguments to aliased tuple. Related to
SI-4676. Review by pedrofurla.
|
| |
|
|
|
|
|
| |
Changed forwarders not to generate final methods, which otherwise would
induce VerifyErrors anytime the companion class was subclassed and had a
method with the same signature. Closes SI-4827, no review.
|
| |
|
|
|
|
| |
Some tweaks to repl thread creation based on speculation from mark
harrah, no review.
|
| |
|
|
|
|
| |
comments into code comments for reference by me or some lucky future
person. No review.
|
| |
|
|
|
|
| |
"Freed the lisp test." Tweaked partest defaults a little in the hopes
that seth tisue is correct in his analysis. No review.
|
| |
|
|
|
|
|
|
|
|
| |
Fix/workaround for inliner bug uncovered by finalizing Option methods.
Something in the backend is leaving open but empty blocks in the
worklist. Rather than freaking out at the merest mention of an empty
block, I quietly remove the empty ones. A proper fix will involve not
leaving empty blocks lying around but we're on a schedule here people.
Review by dragos.
|
| |
|
|
|
| |
No review.
|
| |
|
|
|
|
| |
Discard empty strings in option position, but not in argument position.
Closes SI-4782, no review.
|
| |
|
|
|
|
| |
Enable implicit parameters in the presence of view- or context bounds.
Fix SI-4839. Review by moors.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Always escape control characters when printing trees.
Escaping of control characters should be performed for both Char and
String constants. This is useful when printing trees of a program that
contains control character as constants. Before that fix, one could get
really broken output that was hard to read.
Review by extempore.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Since trunk seems to be undergoing all kinds of changes of the sort
which touch lots of files, the time is ripe for various search/replace
improvements which have stacked up. This one is the replacement of all
"if (settings.debug.value) log" with "debuglog" since as noted in a
recent commit, the inliner will take care of that for you. No review.
|
| |
|
|
|
|
|
|
| |
Start of an attempt to abstract above some hardcoded name mangling
decisions so they can be modified, something we need to do to fix
long-standing problems with inner classes. It's not easy. This commit
doesn't actually change much, it's primarily setup. No review.
|
| | |
|
| |
|
|
|
| |
Small fix to mirrors in treatment of primitive types. No review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per discussion documented in SI-1799, brought back the ProductN
traits and synthesized them into case classes. It's -Xexperimental for
now because there may be minor implications for existing code which
should be discussed. And also because I snuck in another "improvement"
but it's probably too dangerous to be touching productIterator directly
and it should go into something else.
scala> case class Bippy(x: Int, y: Int)
defined class Bippy
scala> Bippy(5, 10).productIterator
res0: Iterator[Int] = non-empty iterator
^^^----- as opposed to Iterator[Any]
There is an even better idea available than lubbing the case class field
types: it starts with "H" and ends with "List"...
Review by oderksy.
|
| | |
|
| |
|
|
|
|
| |
Adding mirrors top connect reflection to something real without going
through Java.
|
| |
|
|
|
| |
Fleshed out Scala -> Java mapping; dealing with arrays. No review.
|
| |
|
|
|
| |
Fixed doc comments of the keys and values methods in MapLike. No review
|
| |
|
|
|
| |
4th round of clean ups (see r25293, r25285, r25292)
|
| |
|
|
|
|
| |
Fleshed out reflection that now also correctly interpretes Java classes.
We are getting there! No review; let's wait until it is complete.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating signatures, one must be careful finding the name of a
class, because sometimes things with a name like "Foo" need to appear in
signatures as "Foo$". I could really use some help establishing tests
here. Here's the diff of RedBlack's javap:
< const #81 = Asciz ()Lscala/collection/immutable/RedBlack<TA;>.Empty;;
---
> const #81 = Asciz ()Lscala/collection/immutable/RedBlack<TA;>.Empty$;;
RedBlack and RedBlack$Empty$ are the only classfiles in the library
outside of swing which are affected, which nicely explains their
frequent appearance in past tickets.
Review by grek.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think it a reasonable goal that one should be able to do the following
and have some chance of seeing anomalies before firing up advanced text
processing tools:
scalac -Ylog:all a.scala
At least until/unless we have some way of generating output in between
"user-level visible warnings" and "notice of interest once you're
peeking under the hood." As a rule of thumb, any code which echoes a
thousand lines when compiling HelloWorld should be gently shoved into
debuglog. (Or anything which is sure to print for every classfile,
every method, etc. etc.) Especially, any code which is going to simply
reference Tuple2 and then echo a line for every specialized variation of
that class is being unreasonably taxed.
While I was quietizing, I changed various 'if (settings.debug.value)
log' usages to call debuglog. Hey everyone, you can do this without
penalty now, the inliner turns around and inlines the same code, and
it's so much less unsightly. No review.
|
| |
|
|
|
|
|
| |
Refactored infoTransformer functionality from nsc.transform to
reflect.internal.transform. Needed so that we can find Java methods that
correspond to Scala methods. Review by extempore.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Modified erasure so we have enough information to determine whether we
need to use scala or java erasure semantics. This fixes the runtime
failure illustrated here:
% scala29 -e 'java.util.Collections.max(null)'
java.lang.NoSuchMethodError: java.util.Collections.max(Ljava/util/Collection;)Ljava/lang/Comparable;
Review by odersky.
|
| |
|
|
|
|
|
|
| |
Fixed adriaan's patch for type constructor inference. The problem with
haranguing people in bars about bugs is that the fixes with which they
provide you may be flawed. Fortunately moors has this novelist on
retainer. Review by moors.
|
| |
|
|
|
| |
Small babystep to show Scala -> Java mapping in reflection.
|
| |
|
|
|
|
|
|
|
| |
Workaround for scalacheck calling System.exit during testing. Not sure
exactly what the sequence of events is here: I found the exit problem
months ago and committed code to scalacheck to make that configurable,
and then didn't see it again until recently, but I don't think it was
ever addressed. This is just a bandaid. No review.
|
| |
|
|
|
|
| |
Brought scalacheck up to date with scalacheck trunk (rev 06612e965d) and
rebuilt jar against r25318, no review.
|
| |
|
|
|
| |
Re-de-case-classed scala.xml.Text as described in r20450, no review.
|
| |
|
|
|
| |
Contributed by Simon Ochsenreither.
|
| |
|
|
|
|
| |
Reverting recent type constructor patch until I can see why scalacheck
is getting blinkered by it. No review.
|
| |
|
|
|
| |
Authored by Chris League and Roland Kuhn
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
collection docs: fix copy-paste errors in GenTraversableOnce
In r24752, the documentation of reduce, reduceOption, fold, and
aggregate were copied verbatim from ParIterableLike to the new
GenTraversableOnceLike, and in r24786 they were brought along as
GenTraversableOnce replaced GenTraversableOnceLike. Some bits of what
they said were appropriate for ParIterableLike but are no longer
appropriate here.
Contributed by Greg Price.
|
| | |
|
| | |
|
| |
|
|
|
| |
Contributed by josh marcus.
|
