| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Due to some voodoo magic creating a new instance of a compiler cake,
immediately degrades performance of the compiler.
Out guess is that it makes HotSpot treat calls to cake methods as polymorphic.
However we didn't do any performance testing, it just works, and that's enough.
Enough for now.
|
| |
|
| |
|
|
|
|
|
| |
Makes `maxPrintString` configurable and fixes its treatment at zero.
Quite useful for debugging elaborate classloaders with long classpaths.
|
|
|
|
|
|
| |
Displays identity hashcodes next to `res` values printed by REPL.
This proved quite useful in detecting reflection artifacts that look the same,
but are, in fact, different.
|
|
|
|
|
|
| |
Useful for the upcoming reflection refactoring.
Previously it was more or less okay to type "import scala.reflect.mirror._",
but soon we'll have multiple universes and mirrors.
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Fixes SI-5857. More efficient min and max in Range and NumericRange
|
| |
| |
| |
| |
| |
| |
| |
| | |
Override `min` and `max` in `Range` and `NumericRange`
to check if a default `Ordering` for the numeric type
in question is used.
If so, bypass traversal and compute the minimum or
maximum element.
|
|\ \
| | |
| | | |
GenASM-based fix for SI-4804. Fix of the same for GenJVM pending.
|
| | | |
|
|\ \ \
| | | |
| | | | |
counterpart in GenASM to 241c7606d0bf5f3209b9d549fb75
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Add the first iteration of the `util.hashing` package.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Move `MurmurHash3` to `util.hashing`.
Make the `class` private and retain a public companion
`object`, and put the `MurmurHash3.Hashing` implementations
for various types in the companion.
Add a method which composes `ByteswapHashing` with some other hashing.
Rename `hashOf` to `hash`.
Fix chi-square test in a test-case.
Review by @jsuereth.
Moved a failing test that seems to use some other library version to pending.
|
|/ / /
| | |
| | |
| | |
| | | |
Rather than stub implementations. This saves over 50K of bytecode.
I also added the necessary imports to silence the feature warnings.
|
|\ \ \
| | | |
| | | | |
Fixes typos in scaladoc of Orderes.scala
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix SI-5880.
|
| | |_|/
| |/| |
| | | |
| | | | |
Add a ChiSquare test for the new hash code.
|
|\ \ \ \
| | | | |
| | | | | |
Fix SI-5867.
|
| |/ / /
| | | |
| | | |
| | | | |
Override clone for unrolled buffer.
|
|\ \ \ \
| | | | |
| | | | | |
Fix SI-5879.
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix a bug where a key in an immutable hash map
have the corresponding value different in the iteration
than when doing lookup. This use to happen after calling
`merge`.
Fix the order in which a key-value pair appears in
the collision resolution function - the first argument
always comes from the `this` hash map.
Deprecate `merge` in favour of `merged`, as this is
a pure method.
As an added benefit, the syntax for invoking `merge`
is now nicer.
|
|\ \ \ \
| |/ / /
|/| | | |
Add configuration for ExecutionContext
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Switching to the Akka-provided Unsafe detection
|
| | |
| | |
| | |
| | | |
platforms, like Android
|
|\ \ \
| | | |
| | | | |
Implementing Hashing typeclass
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Move `Hashing` to `scala.util.hashing`.
Adde `Hashing.Default` to `Hashing` companion object.
Change `TrieMap` to autoswitch from `Hashing.Default` to `TrieMap.MangledHashing`.
|
| | | |
| | | |
| | | |
| | | | |
Make Equiv serializable.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Modify TrieMap to use hashing and equality.
Modify serialization in TrieMap appropriately.
|
|\ \ \ \
| | | | |
| | | | | |
SI-5313 Revert to two traversals in substThisAndSym.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Partially reverts 334872e.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
SI-5683 Fail gracefully when transposing a ragged type arg matrix.
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The code used to do this, until `transpose` starting throwing IAE
rather than AIOOBE.
Symptomatic treatment only: The reported crasher now infers ill-kinded
type args and reports an error.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I should not have merged this pull request yet.
I didn't notice we didn't have a full successful run of the test suite.
It looks like it breaks test/files/continuations-neg/lazy.scala and
given the pending amount of changes, I prefer to have a stable master.
This reverts commit 037d3dcbc5896864aec0f9121eeda23fcc4cd610.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Don't compute least upper bounds for if-like exprs in statement position
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
inside blocks.
This may save huge amount of time (Fixes SI-5862) for complicated lubs. I had to remove the a check in adapt for
the part that transforms <expr> into { <expr>; () } when the expected type is Unit. The reason is in the
code.
As a side effect, we get more warnings for pure expressions in statement positions (see the change in the test file).
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Unreachability analysis for pattern matches
Thanks for reviewing, @retronym!
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Analyze matches for unreachable cases.
A case is unreachable if it implies its preceding cases.
Call `C` the formula that is satisfiable if the considered case matches.
Call `P` the formula that is satisfiable if the cases preceding it match.
The case is reachable if there is a model for `-P /\ C`.
Thus, the case is unreachable if there is no model for `-(-P /\ C)`,
or, equivalently, `P \/ -C`, or `C => P`.
Unreachability needs a more precise model for type and value tests than exhaustivity.
Before, `{case _: Int => case 1 =>}` would be modeled as `X = Int \/ X = 1.type`,
and thus, the second case would be reachable if we can satisfy `X != Int /\ X = 1.type`.
Of course, the case isn't reachable, yet the formula is satisfiable, so we must augment
our model to take into account that `X = 1.type => X = Int`.
This is done by `removeVarEq`, which models the following axioms about equality.
It does so to retain the meaning of equality after replacing `V = C` (variable = constant)
by a literal (fresh symbol). For each variable:
1. a sealed type test must result in exactly one of its partitions being chosen
(the core of exhaustivity)
2. when a type test is true, tests of super types must also be true,
and unrelated type tests must be false
For example, `V : X ::= A | B | C`, and `A => B` (since `A extends B`).
Coverage (1) is formulated as: `A \/ B \/ C`, and the implications of (2) are simply
`V=A => V=B /\ V=X`, `V=B => V=X`, `V=C => V=X`.
Exclusion for unrelated types typically results from matches such as `{case SomeConst =>
case OtherConst => }`. Here, `V=SomeConst.type => !V=OtherConst.type`. This is a
conservative approximation. If these constants happen to be the same value dynamically
(but the types don't tell us this), the last case is actually unreachable. Of course we
must err on the safe side.
We simplify the equality axioms as follows (in principle this could be done by the
solver, but it's easy to do before solving). If we've already excluded a pair of
assignments of constants to a certain variable at some point, say `(-A \/ -B)`, then
don't exclude the symmetric one `(-B \/ -A)`. (Nor the positive implications `-B \/ A`,
or `-A \/ B`, which would entail the equality axioms falsifying the whole formula.)
TODO: We should also model dependencies between variables: if `V1` corresponds to
`x: List[_]` and `V2` is `x.hd`, `V2` cannot be assigned at all when `V1 = null` or
`V1 = Nil`. Right now this is implemented hackily by pruning counter-examples in exhaustivity.
Unreachability would also benefit from a more faithful representation.
I had to refactor some of the framework, but most of it is shared with exhaustivity. We
must allow approximating tree makers twice, sharing variables, but using different
approximations for values not statically known. When considering reachability of a case,
we must assume, for example, that its unknown guard succeeds (otherwise it would wrongly
be considered unreachable), whereas unknown guards in the preceding cases must be
considered to fail (otherwise we could never get to those case, and again, it would
falsely be considered unreachable).
Since this analysis is relatively expensive, you may opt-out using `-Xno-patmat-analysis`
(or annotating the selector with @unchecked). We hope to improve the performance in the
near future. -Ystatistics has also been extended to provide some numbers on time spent in
the equality-rewrite, solving and analyzing.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|