summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* SI-8173 add support for patterns like init :+ last to quasiquotesDenys Shabalin2014-02-023-40/+53
| | | | | | | | | | | | Adds support for patterns like: val q"{ ..$init; $last }" = q"{ a; b; c }" // init == List(q"a", q"b") // last == q"c" Which under the hood get compiled as `:+` patterns: SyntacticBlock(init :+ last)
* Merge pull request #3447 from retronym/topic/opt9Adriaan Moors2014-01-312-15/+25
|\ | | | | Optimize the pickler phase
| * Optimize the pickler phaseJason Zaugg2014-01-312-15/+25
| | | | | | | | | | | | | | | | - move "erroneous type" diagnostic into a crash recovery handler, rather than running it proactively - move the "unexpanded macros" check into refchecks. Cuts this phase in half, from about 1% of compile time to 0.5%.
* | Merge pull request #3425 from retronym/ticket/7700Jason Zaugg2014-01-311-9/+19
|\ \ | |/ |/| SI-7700 @unspecialized, Part Deux: Now Working.
| * SI-7700 @unspecialized, Part Deux: Now Working.Jason Zaugg2014-01-311-9/+19
| | | | | | | | | | | | | | | | | | This annotation was introduced to allow us to mark methods within a specialized trait as immune from specialization. In particular, this is desirable for `Function1.{andThen, compose}`. However, it seems we need to check for this in two places in the specialization code base. The feature is now backed with a test.
* | Merge pull request #3357 from retronym/ticket/8143Adriaan Moors2014-01-314-10/+12
|\ \ | | | | | | SI-8143 Regressions with override checks, private members
| * | SI-8143 Regressions with override checks, private membersJason Zaugg2014-01-144-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These regressed in e609f1f20b, which excluded all private methods from overriding checks. We should only exclude private[this] members on the low end of a pair, as was done before that commit, and, we must also exclude private members on the high side. Why? Warning: reverse engineered intuition follows. We need to report an error when if a private method in a subclass has matches a less-private method in the super class and report an error, lest the user be fooled into thinking it might be invoked virtually. On the other hand, adding a private method to a super class shouldn't invalidate the choice names of public members in its superclasses. I've removed the test case added by that commit and will lodge a reworked version of it that Paul provided as a new issue. That shows a bug with qualified private + inheritance. In addition, the expectation of `neg/accesses.check` is reverted to its 2.10.3 version, which I believe is correct. When it was changed in e609f1f20b it sprouted a variation, `neg/accesses-2`, which has now changed behaviour. The intent of that test will be captured in the aforementioned issue covering qualified private inheritance.
* | | Merge pull request #3434 from Ichoran/issue/8213Adriaan Moors2014-01-302-4/+26
|\ \ \ | | | | | | | | SI-8213 AnyRefMap.getOrElseUpdate is faulty
| * | | SI-8213 AnyRefMap.getOrElseUpdate is faultyRex Kerr2014-01-302-4/+26
| | | | | | | | | | | | | | | | | | | | | | | | Altered getOrElseUpdate to be robust to the map changing out from under it as a result of calling the default value method. Side-effects FTW! Made a comparable change in LongMap also, as it was also affected. And added a test to SetMapConsistencyTest.
* | | | Merge pull request #3416 from retronym/topic/any-val-implicitAdriaan Moors2014-01-301-9/+12
|\ \ \ \ | |/ / / |/| | | Prohibit views targeting AnyVal
| * | | Prohibit views targeting AnyValJason Zaugg2014-01-271-9/+12
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Library changes in Scala 2.10 mean that we are left with the unfortunate situation of admitting: scala> "": AnyVal res0: AnyVal = We already have explicit checks in place to prevent views targeting `AnyRef`. This commit balances this out by prohibiting `AnyVal`, as well. The enclosed test shows that this case is now prevented. If multiple implicits views are applicable, the ambiguity error is still raised; these check comes right at the end. Maybe that ought to be changed, but I don't think it matters too much. I've also disabled this prohibition under -Xsource:2.10.
* | | SI-8205 Don't include CR in lineSom Snytt2014-01-291-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | More penance. Extend the unit test and don't include CR in the line text. This is obvious, which shows how dangerous it is to refactor without unit tests. My very favorite bugs are off-by-one and EOL handling, followed closely by off-by-Int.MaxValue.
* | | Merge pull request #3427 from retronym/ticket/8205Jason Zaugg2014-01-291-3/+3
|\ \ \ | | | | | | | | Avoid long, slow march to AIIOBE in SourceFile#lineContent
| * | | SI-8205 Avoid long, slow march to AIIOBE in SourceFile#lineContentJason Zaugg2014-01-291-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixing a regression from SI-8015. The failure mode is kind of amusing: a while loop in `lineToString` would count all the way to `Int.MaxValue`, and integer overflow would foil a bounds check when looking for the 'LF' in 'CR'-'LF'. Given that we're not a style checker to enforce that source files end in a new-line, this commit accounts for EOF, and fixed the overflow problem too. A JUnit test exercises the bug and a few other variations of `lineContent`. While i was in the neighbourhood, I opted for a more efficient means to slice out that line.
* | | | Merge pull request #3426 from retronym/ticket/8199Grzegorz Kossakowski2014-01-291-4/+7
|\ \ \ \ | | | | | | | | | | SI-8199 Account for module class suffix in -Xmax-classfile-name
| * | | | SI-8199 Account for module class suffix in -Xmax-classfile-nameJason Zaugg2014-01-291-4/+7
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The class file name of an inner class is based on the flattened name of its owner chain. But, if this is going to be unreasonably long, it is shortened with the help of a MD5 hash. However, after this shortening takes place, we sneakily add one more character (the infamous '$') to the name when it is used for the module class. It is thus possible to exceed the limit by one. The enclosed test failed on Mac with "filename too long" because of this. I have also tested for trait implementatation classes, but these seem to be suffixed with "$class" before the name compactification runs, so they weren't actually a problem. This change is binary incompatible as separately compiled defintions and usages of named, inner classes need to agree on this setting. Most typically, however, these long names crop up for inner anonymous classes / functions, which are not prone to the binary incompatiblity, assuming that their creation hasn't be inlined to a separately compiled client.
* | | | Merge pull request #3374 from densh/si/6844-8076Jason Zaugg2014-01-297-83/+133
|\ \ \ \ | | | | | | | | | | SI-6844 SI-8076 improve handling of function parameters in quasiquotes
| * | | | SI-8076 improve support for implicit argument listDenys Shabalin2014-01-164-2/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for construction and deconstruction of implicit argument list which was originally suggested by @cvogt. 1. Splicing vale into implicit argument list automatically adds implicit flag to them: val x = q"val x: Int" q"def foo(implicit $x)" // <=> q"def foo(implicit x: Int)" 2. One might extract implicit argument list separately from other argument lists: val q”def foo(...$argss)(implicit ..$impl)" = q"def foo(implicit x: Int) // argss is Nil, impl contains valdef for x But this doesn't require you to always extract it separatly: val q”def foo(...$argss)" = q"def foo(implicit x: Int) // argss contains valdef for x
| * | | | SI-6844 restrict splicing in parameter positionDenys Shabalin2014-01-167-82/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously were a bit too permissive on how splicing in function parameter position worked. This made confusing things like possible: val x = TermName(“x”) q”def foo($x)” Now you can either splice trees in that position (ValDefs) or you have to provide type if you splice a name.
* | | | | Merge pull request #3402 from densh/si/7275Eugene Burmako2014-01-2911-48/+142
|\ \ \ \ \ | |_|/ / / |/| | | | SI-7275 allow flattening of blocks with ..$
| * | | | Addresses feedback from JasonDenys Shabalin2014-01-276-46/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Adds tests for new synthetic unit stripping. 2. Marks implementation-specific parts of Holes as private. 3. Trims description of iterated method a bit. 4. Provides a bit more clear wrapper for q interpolator. 5. Refactors SyntacticBlock, adds documentation. 6. Makes q"{ ..$Nil }" return q"" to be consist with extractor.
| * | | | Reify all blocks as syntactic blocksDenys Shabalin2014-01-241-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous version of the pattern wasn't precise enough due to the fact that synthetic units are now erased by syntactic block and this could cause incorrect reification for cases like: val x = { val y = 1 } Here syntactic block would extract one element but we still need to reify it through syntactic block endpoint. So we can't filter based on the number of elements extracted but rather filter on type of a tree.
| * | | | Address pull request feedbackDenys Shabalin2014-01-232-2/+2
| | | | |
| * | | | SI-7275 allow flattening of blocks with ..$Denys Shabalin2014-01-234-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit extends current splicing rules to allow flattening of trees into other trees. Without such support it is impossible to correctly create vals with patterns and use it in other location as they could expand into multiple-statement blocks: scala> q"val (a, b) = (1, 2)" res0: reflect.runtime.universe.Tree = { <synthetic> <artifact> private[this] val x$1 = scala.Tuple2(1, 2): @scala.unchecked match { case scala.Tuple2((a @ _), (b @ _)) => scala.Tuple2(a, b) }; val a = x$1._1; val b = x$1._2; () } scala> q"..$res0; println(a + b)" res1: reflect.runtime.universe.Tree = { <synthetic> <artifact> private[this] val x$1 = scala.Tuple2(1, 2): @scala.unchecked match { case scala.Tuple2((a @ _), (b @ _)) => scala.Tuple2(a, b) }; val a = x$1._1; val b = x$1._2; println(a.$plus(b)) }
| * | | | Refactor reification of high-cardinality holesDenys Shabalin2014-01-232-16/+52
| | | | | | | | | | | | | | | | | | | | | | | | | New approach makes iterated function much more clear through aggressive code reuse, recursion and large descriptive comment on top of it.
| * | | | Tag synthetic unit with attachmentDenys Shabalin2014-01-235-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it easy to differentiate unit inserted by a compiler vs unit written by the user. Useful for quasiquotes and pretty printing. Additionally SyntacticBlock extractor is changed to treat EmptyTree as zero-element block.
* | | | | Merge pull request #3418 from som-snytt/issue/8182-bJason Zaugg2014-01-292-3/+9
|\ \ \ \ \ | | | | | | | | | | | | SI-8182 Avert crash due to type args in pattern
| * | | | | SI-8182 Avert crash due to type args in patternSom Snytt2014-01-272-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Error out type args on binary op after emitting error. Let the parse limp into the whirring blades.
* | | | | | Merge pull request #3413 from paulp/pr/futureAdriaan Moors2014-01-261-4/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix misuse of underscores.
| * | | | | Fix misuse of underscores.Paul Phillips2014-01-251-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's a language bug, but M[_] <: Foo[_] does not mean what anyone who writes it believes that it means. You have to give the type parameter a name, like M[X] <: Foo[X].
* | | | | | Merge pull request #3414 from xeno-by/topic/reifyEugene Burmako2014-01-261-4/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | corrects an error in reify’s documentation
| * | | | | corrects an error in reify’s documentationEugene Burmako2014-01-261-4/+4
| | | | | |
* | | | | | Merge pull request #3411 from som-snytt/issue/7919-si-nlJason Zaugg2014-01-251-2/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Newline after empty string interp
| * | | | | | SI-7919 Newline after empty string interpSom Snytt2014-01-241-2/+5
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | Consume the newline non-raw for safe handling after single-line interpolation.
* | | | | | Merge pull request #3412 from retronym/ticket/2066-2.10-compatJason Zaugg2014-01-253-2/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | -Xsource:2.10: lenient treatment of variance in <:<, =:=
| * | | | | | SI-2066 -Xsource:2.10: lenient treatment of variance in <:<, =:=Jason Zaugg2014-01-243-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The soundness hole was exploited in Scalaz. They have fixed their codebase correctly for Scalac 7.1.x, but have less freedom to break source compatiblity in 7.0.x. After this commit, they could choose to compile that branch with -Xsource:2.10
* | | | | | | Merge pull request #3410 from densh/si/8171Eugene Burmako2014-01-243-5/+10
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | SI-8171 make tq"" an alias for empty type tree
| * | | | | | SI-8171 make tq"" an alias for empty type treeDenys Shabalin2014-01-241-1/+6
| | | | | | |
| * | | | | | Use more precise return types for objectsDenys Shabalin2014-01-242-4/+4
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | This ensures that q"object O" is of type ModuleDef rather than Tree and similarly q"package object O" is of type PackageDef.
* | | | | | Merge pull request #3388 from rklaehn/issue/7445Adriaan Moors2014-01-242-17/+19
|\ \ \ \ \ \ | |/ / / / / |/| | | | | ListMap.tail is returning wrong result
| * | | | | SI-7445 ListMap.tail is returning wrong resultRuediger Klaehn2014-01-202-17/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverted the commit that introduced the bug, and modified HashMap to no longer assume that tail is O(1). Review by @Ichoran, @soc
* | | | | | Merge pull request #3401 from xeno-by/topic/freshEugene Burmako2014-01-225-18/+58
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | SI-6879 improves Context.freshName
| * | | | | addresses pull request feedbackEugene Burmako2014-01-222-4/+4
| | | | | |
| * | | | | SI-6879 improves Context.freshNameEugene Burmako2014-01-225-18/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of per-compilation unit unique counters, the freshName API now uses a per-Global counter. Fresh names now also contain dollars to exclude clashes with supported user-defined names (the ones without dollar signs). This doesn’t fix the bug, because per-Global counters get created anew every time a new Global is instantiated, and that provides some potential for name clashes even for def macros, but at least it completely excludes clashes in typical situations.
* | | | | | Merge pull request #3399 from xeno-by/topic/evalEugene Burmako2014-01-221-2/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | an optimization for c.eval
| * | | | | | an optimization for c.evalEugene Burmako2014-01-221-2/+7
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | People are very frequently using c.eval in order to obtain underlying values of literals. Spinning up a new compiler for that modest purpose is a gross waste of fossil fuels.
* | | | | | Expose seq field for variable arity definitionsDenys Shabalin2014-01-222-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 2.11 we've changed TupleClass, ProductClass and FunctionClass endpoints to be exposed as (Int => Symbol) functions that never throw exceptions but rather return NoSymbol instead of previous error-prone indexed access on array that could explode. While simplifying one use case (indexed access) it complicated ability to check if symbol at hand is in fact a tuple, product or function: (1 to 22).map(TupleClass).toList.contains(symbol) To cover this extra use case we add a seq method to the variable arity class definitions that exposes a corresponding sequence of class symbols: TupleClass.seq.contains(symbol)
* | | | | | Merge pull request #3382 from soc/topic/std-inJason Zaugg2014-01-213-32/+32
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Improve naming of ReadStdin
| * | | | | Improve naming of ReadStdinSimon Ochsenreither2014-01-183-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need to say everything twice, methods are already prefixed with “read”.
* | | | | | Merge pull request #3392 from xeno-by/topic/untypecheckEugene Burmako2014-01-2111-20/+47
|\ \ \ \ \ \ | | | | | | | | | | | | | | deprecates resetAllAttrs and resetLocalAttrs in favor of the new API
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-08 08:39:03 +0000