| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
These annotations are meant to warn from inheriting a class or
from overriding a member, due to the reasons given in `msg`.
The naming and placement of the methods is in line with
@deprecated and @deprecatedName.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know what good it is to have code review if we are checking
in code like this. We must raise the bar, people. When the
justification for code being in the standard library is borderline
at best - as it is here - then the code must be of exceptional
quality. This code is not of exceptional quality.
Mostly these are not behavioral changes, but:
- I removed finite_? as it is a gratuitous deviation from
every isXXX method in the world. This isn't ruby.
- I removed all the regexps, which only made things complicated
- I removed all the unnecessary casts, which is to say, all of them
- I made more things final, sealed, and private
- The unapply structure was all wrong; returning Option[Duration]
on the string unapply meant you'd have to say
case Duration(Duration(x, y)) => ...
So I fixed apply and unapply to be symmetric.
- And I removed the "parse" method, since it was doing what
apply is supposed to do.
There's a test case to exercise accessing it from java,
which also reveals what I hope are bugs.
Thanks to viktor klang for DurationConversions.
|
|\
| |
| | |
Fixed positions in de-aliased special symbols..
|
| |
| |
| |
| |
| | |
`apply` methods.
Fixed #5064, thanks to @paulp who showed the right direction (and how to test it).
|
|\ \
| | |
| | | |
More worksheet nstrumentation changes
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Made instrumenter more robust by taking into account the positions of the tokens in the source. This allows us to reliably put instrumentation code at the end of the previous token, which tends to put it at end of lines. Furthermore, we now skip left parents. Previously, the instrumenter got confused for a statement like
( x + 1 )
because it thought that the statement started at the `x` and not at the `(`.
Another small change is that we now use decoded names in the worksheet. So ??? will show as ??? not $qmark$qmark$qmark.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
(1) Handle empty worksheets
(2) Handle for expressions
Review by @dragos
|
|\ \ \
| | | |
| | | | |
Fixes typos in the ScalaDoc of StringContext
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Allow nested calls to `askForResponse` in the presentation compiler.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
Fix #6312.
review by @odersky,@lrytz.
|
|\ \ \ \
| | | | |
| | | | | |
Fixes SI-6285 - ParIterableLike no longer says sequential foreach.
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
SI-6274 Fix owners when eta-expanding function with byName param
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When eta-expanding a function that takes a by-name param the local definition
for the corresponding argument is a function-0
val eta$1 = () => { argument-to-by-name }
If there are any definitinos in the `argument-to-by-name`, the symbol
owner needs to be changed to the anonymous function's symbol.
To know the function symbol in eta expand, we need to type-check the
function, and therefore pass the `Typer` instance to `etaExpand`.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix SI-6294.
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Deprecate unmaintained/old classes for removal in 2.11
|
| | | | | | |
|
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
So it can be used in value classes.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Formatting cleanup in def typed.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
As seen on scala-internals.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
further polishing of reflection
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I think `isVal` and `isVar` are the right names, because they
exactly map on Scala syntax.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
As discussed, this is not the best API to expose, because this is an
implementation detail that might change.
However the ship has sailed. We're already imposing
the moduleClass <-> sourceModule quirk to the users of our API:
Evidence: http://stackoverflow.com/questions/12128783.
There are reflection tasks that cannot be pulled without the knowledge
of this implementation detail, so we shouldn't pretend that we can
change it on a whim and not break anything.
Hence I propose to add sourceModule to the public contract
and bear the potential consequences.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Symbol.pos is moved to macros.Universe, because it's empty at runtime.
Also added Symbol.associatedFile, because it has valid usages during runtime.
When reflecting one might want to get to a classfile of the symbol and then
analyze it to e.g. decompile the bytecode or find out the associated src file.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
no longer necessary, since scala.tools.nsc.io.AbstractFile
has been long moved to scala-reflect.jar
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
By giving ToolBox.mirror the correct type and constructing the underlying
mirror from a proper classloader, we improve user experience w.r.t
runtime code generation.
Direct motivator: http://stackoverflow.com/questions/12122939, in which
instances of a toolbox-generated class are accessed with Scala reflection.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Doesn't seem to be inferrable from the API we expose right now
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Doesn't seem to be inferrable from the API we expose right now
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Sure this stuff is also declared in Type.baseClasses, but this is
one of the hot paths in reflection (e.g. like ClassSymbol.typeParams),
so I think it's justified to have it as a dedicated method.
Unfortunately we cannot remove Type.baseClasses, because it includes
ridiculously involved calculation of base classes for compound types.
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
As requested in http://stackoverflow.com/questions/12078366/
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix for SI-6273, repl string interpolation.
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
As usual the hard part is tracing through all the
needless abstraction. Begone, 25 layers of parsing error
issuing methods!
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When an error occurs because some type does not conform
to AnyRef (and an AnyRef-derived type would have sufficed)
try to say something useful about the situation.
This commit also initializes scope members before printing
error messages because the + version seems more useful than
the - version (taken from one of the checkfile diffs.)
- def <init>: <?>
- def methodIntIntInt: <?>
+ def <init>(): X
+ def methodIntIntInt(x: scala.Int,y: scala.Int): scala.Int
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Don't try to implicitly convert an unstable prefix
to a stable one by applying a view. As the matrix spoon kid
says, "that's impossible."
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
I have seen this warning a bunch of times and it has not yet
been close to right.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix for SI-6034, covariant value classes.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
My summary in the ticket was incorrect. The problem was that the
class type parameters were being cloned for the method and being
allowed to keep their variance. I threw in an assertion for anyone
attempting to create a method type with variant type parameters,
because hey, why should we allow such madness.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix SI-4581.
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Specifically, the final flag on the generated static field
is no longer ommitted.
Fix 2 failing test-cases.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SBT build now works with SBT 0.12.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Also fixed partest explosion that happened after partest redesign.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fixes SI-6290 by creating real instnaces of language features.
|
| |/ / / / / / |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | | |
The test exercises the most important case, when implicits are invalidated through shadowing.
(See SI-4270)
|