| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Fixing issue with XMLEventReader.stop failing to stop the parser thread.
Contributed by Jean-Laurent Huynh, reviewed by extempore. Closes #3881.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
An object with a main method can now extend its companion class without
losing the ability to run. Also gave genjvm a wax and polish while in
the neigborhood. Closes #3487.
I had to get a little tricky with this one. No review per se, but if
anyone is frightened by the prospect of the forwarders not being marked
final in this case (because as of now, they aren't) then speak now or
ACC_FINAL hold your peace.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
I don't understand why we had to clear() the undoLog in the first place,
since the undoXXX methods increase and decrease its size symmetrically,
so the log should always be empty once they have all unwound. Was it a
(premature) optimisation or was there some kind of semantic meaning to
it that I didn't see?
review by odersky
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added filterNot to Option so I can stop being driven mad by this
difference.
scala> Some(5) filter (_ > 2)
res0: Option[Int] = Some(5)
scala> Some(5) filterNot (_ < 2)
res1: Iterable[Int] = List(5)
No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
into Modifiers and Symbol, but touches as little as possible beyond
that. It also includes some lengthy commentary (see HasFlags.scala) on
the state of the flags and some of the remaining issues. One more patch
which unfortunately but unavoidably touches almost every file in the
compiler lies ahead.
The floor is still open! But no review.
|
| |
|
|
|
|
|
|
|
| |
This maps @native, @volatile, and @transient in java source to the
relevant annotations in scala, rather than discarding the modifiers
completely. I have no specific motivation for this other than it seems
better to do it than not. Also cleans up some old flailing of mine in
the dept. of mapping java access to scala. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
toString when constructing the exception: it need not be called
until/unless it is printed, which it may never be. 2) Include the name
of the class which triggered it. Don't tell me you haven't wanted that
as many times as I have.
(Sidebar on commit message semantics: I assume nobody interprets "no
review" to mean anything like "unreviewable decision!" It only means I'm
pretty sure the code does what I intended. The floor is always open.)
That said, no review.
|
| |
|
|
|
|
| |
One more partest fix where output was redirected using a global
variable, causing errors with multiple actors. Review by plocinic
|
| | |
|
| |
|
|
|
|
| |
closes #3890: propagate inferred type parameters to info of undetermined
type parameters. review by imaier.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Encapsulating name strings in StdNames and eliminating misc duplication.
No review.
|
| |
|
|
|
|
|
|
| |
contributed by "archontophoenix", following in the grand tradition of
code by people whose actual names I don't know. References #2537, but it
doesn't close until some sensible hashcode is used by default. Review by
community.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An overhaul of the collection-oriented methods in Tuple2/Tuple3 (which
still need to be taken all the way to Tuple5.)
* Zip semantics: zip and zipped now properly terminate when any
collection runs out of elements, even if others are infinite. In
addition, short circuiting methods (exists and forall) will terminate if
the condition is met, even in the presence of infinity.
Example:
scala> val ys = Stream from 1
ys: scala.collection.immutable.Stream[Int] = Stream(1, ?)
scala> (ys, ys).zipped forall ((x, y) => x+y < 100)
res0: Boolean = false
scala> (ys, ys).zipped exists ((x, y) => x+y > 100)
res1: Boolean = true
* There are implicits converting Zipped2/3 to Traversable to expose all
the methods which aren't defined in an arity-specific way in the tuple
classes. I have mixed feelings about putting these in Predef; but if
there is another way to make them visible by default I wasn't able to
find it.
Example putting said implicit to use:
scala> (ys, ys, ys).zipped find { case (x, y, z) => x+y+z > 1000 }
res0: Option[(Int, Int, Int)] = Some((334,334,334))
Already reviewed by moors, so no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Abstracting out the common flags code between Symbol and Modifiers
into HasFlags. This patch includes only the non-invasive changes: the
HasFlags trait is not integrated into those classes. The remainder is
complete but I'm checking this part in case anyone would like to throw
some feedback my way at this point: general comments, or the open issues
noted in comments in HasFlags.scala.
This commit also eliminates the (now unused) MONOMORPHIC flag and
includes utility methods for reflective analysis of a Flags object which
generate code and comments based on the accessors found. See the comment
at the top of symtab.Flags and the flagToString implementation in that
class for illustration.
I haven't tested the very latest, but a slightly older incarnation
without material differences showed no measurable performance change.
No specific review, but comments welcome.
|
| | |
|
| |
|
|
|
|
| |
temporary fix for compiler crash in dependend method types with
annotations. review by moors.
|
| |
|
|
|
|
|
| |
eliminated the import of ambiguously named classes from e.g.
collection.mutable, obeyed a todo in the parser regarding dropping
lbracket from statement starting tokens. No review.
|
| |
|
|
|
|
| |
Better check for objects trying to sneak themselves into the
superconstructor arguments. Closes #3913, no review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Made some adjustments to toString formatting of JSON
Closes #3605
Hopefully this is the last time I have to close this ticket. In addition
to default behavior, the end user can specify their own JSON value
formatting function if they want to customize it.
|
| |
|
|
|
|
|
|
|
| |
Log file is printed now right away if:
- test fails due to an exception thrown in the a test
- test fails due to a ScalaCheck test fail
- test fails due to compiler errors in ScalaCheck tests
Review by extempore.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Fans of scala cinema who have viewed this types video:
http://www.scala-lang.org/sites/default/files/martin_ordersky_scala_inte
rnals_2009-03-04.avi may have noticed that martin entered a variety of
priceless comments in the course of the lecture and never checked them
in. As the self-appointed royal stenographer I have come forward to
right this wrong.
It being a grainy video and almost inaudible, I may well have butchered
it somewhere, so review by odersky.
|
| |
|
|
|
|
|
| |
changes in Global and Typer to accomodate this, and renamed "Checkers"
to "ICodeCheckers" to make some less confusing space for the future
"SymbolCheckers". No review.
|
| |
|
|
|
|
|
|
|
| |
* Fix regression with `display packages only`: after clicking, templates were hidden and immediately shown again.
* Better handling of show/hide packages. Closes #3482.
* Removes authors from the docs.
review by dubochet.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
An obviously wrong yet somehow brilliant piece of code uncommenting.
References #2171 without fixing it. Removes the non-termination which
had caused me to revert r23174, which itself immediately follows this
patch. No review (but iulian says he will look at this situation
somewhere down the line.)
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Solved issues with fork join pool creators, and the issue with
scalacheck output.
Done by Philipp and me.
Review by phaller.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Fixing an issue with hashset splitters where the splitting does not work
if some elements have already been iterated. Added parallel collections
exception handling. Added parallel collections break control. Renaming
ParHashTrie -> ParHashMap.
The part with immutable.{HashSet, HashMap} - review by rompf
|
| |
|
|
|
|
|
|
| |
Improves exhaustiveness analysis to not warn about types which cannot
match due to nonconformant type parameters. Also, look at the different
warnings emitted in the test case based on the presence of a constraint.
Nifty! Closes #3683, no review.
|
| |
|
|
|
| |
An issue with scalacheck and actors where an excess of thread pools gets created - tmp fix. No review.
|
| |
|
|
|
|
| |
Somewhere along the way AnyVal stopped working as sealed. (It was still
sealed but had lost its children.) Closes #3163, review by rytz.
|
| |
|
|
|
|
|
| |
Massively simplified the exhaustiveness checker with no measurable loss
of fidelity. I might be the only one who can be unsurprised by such a
bloody diff: anyone else would rightly say "how on earth..." No review.
|
| | |
|
| |
|
|
|
|
| |
Locator should follow TypeTree#original to get the smallest tree
containing a position. review by odersky
|
| |
|
|
|
|
| |
Reverts r23174, which I believe will bring the build back to life. It
only chokes under -optimise. No review.
|
| |
|
|
|
|
|
| |
Fixed a scalacheck test group "test entire subdirectory" problem. It's
now possible to add scalacheck tests consisting of multiple files. No
review.
|
| |
|
|
|
| |
init currentTyperRun rather than leaving it null.Typo. review by odersky
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pattern matching on Array types, working for reals.
def f[T](a: Array[T]) = a match {
case x: Array[Int] => x(0)
case x: Array[Double] => 2
// etc.
}
I'd also like to thank "instantiateTypeVar" for displacing the
mechanical spiders and giant squid beings which used to fill my
nightmares. Now that I know true horror, I welcome the squid.
Closes #2755, review by odersky.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patches for #3887 and #3888, but I determined that I could achieve the
same effect by deleting a bunch of code, so I did. This left only a few
lines in TransMatch, so I eliminated it, which led me to remember that
many places still reference non-existent phase transmatch, so those were
updated. Notes:
* This swaps equality tests on stable identifier patterns. They
have never conformed to the spec (as noted long ago in ticket #785)
which says "The pattern matches any value v such that r == v" whereas
until now the test being performed was v == r.
* An issue was introduced with specialization in that the implementation
of "isTupleType" in Definitions relied upon sym == TupleClass(elems.length).
This test is untrue for specialized tuples, causing mysterious behavior
because only some tuples are specialized. There is now "isTupleTypeOrSubtype"
although it seems likely the former implementation is unnecessary.
The issue is sidestepped if one uses "getProductArgs" to retrieve the element
types because it sifts through the base types for the Product symbol.
Closes #3887 and #3888, review by dmharrah.
|
