| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
No review.
|
|
|
|
|
|
| |
Found the cure for the hanging repl introduced three comits ago. No
review.
|
| |
|
|
|
|
|
|
|
|
| |
With this change, one can use the reflective compiler with the scala
libs on the boot classpath (the default) or not (with -nobootcp) and it
will work either way. Maybe it will work in sbt now too, but I haven't
tried it. Since I bet you will try it, review by grek.
|
|
|
|
|
| |
Lots of fiddling in the interests of a better classloading future.
|
| |
|
|
|
|
|
|
|
| |
Fixed type unsoundness problem in t5120 and also discovered by
roman.kalukiewicz@gmail.com. Fix should be refined further, as I am not
convinced we are quite done yet. Review by moors.
|
|
|
|
|
|
|
|
| |
Made some minor change in the presentation compiler testing framework to
make it more robust when (unexpected) NoPosition values are returned.
That makes test failure smoother and more information can be hence
gathered from the logged trace. no review.
|
|
|
|
|
| |
Now there's an unlikely fix. No review.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Contributed by Thomas Switzer. Closes SI-4985, no review.
|
|
|
|
|
|
|
|
|
| |
Fixes NPE using iterator with an XML attribute being null or None )
(SI-5052 Also fixes incorrect size method (SI-5115 )
Contributed by Jordi Salvat i Alabart. Closes SI-5052, SI-5115, no
review.
|
|
|
|
|
| |
NullaryMethodType was escaping. Closes SI-5099, review by moors.
|
|
|
|
|
|
| |
Code to locate currently transformed unit in case of crashes. Review by
extempore.
|
| |
|
|
|
|
|
| |
Closes SI-4970, review by moors.
|
|
|
|
|
| |
No review.
|
|
|
|
|
|
| |
Doubling a 0-size array is still 0, that's not growing. Closes SI-4963,
no review.
|
|
|
|
|
|
|
|
| |
It represents a lot of work because the mutation flies fast and furious
and you can't even blink at these things without upsetting them. They're
a little hardier now, or at least we stand a better chance of changing
them. Open season on review.
|
| |
|
| |
|
|
|
|
|
| |
Don't truncate errors or warnings. No review.
|
|
|
|
|
|
| |
Discovered an overloaded method with multiple unimplemented variants
only had one listed. Fixed, no review.
|
|
|
|
|
|
| |
Propagate varargs flag from object methods to static forwarders so java
will recognize them as varargs.
|
| |
|
|
|
|
|
|
|
| |
Fixed problem when running under -Xcheckinit for the code.scala test by
avoiding accessing an unitialized variable. Good catch, -Xcheckinit!
Review by extempore.
|
|
|
|
|
|
| |
"phase.id <= currentRun.typerPhase.id" hurts my brain in all these
convoluted conditionals. No review.
|
|
|
|
|
|
| |
First end-to-end implementation of a runtime reflexive compiler that
generates and loads bytecodes. Review by szeiger.
|
|
|
|
|
| |
Trying to fix getLinkPos problem reported by Mirco. Review by dotta.
|
| |
|
|
|
|
|
| |
Suppresses ProductN parent for case classes. No review.
|
| |
|
| |
|
|
|
|
|
| |
Pushed NPE defense in NoSourceFile.file out another level.
|
| |
|
|
|
|
|
|
| |
Propagate Error in repN. I have no time for a test case, I will gladly
take a contribution. References SI-1100, Closes SI-5108, No review.
|
|
|
|
|
|
| |
Pinpointed line which gave us SI-3882. In case a remedy suggest itself
to you, review by dragos.
|
|
|
|
|
|
| |
Starting to see a glimmer of the other side now. I nudged a few things
into more sensible places. No review.
|
|
|
|
|
|
| |
It's hidden behind -Xlint and pretty specific, but makes me feel better
anyway. References SI-4762, no review.
|
|
|
|
|
| |
One little tiny oversight, those positions are finicky. No review.
|
|
|
|
|
|
|
| |
I was hoping to be further than this by now ("Accursed mutants!" *shakes
fist*) but you can't deny we've come a long way. Review is welcome, but
no review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A digression into motivations:
It's not there yet but the future looks bright. I have winnowed the
number of mutation points down and I will take it down much further.
There are only a few fundamental state changes which take place and
these can be made to happen in a systematic fashion at well-known
junctions.
1) Fresh symbols are allocated and (usually) assigned to a tree. 2)
Symbol flags and access are manipulated. 3) A (possibly lazy) info is
assigned to a symbol. 4) Synthetics are created or lazily positioned
for creation
Among the complications is that the symbol's info often cannot be
determined in a straightforward fashion lest cycles develop. Type
inference is obviously dependent on having some type information, so the
black art is to pursue a) only the right information and b) only as far
as necessary to avoid cycles.
Compounding the difficulty is that synthetic methods must be introduced
before the typer phase. Over time a variety of ad-hoc mechanisms have
evolved to deal with these difficulties, and they have gotten us a good
distance (we have bean setter/getters, case classes, copy methods,
default getters, and more) but there are big disadvantages:
- they are heavily custom fitted to the specific uses
- because of the intertwingling of namer and typer, it is all
only possible from the inside. Compiler plugins are shut out.
A particularly difficult scenario has recently arisen with case classes.
They now receive a ProductN parent, but because a class's parents must
be completed before it can be completed, we encounter this:
object Foo { type T = String }
case class Foo(x: Foo.T, y: Foo.T) { }
Now one of class Foo's parents is Product2[T, T]. So class Foo cannot be
completed without information from object Foo. But object Foo needs to
be given these synthetic methods:
def apply(x: T, y: T): Foo
def unapply(x: Foo): Option[(T, T)]
You can see these two have their hands all over one another.
The good news is that I have established in principle that the problem
can be overcome, for that use and I think in a sufficiently general way
that plugins will be able to perform this kind of method synthesis,
with the following approach. For synthetic methods which require type
information before they can be created (this is the catch-22: once type
information is available, it's too late to add new synthetic methods) we
create a "stub symbol" like so:
val sym = owner.newMethod("nameOfMethod")
sym setInfo stubMethodInfo
stubMethodInfo will be some very general method type like Any* => Any
(or Nothing => Any, it really depends on how or whether it is used),
whatever it takes to pass type checking. At the same time, we enter the
stub symbol into a map along with a thunk which creates the symbol and
tree the way we would if we had full type information.
Then, immediately after a class is typed, the template is examined for
stub method symbols and when found, they are updated with the symbol
info found in the map, assigned to the associated tree, and added to the
class template. This approach will probably break down under some uses,
but I think it can take us a long way.
So all these changes in Namers are about evolving it to a point where I
can roll out a principled division of responsibility for those entities
which cannot be naively typed, and to unify the several different
approaches to lazy typing under a consistent and predictable mechanism.
If anyone would like to review this, please be my guest, but you might
want to wait one more commit.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
iff the matching monad is Option (the default MatchingStrategy),
optimize flatMap/orElse/guard to the equivalent if-then-else (otherwise,
emit flatMap/orElse,... calls)
also, triggering support for <outer> when opt.virtPatmat (was
opt.experimental)
no review
|
|
|
|
|
|
|
|
|
| |
at least one imminent TODO: undo hardwired generation of if/then/else,
and decide based on type whether to call flatMap/orElse or inline those
methods from Option
review by extempore
|
|
|
|
|
|
|
| |
explicitouter support for virtpatmat synthetic <outer> is turned into the actual outer accessor since pattern matching virtualisation is done during typer, not explicitouter like the real pattern matcher, we don't know what the outerAccessor is yet when emitting outer checks -- thus use a synthetic select that is transformed into the real thing during explicitouter
no review
|
|
|
|
|
|
|
|
| |
setting the stage for the virtualizing pattern matcher no actual changes
though
no review
|