summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Changed typo on doc of scala.collection.Seq.Martin Odersky2011-10-241-1/+1
|
* Pushed NPE defense in NoSourceFile.file out ano...Martin Odersky2011-10-241-1/+3
| | | | | Pushed NPE defense in NoSourceFile.file out another level.
* made compileUnits work from given start phase.Martin Odersky2011-10-241-1/+1
|
* Fix for combinator regression.Paul Phillips2011-10-231-0/+1
| | | | | | Propagate Error in repN. I have no time for a test case, I will gladly take a contribution. References SI-1100, Closes SI-5108, No review.
* Debugging note.Paul Phillips2011-10-231-1/+8
| | | | | | Pinpointed line which gave us SI-3882. In case a remedy suggest itself to you, review by dragos.
* Overhaul of Namers continues.Paul Phillips2011-10-228-259/+393
| | | | | | Starting to see a glimmer of the other side now. I nudged a few things into more sensible places. No review.
* Warn about surprising shadowing.Paul Phillips2011-10-222-6/+27
| | | | | | It's hidden behind -Xlint and pretty specific, but makes me feel better anyway. References SI-4762, no review.
* Positions fix.Paul Phillips2011-10-221-1/+1
| | | | | One little tiny oversight, those positions are finicky. No review.
* More overhaul of Namers.Paul Phillips2011-10-215-215/+215
| | | | | | | I was hoping to be further than this by now ("Accursed mutants!" *shakes fist*) but you can't deny we've come a long way. Review is welcome, but no review.
* Overhaul of Namers.Paul Phillips2011-10-214-238/+306
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A digression into motivations: It's not there yet but the future looks bright. I have winnowed the number of mutation points down and I will take it down much further. There are only a few fundamental state changes which take place and these can be made to happen in a systematic fashion at well-known junctions. 1) Fresh symbols are allocated and (usually) assigned to a tree. 2) Symbol flags and access are manipulated. 3) A (possibly lazy) info is assigned to a symbol. 4) Synthetics are created or lazily positioned for creation Among the complications is that the symbol's info often cannot be determined in a straightforward fashion lest cycles develop. Type inference is obviously dependent on having some type information, so the black art is to pursue a) only the right information and b) only as far as necessary to avoid cycles. Compounding the difficulty is that synthetic methods must be introduced before the typer phase. Over time a variety of ad-hoc mechanisms have evolved to deal with these difficulties, and they have gotten us a good distance (we have bean setter/getters, case classes, copy methods, default getters, and more) but there are big disadvantages: - they are heavily custom fitted to the specific uses - because of the intertwingling of namer and typer, it is all only possible from the inside. Compiler plugins are shut out. A particularly difficult scenario has recently arisen with case classes. They now receive a ProductN parent, but because a class's parents must be completed before it can be completed, we encounter this: object Foo { type T = String } case class Foo(x: Foo.T, y: Foo.T) { } Now one of class Foo's parents is Product2[T, T]. So class Foo cannot be completed without information from object Foo. But object Foo needs to be given these synthetic methods: def apply(x: T, y: T): Foo def unapply(x: Foo): Option[(T, T)] You can see these two have their hands all over one another. The good news is that I have established in principle that the problem can be overcome, for that use and I think in a sufficiently general way that plugins will be able to perform this kind of method synthesis, with the following approach. For synthetic methods which require type information before they can be created (this is the catch-22: once type information is available, it's too late to add new synthetic methods) we create a "stub symbol" like so: val sym = owner.newMethod("nameOfMethod") sym setInfo stubMethodInfo stubMethodInfo will be some very general method type like Any* => Any (or Nothing => Any, it really depends on how or whether it is used), whatever it takes to pass type checking. At the same time, we enter the stub symbol into a map along with a thunk which creates the symbol and tree the way we would if we had full type information. Then, immediately after a class is typed, the template is examined for stub method symbols and when found, they are updated with the symbol info found in the map, assigned to the associated tree, and added to the class template. This approach will probably break down under some uses, but I think it can take us a long way. So all these changes in Namers are about evolving it to a point where I can roll out a principled division of responsibility for those entities which cannot be naively typed, and to unify the several different approaches to lazy typing under a consistent and predictable mechanism. If anyone would like to review this, please be my guest, but you might want to wait one more commit.
* Towards runtime code generation. No review.Martin Odersky2011-10-212-7/+22
|
* Isolated name change. No review.Martin Odersky2011-10-211-2/+2
|
* made virtpatmat codegen type-directedAdriaan Moors2011-10-212-53/+68
| | | | | | | | | | | | iff the matching monad is Option (the default MatchingStrategy), optimize flatMap/orElse/guard to the equivalent if-then-else (otherwise, emit flatMap/orElse,... calls) also, triggering support for <outer> when opt.virtPatmat (was opt.experimental) no review
* virtpatmat, hidden behind -YvirtpatmatAdriaan Moors2011-10-207-5/+931
| | | | | | | | | at least one imminent TODO: undo hardwired generation of if/then/else, and decide based on type whether to call flatMap/orElse or inline those methods from Option review by extempore
* explicitouter support for virtpatmat synthetic ...Adriaan Moors2011-10-202-0/+24
| | | | | | | explicitouter support for virtpatmat synthetic <outer> is turned into the actual outer accessor since pattern matching virtualisation is done during typer, not explicitouter like the real pattern matcher, we don't know what the outerAccessor is yet when emitting outer checks -- thus use a synthetic select that is transformed into the real thing during explicitouter no review
* setting the stage for the virtualizing pattern ...Adriaan Moors2011-10-202-29/+34
| | | | | | | | setting the stage for the virtualizing pattern matcher no actual changes though no review
* misc fixes while working on virtualizing patter...Adriaan Moors2011-10-2010-23/+29
| | | | | | | | misc fixes while working on virtualizing pattern matching not directly related to pattern matching, though review by extempore
* infer singleton when asking for itAdriaan Moors2011-10-204-31/+53
| | | | | | | | | | | | | a type var's constraint now also tracks whether the type var was compared to a stable type if it was, we probably shouldn't widen the type argument that's inferred for this var, as the result will surely fail to type check NOTE: must be enabled using -Xexperimental review by extempore
* more flexible inference wrt type skolemsAdriaan Moors2011-10-203-18/+52
| | | | | | | | | | | | | instead of barring types that have been skolemized after the TypeVar they're being compared against, (isRelatable) simply remember when a type var is compared to a type skolem from a later skolemization level finally, repack the solution for the type var into a fresh existential if the compared level exceeded ours NOTE: must be enabled using -Xexperimental review by extempore
* 5033: align bound syms when comparing method typesAdriaan Moors2011-10-201-6/+4
| | | | | | | | | | | | can't believe I missed that one... closes SI-5033 more complete test case to make sure the multi-arglist case works as well no review
* dependent methods types are now always enabledAdriaan Moors2011-10-208-30/+16
| | | | | | | | | | for now, left the old if(settings.YdepMethTpes.value) guards in comments removed *.flags containing -Ydependent-method-types also updated one check file with one fewer error no review
* no need to add an x field to everythingAdriaan Moors2011-10-201-7/+13
| | | | | | | | | | | however, it must be possible to inline Ensuring, ArrowAssoc methods renamed the public val x to something a little less intrusive fixed check file to reflect better error message (see! it wasn't that uncommon for people to write `foo.x` -- NEWS AT ELEVEN) no review
* eternalized Paul's findings wrt thisSymAdriaan Moors2011-10-201-2/+20
|
* cleaned up addEvidenceParams a bitAdriaan Moors2011-10-201-12/+8
| | | | | | | | implemented my own feedback from https://codereview.scala-lang.org/fisheye/cru/SR-1022#CFR-23393 no review
* More decomposition of Namers.Paul Phillips2011-10-203-90/+88
| | | | | | | | Having I think established this isn't merely a dance around the maypole, I'm going to continue breaking down Namers because it's hard to figure out where my stubbing mechanism is colliding with the existing logic. Getting there, no review.
* AbstractPartialFunction.Paul Phillips2011-10-1912-13/+25
| | | | | | | | | | | | | | | | | | | | | | | Contributed by Todd Vierling with minor mods by extempore. This is an obvious extension of AbstractFunctionN which I had some issue making work at the time. Sounds kind of pitiful given that the compiler patch is about two lines, but let's all agree to believe it was a different world then. This example program is impacted as follows: class A { def f: PartialFunction[Any, Int] = { case x: String => 1 } def g: PartialFunction[Any, Int] = f orElse { case x: List[_] => 2 } def h: PartialFunction[Any, Int] = g orElse { case x: Set[_] => 3 } } Before: 34943 bytes of bytecode After: 4217 bytes of bytecode A mere 88% reduction in size. "'Tis but a trifle!" Closes SI-5096, SI-5097.
* Overhaul of mixin.Paul Phillips2011-10-1910-410/+410
| | | | | | | | If extempore is going to fix the hard bugs then first he is going to make them less hard to fix. The major work of interest in here is the decomplification of the bitmap logic. Hopefully this will come in handy for anyone wishing to try out other encodings.
* Cycle defense.Paul Phillips2011-10-191-1/+7
| | | | | | Notice when a typeref's info creates an obvious cycle, so we can see an error instead of a stack overflow. Closes SI-5093, review by moors.
* Tweaks to Any and AnyRef documentation, courtes...Heather Miller2011-10-182-2/+5
| | | | | | Tweaks to Any and AnyRef documentation, courtesy of Seth Tisue. No review.
* Documentation to Namers.Paul Phillips2011-10-181-0/+10
| | | | | Added some reverse engineered documentation to Namers, no review.
* Fixing valueOfTerm in the repl.Paul Phillips2011-10-182-7/+9
| | | | | | | Impressed at the amount of ticket traffic for an unadvertised internal method. All the more reason to work toward that support repl API. Don't worry, it'll come. Closes SI-4899, no review.
* Shutdown hook modification.Paul Phillips2011-10-182-8/+20
| | | | | | | | Don't mark shutdown hooks as daemon threads, although it does not seem to make any difference. Instead have the code which waits for all threads to be complete be smarted about which codes to monitor. No review.
* Fix for comparison warnings.Paul Phillips2011-10-182-5/+7
| | | | | | | | | | | | true == new java.lang.Boolean(true) will in fact sometimes be true. Also fixes a bug caused by this change in r23627. - lazy val SerializableClass = getClass(sn.Serializable) + lazy val SerializableClass = getClass("scala.Serializable") It used to be java.io.Serializable. Hey, let's not change the meaning of existing symbols which are in active use. No review.
* Overhaul of Namers.Paul Phillips2011-10-178-575/+627
| | | | | | | | | | | | | I can't go bear hunting without a clean gun. Basically I iterated over Namers until I could understand it. I added a variety of documentation there and elsewhere. There shouldn't be anything particularly behavioral changing in this commit, but I did delete some years-old code (having huge commented out blocks of way-out-of-date code is not a boon to understanding) and the debugging output will look different. Better, one can hope. How about, review by moors.
* Reverting r25787 (caused test.scaladoc failures...Antonio Cunei2011-10-177-283/+181
| | | | | Reverting r25787 (caused test.scaladoc failures on certain systems)
* Cleaning up debug logging.Paul Phillips2011-10-176-11/+22
| | | | | No review.
* Do not depend on java.rmi.* when not necessary.Grzegorz Kossakowski2011-10-171-2/+2
| | | | | | | | | This is small correction of fix committed in r25814. We need to swap terms in logical conjuction so java.rmi.* stuff is accessed only if triggered by @remote annotation. No review.
* Big improvements to scala.Either.Heather Miller2011-10-161-14/+287
|
* Addendum to previous patch.Paul Phillips2011-10-161-10/+9
| | | | | | | | In one of those unlikely accidents, I managed to lose the call to evalOnce while still fixing the reported bug in a different way (function composition led to the target only being called once anyway.) No review.
* Fix for multiple evaluation in structural calls.Paul Phillips2011-10-161-100/+115
| | | | | | | | | | | An interesting bug during cleanup: runtime checks on the target of a structural invocation duplicated the selection without regard for the fact that it might be an expression. So if the name of the method being invoked allowed the possibility that the target was a primitive type (such as "toInt") the expression would be evaluated three times. Closes SI-5080, no review.
* revise and expand root-level ScaladocPaul Phillips2011-10-151-15/+24
| | | | | | added section headers, tightened the wording, shortened the list of selected important packages, and explained automatic imports more
* Donated some parens to Any.Paul Phillips2011-10-151-4/+4
| | | | | And a touch of documentation correctness. Closes SI-5077, no review.
* Harden the typer against surprise unapply types.Paul Phillips2011-10-151-1/+4
| | | | | Closes SI-5078, no review.
* Changed a power mode import.Paul Phillips2011-10-151-1/+1
| | | | | Applying a bandaid since I'll never get the globals lined up. No review.
* Fix regression in companion check.Paul Phillips2011-10-154-5/+18
| | | | | | | | | Pulling back from expensive path normalization caused a regression where companions were no longer recognized as such after specialization. (Specifically, the paths turned up as "test.scala" and "./test.scala".) I made it a two-level check, doing the expensive one before failing. Closes SI-5023, no review.
* Another swing at r25823.Paul Phillips2011-10-141-1/+12
| | | | | | I verified this creates identical library bytecode so I anticipate no regressions. Review by prokopec anyway.
* Better error when abstract methods are missing.Paul Phillips2011-10-145-41/+85
| | | | | | | | When many methods are missing, print a list of signatures the way they need to be implemented, and throw in ??? stub implementations so it should be compilable code. If anyone would like this logic exposed more generally (for the IDE or whatever) just let me know. No review.
* Reverted r25823 as it breaks specialization of ...Grzegorz Kossakowski2011-10-131-6/+1
| | | | | Reverted r25823 as it breaks specialization of traits.
* Renamed isPureExpr to isExprSafeToInline.Paul Phillips2011-10-137-27/+32
| | | | | | Taking adriaan's advice for what name would better describe this method. Yours in reduction of ambiguous terminology, no review.
* Adjustment to @switch.Paul Phillips2011-10-131-1/+3
| | | | | | Don't require a tableswitch if the matcher elected not to emit one because there were so few cases. No review.
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-12 18:00:34 +0000