summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fix some one more issue in DurationRoland2012-09-071-54/+79
| | | | | | | - Inf / Zero == Inf - add some more missing test cases - clarify magic constant - move exception descriptions into proper @throws docs
* second round of Duration cleanupRoland2012-09-071-97/+425
| | | | | | | | - make Duration behave consistent with Double's non-finite semantics - add ScalaDoc - add complete test suite - change overflow protection impl after review comments - clean up code
* several fixes to scala.concurrent.util.DurationRoland2012-09-051-9/+58
| | | | | | | | | | | - add test cases (migrated from Akka sources) - add overflow checking (will throw IllegalArgumentException instead of giving wrong results) - make string parsing more precise when giving >100days in nanoseconds - make method signatures more precise in retaining FiniteDuration throughout calculations - fix mul/div of infinities by negative number - add Ordering for Deadline (was accidentally left out earlier)
* Removing duplication from Duration.Paul Phillips2012-09-041-328/+178
| | | | | | | | | | | | | | | | | | | | | | | | | | | I don't know what good it is to have code review if we are checking in code like this. We must raise the bar, people. When the justification for code being in the standard library is borderline at best - as it is here - then the code must be of exceptional quality. This code is not of exceptional quality. Mostly these are not behavioral changes, but: - I removed finite_? as it is a gratuitous deviation from every isXXX method in the world. This isn't ruby. - I removed all the regexps, which only made things complicated - I removed all the unnecessary casts, which is to say, all of them - I made more things final, sealed, and private - The unapply structure was all wrong; returning Option[Duration] on the string unapply meant you'd have to say case Duration(Duration(x, y)) => ... So I fixed apply and unapply to be symmetric. - And I removed the "parse" method, since it was doing what apply is supposed to do. There's a test case to exercise accessing it from java, which also reveals what I hope are bugs. Thanks to viktor klang for DurationConversions.
* Merge pull request #1251 from dragos/issue/fix-5064Paul Phillips2012-09-041-2/+2
|\ | | | | Fixed positions in de-aliased special symbols..
| * Fixed positions in de-aliased special symbols and for automatically added ↵Iulian Dragos2012-09-041-2/+2
| | | | | | | | | | `apply` methods. Fixed #5064, thanks to @paulp who showed the right direction (and how to test it).
* | Merge pull request #1219 from odersky/topic/worksheet-instrumenterJosh Suereth2012-09-046-211/+51
|\ \ | | | | | | More worksheet nstrumentation changes
| * | Removed previosuly uncommented code, added more diagnosis output to REPL.Martin Odersky2012-08-301-45/+1
| | |
| * | Made instrumenter more robust by looking at tokensMartin Odersky2012-08-302-18/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Made instrumenter more robust by taking into account the positions of the tokens in the source. This allows us to reliably put instrumentation code at the end of the previous token, which tends to put it at end of lines. Furthermore, we now skip left parents. Previously, the instrumenter got confused for a statement like ( x + 1 ) because it thought that the statement started at the `x` and not at the `(`. Another small change is that we now use decoded names in the worksheet. So ??? will show as ??? not $qmark$qmark$qmark.
| * | Removed dead code.Martin Odersky2012-08-303-149/+0
| | |
| * | Two fixes for the worksheet instrumenterMartin Odersky2012-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | (1) Handle empty worksheets (2) Handle for expressions Review by @dragos
* | | Merge pull request #1244 from dgruntz/2.10.xJosh Suereth2012-09-041-4/+4
|\ \ \ | | | | | | | | Fixes typos in the ScalaDoc of StringContext
| * | | Fixes typos in the ScalaDoc of StringContextDominik Gruntz2012-09-041-4/+4
| | | |
* | | | Merge pull request #1245 from dragos/issue/fix-6312Josh Suereth2012-09-041-5/+11
|\ \ \ \ | | | | | | | | | | Allow nested calls to `askForResponse` in the presentation compiler.
| * | | | Allow nested calls to `askForResponse` in the presentation compiler.Iulian Dragos2012-09-041-5/+11
| | |_|/ | |/| | | | | | | | | | | | | | Fix #6312. review by @odersky,@lrytz.
* | | | Merge pull request #1248 from jsuereth/fix/SI-6285Josh Suereth2012-09-041-1/+1
|\ \ \ \ | | | | | | | | | | Fixes SI-6285 - ParIterableLike no longer says sequential foreach.
| * | | | Fixes SI-6285 - ParIterableLike no longer says sequential foreach.Josh Suereth2012-09-041-1/+1
| | | | |
* | | | | Merge pull request #1246 from lrytz/t6274Paul Phillips2012-09-042-3/+7
|\ \ \ \ \ | |/ / / / |/| | | | SI-6274 Fix owners when eta-expanding function with byName param
| * | | | SI-6274 Fix owners when eta-expanding function with byName paramLukas Rytz2012-09-042-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When eta-expanding a function that takes a by-name param the local definition for the corresponding argument is a function-0 val eta$1 = () => { argument-to-by-name } If there are any definitinos in the `argument-to-by-name`, the symbol owner needs to be changed to the anonymous function's symbol. To know the function symbol in eta expand, we need to type-check the function, and therefore pass the `Typer` instance to `etaExpand`.
* | | | | Merge pull request #1217 from axel22/issue/6294Paul Phillips2012-09-041-2/+5
|\ \ \ \ \ | | | | | | | | | | | | Fix SI-6294.
| * | | | | Fix SI-6294.Aleksandar Prokopec2012-08-301-2/+5
| | | | | |
* | | | | | Merge pull request #1192 from jsuereth/deprecate/low-hangingPaul Phillips2012-09-047-0/+7
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Deprecate unmaintained/old classes for removal in 2.11
| * | | | | Deprecate unmaintained/old classes for removal in 2.11Josh Suereth2012-08-247-0/+7
| | | | | |
* | | | | | Made Dynamic extend Any.Paul Phillips2012-09-031-5/+5
| |_|/ / / |/| | | | | | | | | | | | | | So it can be used in value classes.
* | | | | Merge pull request #1235 from paulp/topic/beautify-typedPaul Phillips2012-09-021-140/+51
|\ \ \ \ \ | | | | | | | | | | | | Formatting cleanup in def typed.
| * | | | | Formatting cleanup in def typed.Paul Phillips2012-09-011-140/+51
| | | | | | | | | | | | | | | | | | | | | | | | As seen on scala-internals.
* | | | | | Merge pull request #1202 from scalamacros/topic/reflectionPaul Phillips2012-09-0213-48/+63
|\ \ \ \ \ \ | | | | | | | | | | | | | | further polishing of reflection
| * | | | | | definitive way to learn if a symbol is a val/varEugene Burmako2012-08-272-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think `isVal` and `isVar` are the right names, because they exactly map on Scala syntax.
| * | | | | | Exposes Symbol.sourceModuleEugene Burmako2012-08-272-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed, this is not the best API to expose, because this is an implementation detail that might change. However the ship has sailed. We're already imposing the moduleClass <-> sourceModule quirk to the users of our API: Evidence: http://stackoverflow.com/questions/12128783. There are reflection tasks that cannot be pulled without the knowledge of this implementation detail, so we shouldn't pretend that we can change it on a whim and not break anything. Hence I propose to add sourceModule to the public contract and bear the potential consequences.
| * | | | | | rehash of source file information for SymbolEugene Burmako2012-08-272-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Symbol.pos is moved to macros.Universe, because it's empty at runtime. Also added Symbol.associatedFile, because it has valid usages during runtime. When reflecting one might want to get to a classfile of the symbol and then analyze it to e.g. decompile the bytecode or find out the associated src file.
| * | | | | | removes AbstractFileApiEugene Burmako2012-08-279-39/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no longer necessary, since scala.tools.nsc.io.AbstractFile has been long moved to scala-reflect.jar
| * | | | | | Exposes ToolBox.classLoaderEugene Burmako2012-08-272-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By giving ToolBox.mirror the correct type and constructing the underlying mirror from a proper classloader, we improve user experience w.r.t runtime code generation. Direct motivator: http://stackoverflow.com/questions/12122939, in which instances of a toolbox-generated class are accessed with Scala reflection.
| * | | | | | exposes MethodSymbol.isPrimaryConstructorEugene Burmako2012-08-271-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Doesn't seem to be inferrable from the API we expose right now
| * | | | | | Exposes Symbol.deSkolemize to macrosEugene Burmako2012-08-271-0/+2
| | | | | | |
| * | | | | | adds Symbol.isJavaEugene Burmako2012-08-272-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Doesn't seem to be inferrable from the API we expose right now
| * | | | | | adds ClassSymbol.baseClassesEugene Burmako2012-08-272-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sure this stuff is also declared in Type.baseClasses, but this is one of the hot paths in reflection (e.g. like ClassSymbol.typeParams), so I think it's justified to have it as a dedicated method. Unfortunately we cannot remove Type.baseClasses, because it includes ridiculously involved calculation of base classes for compound types.
| * | | | | | exposes Symbol.childrenEugene Burmako2012-08-272-0/+6
| | |_|/ / / | |/| | | | | | | | | | | | | | | | As requested in http://stackoverflow.com/questions/12078366/
* | | | | | Merge pull request #1231 from paulp/issue/6273Josh Suereth2012-09-022-3/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix for SI-6273, repl string interpolation.
| * | | | | | Fix for SI-6273, repl string interpolation.Paul Phillips2012-09-012-3/+7
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | As usual the hard part is tracing through all the needless abstraction. Begone, 25 layers of parsing error issuing methods!
* | | | | | Better errors for Any/AnyRef issues.Paul Phillips2012-09-014-50/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an error occurs because some type does not conform to AnyRef (and an AnyRef-derived type would have sufficed) try to say something useful about the situation. This commit also initializes scope members before printing error messages because the + version seems more useful than the - version (taken from one of the checkfile diffs.) - def <init>: <?> - def methodIntIntInt: <?> + def <init>(): X + def methodIntIntInt(x: scala.Int,y: scala.Int): scala.Int
* | | | | | Fix for SI-6263, futile adaptation.Paul Phillips2012-09-011-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't try to implicitly convert an unstable prefix to a stable one by applying a view. As the matrix spoon kid says, "that's impossible."
* | | | | | Suppressed 'possible cause' mis-warning.Paul Phillips2012-09-011-1/+10
|/ / / / / | | | | | | | | | | | | | | | | | | | | I have seen this warning a bunch of times and it has not yet been close to right.
* | | | | Merge pull request #1227 from paulp/issue/6034Paul Phillips2012-09-013-3/+10
|\ \ \ \ \ | | | | | | | | | | | | Fix for SI-6034, covariant value classes.
| * | | | | Fix for SI-6034, covariant value classes.Paul Phillips2012-08-313-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My summary in the ticket was incorrect. The problem was that the class type parameters were being cloned for the method and being allowed to keep their variance. I threw in an assertion for anyone attempting to create a method type with variant type parameters, because hey, why should we allow such madness.
* | | | | | Merge pull request #1201 from axel22/issue/4581Josh Suereth2012-09-011-2/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix SI-4581.
| * | | | | | Fix SI-4581.Aleksandar Prokopec2012-08-271-2/+8
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Specifically, the final flag on the generated static field is no longer ommitted. Fix 2 failing test-cases.
* | | | | | Merge pull request #1222 from jsuereth/fix/sbt-buildJosh Suereth2012-09-011-3/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | SBT build now works with SBT 0.12.
| * | | | | | SBT build now works with SBT 0.12.Josh Suereth2012-08-311-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also fixed partest explosion that happened after partest redesign.
* | | | | | | Merge pull request #1225 from jsuereth/fix/si-6290Josh Suereth2012-09-012-7/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fixes SI-6290 by creating real instnaces of language features.
| * | | | | | | Fixes SI-6290 by creating real instnaces of language features.Josh Suereth2012-08-312-7/+14
| |/ / / / / /