| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
| |
When was the last time -Xcheckinit was run? It must have been a long
time. All these changes are to address bugs revealed by -Xcheckinit,
mostly in test cases, some in the compiler. I'm guessing the partest
-Xcheckinit runs are hanging the first time they run into a failure, so
if it starts "working" again after this commit don't get too confident.
No review.
|
| |
|
|
|
| |
No review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deprecated the @serializable annotation, introduce a new trait
"scala.Serializable" which has to be extended instead (cross-platform).
Known issues:
- Companion objects of serializable classes (including case classes) are automatically made serializable. However, they don't extend "Serializable" statically because of the known difficulty (should be done before typing, but hard).
- Writing "case class C() extends Serializable" gives "error: trait Serializable is inherited twice"
- Functions are serializable, but don't extend Serializable dynamically (could be fixed by making FunctionN Serializable - shouldn't we?)
Note that @SerialVersionUID continues to be an annotation; it generates
a static field, which is not possible otherwise in scala.
Review by dragos, extempore.
Question to dragos: in JavaPlatform.isMaybeBoxed, why is there a test
for "JavaSerializableClass"? Is that correct?
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"I invite everyone to change this rule, and observe what breaks!"
This much beloved comment from #1208 has been on my radar for two years.
The worm has turned. Closes #1208. The inferred type of an object is now
Foo.type instead of "object Foo". What once was this:
scala> val x: Map[Int, Singleton] = Map(1 -> None)
<console>:5: error: type mismatch;
found : (Int, object None)
required: (Int, Singleton)
Now exudes a pleasing aura of workingness:
scala> val x: Map[Int, Singleton] = Map(1 -> None)
x: Map[Int,Singleton] = Map(1 -> None)
No review.
|
| |
|
|
|
| |
Review by Rytz.
|
| |
|
|
|
|
|
| |
Added varargs annotation.
Review by Rytz.
|
| |
|
|
|
|
| |
Moved failing test to pending until I figure out how hudson is running
on chara
|
| |
|
|
|
| |
Use partest's java and javac command in the javasigs test. no review.
|
| |
|
|
|
|
|
|
| |
Fix InnerClasses attribute: anonymous classes don't have an outer
name. EnclosingMethod is correctly generated. Fixed isAnonymousClass
definition. Updated test that depends on anonymous inner class names.
Closes (again) #3249, references #2749. review by odersky,extempore.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Added separate bitmaps for private and transient lazy vals. Closes
#3038, #1573. Review by dragos. I had to fix a couple of initialization
issues that checkinit forced me to do and that weren't a problem before
because the bitmap was serialized even for @transitive. For that I
needed to change the setters in checkinit so that they also update the
bitmap.
|
| | |
|
| |
|
|
|
| |
No review.
|
| |
|
|
|
| |
As hash codes change, so do the tests - output order for a HashMap is different now. No review.
|
| |
|
|
|
|
|
| |
eliminated the import of ambiguously named classes from e.g.
collection.mutable, obeyed a todo in the parser regarding dropping
lbracket from statement starting tokens. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sorting through the tests in pending from oldest to newest because I
don't believe in having useless appendages. The verdict on the oldest
fifteen tests is: 15/15 are fixed. Many were already in files under a
different name. I moved a few and deleted the rest. Fun fact of the
day: apparently there was a time when to call into java varargs with no
arguments you might have to write something like:
getClass().getMethod("getCount", Array[java.lang.Class[T] forSome { type T }]())
On this basis I retract any complaints I've ever had about anything.
There is one question mark outlined in pos/testCoercionThis.scala, a
file formerly called pos/moors.scala and therefore... review by moors.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
including "CheckEither", written against scalacheck 1.2 in the year 471
AD. Removed all the duplicates I could find, mostly between pending
and files. Renamed a bunch of tests so they wouldn't look like likely
duplicates next time around. Nominated somebody else to do this once in
a while.
No review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tweaks to ListSet to make it less pathological in its outlook. We
can see some modest improvements in run time and answer quality via the
enclosed test case:
// with this patch: 2.250s elapsed, assertions pass.
// without this patch: 51.441s elapsed, and it's
a mercy killing: java.lang.StackOverflowError at
scala.collection.immutable.ListSet$Node.contains(ListSet.scala:117) at
scala.collection.immutable.ListSet$Node.contains(ListSet.scala:117)
Closes #3822, review by community.
|
| | |
|
| |
|
|
|
|
|
| |
Tracked down why the jvm/natives.scala fails for me and apparently not
anyone else. Rebuilt libnatives.jnlib to accomodate x86-64, and it seems
to pass. No review.
|
| |
|
|
|
|
|
|
|
| |
Restored Source factories to a form source compatible with 2.7.7. No
default implicit arguments, now low priority saves the day with a low
priority codec which io.Codec offers as last resort. Dropped the line
separator argument to getLines and made it act in a separator agnostic
way (any of \r\n, \r, or \n is a separator.) Review by community.
|
| |
|
|
|
| |
according to my tests, they all currently work.
|
| |
|
|
|
| |
Addresses see #3470 by adding a method Reactor.restart. Review by rompf.
|
| |
|
|
|
|
|
|
| |
Removed some flotsam which should have been removed when I rolled back
partest. (We ended up with two copies of the methvsfield test, one in a
subdir and one not.) I would suppose it is responsible for #3464 but I
don't know for certain. No review.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
changes necessary to plug it back in while preserving everything which
has happened since then in tests and such, but we should be the lookout
for overreversion. Review by phaller (but as a formality, I don't think
it requires direct review.)
|
| |
|
|
|
|
| |
revert the revert of r21791 (fix constructor parameter annotations).
close #3390. together with a new starr it builds. no review.
|
| |
|
|
|
|
|
| |
revert commit that probably broke the build due to a bug in closure
elimination revert commit that reverted the commit that probably didn't
break the build
|
| |
|
|
|
| |
fix and test where constructor parameter annotations end up. no review
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Reverted change of Reactor.exceptionHandler's type of see r21650. Review
by plocinic.
|
| |
|
|
|
|
|
| |
Reactor.exceptionHandler is defined on Throwable instead of Exception.
Fixes potential problem with visibility of changes to a field. Review by
plocinic.
|
| |
|
|
|
|
|
| |
symbol does not cause any crashes, but the method using an unknown
symbol will not be used for inlining. Resurrected tests, removed
spec-matrix for the moment. No review.
|
| | |
|
| |
|
|
|
|
| |
closes #3241 and improves serialization of hash tries. review by
community.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling what I think are the last two failing tests, one each of the
two leading bugs among those we've seen here today on testing theater:
"could not find toMap: (x$1: scala.collection.TraversableOnce,x$2:
Predef$<:<)"
and
"scala.tools.nsc.symtab.Types$TypeError: method react cannot be
accessed in java.lang.Object with scala.actors.Reactor[Any]
No review but hey lets' see if we can re-enable these tests soonish.
|
| |
|
|
|
|
| |
Disabled test that hangs when actors package is compiled with
specialization. Review by dragos.
|
| | |
|
| |
|
|
|
|
|
|
| |
Fix for the partest task to fail the build when a test fails, and fixes
for 2/3 of the quietly failing tests. I'm not quite sure what to do
about the view ones, it doesn't look like a simple rename is going to
cut it, so: review by odersky.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If I work on this patch any longer without checking in I will go
stark raving mad. It is broken up into a couple pieces. This one is
the changes to test/. It includes fixing a bunch of tests, removing
deprecated constructs, moving jars used by tests to the most specific
plausible location rather than having all jars on the classpath of all
tests, and some filesystem layout change (continuations get their whole
own srcpath.) This would be the world's most tedious review, so let's
say no review.
[Note: after this commit, I doubt things will build very smoothly until
the rest of the partest changes follow. Which should only be seconds,
but just in case.]
|
