| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
|
|
|
|
|
|
| |
omit check that wouldn't work with separate compilation, not needed
anymore because compiler has become more robust
the actual fix was committed as part of r22512, see #3374
also see #3512
no review
|
| |
|
|
|
|
| |
Fixed type soundness problem someone raised on hackers news. Test in
override.scala. Review by moors.
|
| |
|
|
|
|
|
|
| |
gives fewer insensible warnings about actually sensible things, etc.
Large test case with 30 warnings elicited.
Closes #282 (again), no review.
|
| |
|
|
|
|
| |
Modified r22702 to avoid tarring overloads with the same brush. No
review.
|
| |
|
|
|
|
|
|
|
|
| |
Disallowed super.XX calls to Any methods which are presently either
crashing the compiler (isInstanceOf) or leading to runtime failure (==
and !=) in addition to one which was being rewritten to a this call but
makes more sense disallowed like the others (##).
Closes #3736, review by odersky.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
added @deprecatedName annotation, allowing to deprecate parameter names.
review by prokopec.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
no review
Author: Mark Harrah <dmharrah@gmail.com>
Date: Thu Jul 8 10:30:57 2010 -0400
Source: http://github.com/harrah/scala-starrless/commit/0c7759c95b47cebc6d9fa77cefd34ef638e2706e
Reviewer: moors
|
| |
|
|
|
| |
review by extempore
|
| |
|
|
|
|
| |
closes #3507: don't generate manifests where we can't refer to the
existentially bound value
|
| |
|
|
|
|
|
| |
this broke the invariant that argss is a regular matrix
review by odersky
|
| |
|
|
|
| |
review by odersky
|
| |
|
|
|
|
| |
closes #3247: syntax error regarding context bounds generalized to
include view bounds as we cannot easily be more specific no review
|
| |
|
|
|
|
|
|
|
|
| |
this patch introduces a new subclass of TypeTree: TypeTreeWithDeferredRefCheck, which tracks the type args and type params of a type application when it was beta-reduced during typing without checking that the application was well-kinded -- that check must wait until refchecks, but was never performed since the application had been beta-reduced away
caveat discovered while working on the fix: adapt turned all trees for
which _.isType holds into TypeTree's
review by odersky
|
| |
|
|
|
|
|
|
| |
When compilation fails because of an unimplemented abstract var, give
a more precise error message about what happened. Also avoid issuing
the same error twice because neither getter nor setter is implemented.
Closes #36, review by rytz.
|
| |
|
|
|
|
|
| |
Some more improvement on the error messages when @tailrec fails. Now it
gives a sensible message if the recursive target is actually a supertype
of this, rather than saying the call is not in tail position. No review.
|
| |
|
|
|
|
| |
Fail more gracefully on > 22 case class parameters. Closes #3631, no
review.
|
| |
|
|
|
|
| |
Warded off a parser crash on certain invalid programs. Closes #3209, no
review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
A wholesale reversion of the pattern matcher to r21939, motivated by
the appearance of #3578. Closes #3578, reopens #2800, #3050. Review by
moors. (I can't keep saying "no review" when every move I make in here
seems to break something.)
|
| |
|
|
|
|
| |
removed integration of placeholder syntax and named arguments. review by
odersky
|
| |
|
|
|
|
|
| |
Reverts r21973, the patch I characterized as "hacky but no-risk" in my
commit message, for causing #3480. Closes #3480. I'd say no review but
who can trust a guy who throws around "no risk" with such abandon.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
also consider non-implicit locals when checking shadowing of implicits:
closes #3453
nonImplicitSynonymInScope implements the predicate that is used in
tryImplicit's checks for shadowing of locally defined implicits
benchmarking shows the predicate does not significantly affect quick.comp+quick.lib (goes from 11min to 11min2s on my machine -- no optimisations)
review by odersky
|
| | |
|
| |
|
|
|
|
| |
Added a migration warning for matches and instance tests when it might
be an Array/Seq test whose answer has changed. Review by odersky.
|
| |
|
|
|
|
|
| |
Hacky but no-risk fix for #3189, which was caused by the ghost of
regular expression patterns rising from the grave to haunt the parser.
No review.
|
| |
|
|
|
|
|
|
| |
changes necessary to plug it back in while preserving everything which
has happened since then in tests and such, but we should be the lookout
for overreversion. Review by phaller (but as a formality, I don't think
it requires direct review.)
|
| |
|
|
|
|
| |
Accumulate missing abstract member errors so they can all be printed
instead of only the first. Closes #2213, no review.
|
| | |
|
| | |
|
| |
|
|
|
| |
A small error message improvement suggested at #3092. No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
Created TypeDiagnostics trait and have begun opportunistically moving
code into it. Along the way, some improvements to error messages.
The situation described in ticket #2206 has always had an applicable
error message, but it wasn't making it out to the user. More kinds of
ambiguity are disambiguated, see the test cases. And overload errors are
printed with some formatting so one has some hope of parsing. Review by
odersky.
|
| | |
|
| |
|
|
|
|
|
| |
Improved @tailrec error messages to specify the reason. In the process
fixed old bug involving tail call transformation. Closes #3275, #2018.
Review by dragos.
|
| |
|
|
|
|
|
| |
back in the form of a compiler plugin. Also promoted -Yfatal-warnings to
-Xfatal-warnings: this is key to writing tests which involve warnings
and should be at least semi-supported. Closes #3300, no review.
|
| |
|
|
|
|
| |
changed testfile, to satisfy new diff algo (which should be reverted
IMO). review by extempore.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Companion objects of primitive types are now values. Term 'scala.Int'
resolves in bytecode to an instance of 'scala.runtime.Int'. This is
the first step towards replacing strings in @specialized with a proper
list of types, so instead of @specialized("Int, Float") one will write
@specialized(Int, Float). Review by odersky.
|
| |
|
|
|
|
|
|
|
| |
As a brief diversion from real work, implemented Damerau–Levenshtein
and ran it on trunk to elicit obvious misspellings. Unfortunately
they're mostly in places like compiler comments which real people never
see, but I fixed them anyway. All those English Lit majors who peruse
our sources are sure to be pleased. No review.
|
| |
|
|
|
|
|
|
| |
Fix for the partest task to fail the build when a test fails, and fixes
for 2/3 of the quietly failing tests. I'm not quite sure what to do
about the view ones, it doesn't look like a simple rename is going to
cut it, so: review by odersky.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If I work on this patch any longer without checking in I will go
stark raving mad. It is broken up into a couple pieces. This one is
the changes to test/. It includes fixing a bunch of tests, removing
deprecated constructs, moving jars used by tests to the most specific
plausible location rather than having all jars on the classpath of all
tests, and some filesystem layout change (continuations get their whole
own srcpath.) This would be the world's most tedious review, so let's
say no review.
[Note: after this commit, I doubt things will build very smoothly until
the rest of the partest changes follow. Which should only be seconds,
but just in case.]
|
| | |
|
| |
|
|
|
|
| |
Closes #2386 by requiring class manifests for an array element type if a
class manifaest for the array type is demanded. Review by dubochet.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leveraged -Xmigration to burn off some warts which arose in the new
collections. Warnings put in place for behavioral changes, allowing the
following. 1) Buffers: create new collections on
++ and -- like all the other collections. 2) Maps: eliminated
never-shipped redundant method valuesIterable and supplied these
return types:
def keys: Iterable[A]
def keysIterator: Iterator[A]
def values: Iterable[B]
def valuesIterator: Iterator[B]
def keySet: Set[A]
I concluded that keys should return Iterable because keySet also exists
on Map, and is not solely in the province of Maps even if we wanted to
change it: it's defined on Sorted and also appears in some Sets. So it
seems sensible to have keySet return a Set and keys return the more
general type.
Closes #3089, #3145. Review by odersky.
|
| |
|
|
|
|
| |
Fixed failing test t3115 via judicious application of -Yfatal-warnings.
No review.
|
