summaryrefslogtreecommitdiff
path: root/test/files/neg
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #5402 from som-snytt/issue/8040-unusedSeth Tisue2017-04-1027-33/+476
|\ | | | | SI-8040 Improve unused warnings
| * SI-8040 Xlint enables unused warningsSom Snytt2017-03-1110-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | `-Ywarn-unused-import` is deprecated in favor of `-Ywarn-unused:imports`. `-Xlint` does not yet enable `-Ywarn-unused:patvars`. But the default for `-Ywarn-unused` is everything, including `patvars`. So `-Xlint:unused` is the populist option, `-Ywarn-unused` more exclusive. Tests are fixed by narrowing scope of `-Xlint` when specified.
| * SI-8040 No warn args to super, main argsSom Snytt2017-03-115-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | `class B(x: X) extends A(x)` uses `x` in ctor, where it is detectable as an ordinary param. `implicit class C(val s: String)` may not use `s` in extension methods, so don't warn. Don't warn required args to main method. Don't warn about synthetic isDefinedAt in anonymous functions, or about defaultCase$.
| * SI-7860 No warn private implicit value classSom Snytt2017-03-115-1/+64
| | | | | | | | | | | | | | | | | | | | | | | | Previously, warned on unused synthetic companion. Also avoid false negative via hashcode reference to the underlying value. Avoid the synthetic conversion method for the implicit class (whose RHS always uses the class); the def itself is synthetic so is normally not warned.
| * SI-8040 Warn patvars in casedefsSom Snytt2017-03-112-2/+24
| | | | | | | | | | | | | | | | Collect bindings in casedefs unless "@-bound to _". Also minor refactor to make it easier to see the cases of `id @ _`. Tupled matching is supposed to be efficient either now or soon.
| * SI-9839 Avoid crash in macro import selector posSom Snytt2017-03-113-1/+23
| | | | | | | | | | | | Ignore bad name pos. Also delete unused val. Thanks, `-Ywarn-unused`!
| * SI-8040 Warn unused parametersSom Snytt2017-03-1110-4/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One can `-Ywarn-unused:params` or more narrowly warn only for unused implicit parameters with `-Ywarn-unused:implicits`. Params includes constructor parameters. The settings for privates and locals are not yet distinguished. ``` $ skalac -Ywarn-unused:help Enable or disable specific `unused' warnings imports Warn if an import selector is not referenced. patvars Warn if a variable bound in a pattern is unused. privates Warn if a private member is unused. locals Warn if a local definition is unused. params Warn if a value parameter is unused. implicits Warn if an implicit parameter is unused. ```
| * SI-8040 Warn unused flagsSom Snytt2017-03-114-1/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce `-Ywarn-unused:x,y,z` and exploit `-Ywarn-unused:patvars`. Although the tree attachment for shielding patvars from warnings is not structural, sneaking the settings flag into the reflection internal TreeGen is awkward. Add test to ensure isolation of patvars warning from others. `-Ywarn-unused-import` is an alias for `-Ywarn-unused:imports`. `-Xlint:unused` is an alias for `-Ywarn-unused`, but not enabled yet. The help text advises to use `-Ywarn-unused`. The future can decide if `-Xlint:unused-imports` is warranted.
| * SI-9158 No warn for comprehension patvarsSom Snytt2017-03-112-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Midstream assignments should not cause unused warnings. Currently the encoding doesn't pass them along, but passes the value from which they were destructured. For for-comprehensions only, the patvar transform tags the binds so that they are not warned if they turn up in a valdef and are unused. Extractors are invoked multiple times if the patvar is used later, as noted on the ticket. In a yield, the valdef is emitted only if the patvar is referenced (possibly saving the extra extraction), so there is no warning there currently.
| * SI-8040 Warn unused pattern varsSom Snytt2017-03-112-1/+51
| | | | | | | | | | | | | | | | | | | | | | | | Warn for unused `case X(x) =>` but, as an escape hatch, not for `case X(x @ _) =>`. The latter form is deemed documentary. (Named args could serve a similar purpose, `case X(x = _) =>`.) An attachment is used to mark the bound var, and the symbol position is used to correlate the identifier with the variable that is introduced. This mechanism doesn't work yet when only a single var is defined.
| * SI-8040 Improve unused warningsSom Snytt2017-03-112-21/+75
| | | | | | | | | | | | | | Add symbol names, don't warn for both getters and setters or for synthetics (except default arg getters). Tweak messages for readability.
* | Merge pull request #5816 from adriaanm/userdefined-apply-212Adriaan Moors2017-04-102-0/+82
|\ \ | | | | | | Allow user-defined `[un]apply` in case companion
| * | Improvements based on reviews by Lukas & JasonAdriaan Moors2017-04-062-4/+42
| | |
| * | Allow user-defined `[un]apply` in case companionAdriaan Moors2017-04-052-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't emit a synthetic `apply` (or `unapply`) when it would clash with an existing one. This allows e.g., a `private apply`, along with a `case class` with a `private` constructor. We have to retract the synthetic method in a pretty roundabout way, as we need the other methods and the owner to be completed already. Unless we have to complete the synthetic `apply` while completing the user-defined one, this should not be a problem. If this does happen, this implies there's a cycle in computing the user-defined signature and the synthetic one, which is not allowed.
* | | SI-2458 Make spec example live testSom Snytt2017-04-095-33/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | Synchronize the live test with the spec update, which is trivial. Also add a neg test showing that an imported name remains ambiguous even if it resolves to the definition in scope with which it is ambiguous.
* | | Merge 2.11.x into 2.12.xAdriaan Moors2017-04-072-2/+6
|\ \ \ | |/ / |/| | | | | Include 99f41a1 Merge pull request #5736
| * | Merge pull request #5736 from adriaanm/t10206Adriaan Moors2017-03-212-2/+6
| |\ \ | | | | | | | | SI-10206 tighten fix for SI-6889
| | * | SI-10206 tighten fix for SI-6889Adriaan Moors2017-02-232-2/+6
| | | | | | | | | | | | | | | | | | | | There are more supertypes of `AnyRef` than you might think: `?{def clone: ?}` is one example...
| * | | Improvements based on reviews by Lukas & JasonAdriaan Moors2017-03-022-4/+42
| | | |
| * | | Allow user-defined `[un]apply` in case companionAdriaan Moors2017-02-272-0/+44
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't emit a synthetic `apply` (or `unapply`) when it would clash with an existing one. This allows e.g., a `private apply`, along with a `case class` with a `private` constructor. We have to retract the synthetic method in a pretty roundabout way, as we need the other methods and the owner to be completed already. Unless we have to complete the synthetic `apply` while completing the user-defined one, this should not be a problem. If this does happen, this implies there's a cycle in computing the user-defined signature and the synthetic one, which is not allowed.
* | | Merge pull request #5724 from jvican/stub-errors-2.12.xAdriaan Moors2017-03-271-15/+12
|\ \ \ | | | | | | | | SCP-009: Improve direct dependency experience
| * | | Improve stub error messages (SCP-009 proposal)jvican2017-03-241-15/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following commit message is a squash of several commit messages. - This is the 1st commit message: Add position to stub error messages Stub errors happen when we've started the initialization of a symbol but key information of this symbol is missing (the information cannot be found in any entry of the classpath not sources). When this error happens, we better have a good error message with a position to the place where the stub error came from. This commit goes into this direction by adding a `pos` value to `StubSymbol` and filling it in in all the use sites (especifically `UnPickler`). This commit also changes some tests that test stub errors-related issues. Concretely, `t6440` is using special Partest infrastructure and doens't pretty print the position, while `t5148` which uses the conventional infrastructure does. Hence the difference in the changes for both tests. - This is the commit message #2: Add partest infrastructure to test stub errors `StubErrorMessageTest` is the friend I introduce in this commit to help state stub errors. The strategy to test them is easy and builds upon previous concepts: we reuse `StoreReporterDirectTest` and add some methods that will compile the code and simulate a missing classpath entry by removing the class files from the class directory (the folder where Scalac compiles to). This first iteration allow us to programmatically check that stub errors are emitted under certain conditions. - This is the commit message #3: Improve contents of stub error message This commit does three things: * Keep track of completing symbol while unpickling First, it removes the previous `symbolOnCompletion` definition to be more restrictive/clear and use only positions, since only positions are used to report the error (the rest of the information comes from the context of the `UnPickler`). Second, it adds a new variable called `lazyCompletingSymbol` that is responsible for keeping a reference to the symbol that produces the stub error. This symbol will usually (always?) come from the classpath entries and therefore we don't have its position (that's why we keep track of `symbolOnCompletion` as well). This is the one that we have to explicitly use in the stub error message, the culprit so to speak. Aside from these two changes, this commit modifies the existing tests that are affected by the change in the error message, which is more precise now, and adds new tests for stub errors that happen in complex inner cases and in return type of `MethodType`. * Check that order of initialization is correct With the changes introduced previously to keep track of position of symbols coming from source files, we may ask ourselves: is this going to work always? What happens if two symbols the initialization of two symbols is intermingled and the stub error message gets the wrong position? This commit adds a test case and modifications to the test infrastructure to double check empirically that this does not happen. Usually, this interaction in symbol initialization won't happen because the `UnPickler` will lazily load all the buckets necessary for a symbol to be truly initialized, with the pertinent addresses from which this information has to be deserialized. This ensures that this operation is atomic and no other symbol initialization can happen in the meantime. Even though the previous paragraph is the feeling I got from reading the sources, this commit creates a test to double-check it. My attempt to be better safe than sorry. * Improve contents of the stub error message This commit modifies the format of the previous stub error message by being more precise in its formulation. It follows the structured format: ``` s"""|Symbol '${name.nameKind} ${owner.fullName}.$name' is missing from the classpath. |This symbol is required by '${lazyCompletingSymbol.kindString} ${lazyCompletingSymbol.fullName}'. ``` This format has the advantage that is more readable and explicit on what's happening. First, we report what is missing. Then, why it was required. Hopefully, people working on direct dependencies will find the new message friendlier. Having a good test suite to check the previously added code is important. This commit checks that stub errors happen in presence of well-known and widely used Scala features. These include: * Higher kinded types. * Type definitions. * Inheritance and subclasses. * Typeclasses and implicits. - This is the commit message #4: Use `lastTreeToTyper` to get better positions The previous strategy to get the last user-defined position for knowing what was the root cause (the trigger) of stub errors relied on instrumenting `def info`. This instrumentation, while easy to implement, is inefficient since we register the positions for symbols that are already completed. However, we cannot do it only for uncompleted symbols (!hasCompleteInfo) because the positions won't be correct anymore -- definitions using stub symbols (val b = new B) are for the compiler completed, but their use throws stub errors. This means that if we initialize symbols between a definition and its use, we'll use their positions instead of the position of `b`. To work around this we use `lastTreeToTyper`. We assume that stub errors will be thrown by Typer at soonest. The benefit of this approach is better error messages. The positions used in them are now as concrete as possible since they point to the exact tree that **uses** a symbol, instead of the one that **defines** it. Have a look at `StubErrorComplexInnerClass` for an example. This commit removes the previous infrastructure and replaces it by the new one. It also removes the fields positions from the subclasses of `StubSymbol`s. - This is the commit message #5: Keep track of completing symbols Make sure that cycles don't happen by keeping track of all the symbols that are being completed by `completeInternal`. Stub errors only need the last completing symbols, but the whole stack of symbols may be useful to reporting other error like cyclic initialization issues. I've added this per Jason's suggestion. I've implemented with a list because `remove` in an array buffer is linear. Array was not an option because I would need to resize it myself. I think that even though list is not as efficient memory-wise, it probably doesn't matter since the stack will usually be small. - This is the commit message #6: Remove `isPackage` from `newStubSymbol` Remove `isPackage` since in 2.12.x its value is not used.
* | | | Merge pull request #5643 from som-snytt/issue/8417Adriaan Moors2017-03-223-0/+22
|\ \ \ \ | | | | | | | | | | SI-8417 Check adapts of each param section
| * | | | SI-8417 Check adapts of each param sectionSom Snytt2017-02-203-0/+22
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Previously, adaptations like auto-tupling were checked only on the last param section of an application. This commit runs the sanity check always.
* | | / remove orphaned checkfilesSeth Tisue2017-03-202-8/+0
| |_|/ |/| | | | | | | | thank you tools/rm-orphan-checkfiles script
* | | Merge pull request #5622 from edmundnoble/extra-errsAdriaan Moors2017-03-023-8/+8
|\ \ \ | | | | | | | | Improved error messages for identically named, differently prefixed types
| * | | Match error lengthsEdmund Noble2017-02-071-1/+1
| | | |
| * | | Improved error messages for identically named, differently prefixed typesEdmund Noble2016-12-313-8/+8
| | | |
* | | | SI-10207 Error before update conversionSom Snytt2017-02-262-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | Gaze deeper for errors before committing to conversion of assignment to update. The error buried in the transformed tree escapes notice of retypechecking and leaks to backend.
* | | | Revert "SI-10133 Require escaped single quote char lit"Adriaan Moors2017-02-213-15/+2
| | | |
* | | | Merge pull request #5629 from som-snytt/issue/10120-quote-errAdriaan Moors2017-02-203-2/+15
|\ \ \ \ | |_|/ / |/| | | SI-10133 Require escaped single quote char lit
| * | | SI-10120 Extra advice on unclosed char literalSom Snytt2017-01-083-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Folks from other languages might mistakenly enclose a string in single quotes. Since this presents as a symbol literal followed by the unpaired single quote, we can add a syntax reminder. Also polish the wording for bad string interpolation.
| * | | SI-10133 Require escaped single quote char litSom Snytt2017-01-082-1/+8
| |/ / | | | | | | | | | | | | | | | The spec specifically requires `'\''` and not `'''`. The error consumes all consecutive single quotes.
* | | Merge pull request #5648 from som-snytt/issue/10148Seth Tisue2017-02-162-2/+25
|\ \ \ | | | | | | | | SI-10148 Follow Java for float literals
| * | | SI-10148 Follow Java for float literalsSom Snytt2017-01-182-2/+25
| |/ / | | | | | | | | | | | | Use `Float.parseFloat` instead of converting from Double. Error when a value rounds to zero.
* | | Merge pull request #5546 from som-snytt/issue/9636Adriaan Moors2017-02-164-1/+25
|\ \ \ | | | | | | | | SI-9636 More precise error pos on apply inference
| * | | SI-9636 More precise error pos on apply inferenceSom Snytt2016-12-204-1/+25
| |/ / | | | | | | | | | | | | If a method type arg is inferred Any, warn about the function and not the innocent arg.
* | | Merge pull request #5662 from teldosas/SI-9675Adriaan Moors2017-02-163-0/+52
|\ \ \ | | | | | | | | SI-9675 warn about non-sensible equals in anonymous functions
| * | | Add warning about non-sensible equals in anonymous functionsteldosas2017-02-013-0/+52
| |/ /
* | | Merge pull request #5542 from retronym/ticket/10066Adriaan Moors2017-02-162-0/+45
|\ \ \ | | | | | | | | SI-10066 Fix crash in erroneous code with implicits, dynamic
| * | | SI-10066 Fix crash in erroneous code with implicits, dynamicJason Zaugg2016-11-182-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compiler support in the typechecker for `scala.Dynamic` is very particular about the `Context` in which it is typechecked. It looks at the `tree` in the enclosing context to find the expression immediately enclosing the dynamic selection. See the logic in `dyna::mkInvoke` for the details. This commit substitutes the result of `resetAttrs` into the tree of the typer context before continuing with typechecking.
* | | | Correct the AbstractVar error messageJon Pretty2017-02-093-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The error currently reads "only classes can have declared but undefined members", which isn't true on two counts: traits can have them, and concrete classes cannot. This corrects the error message to read "only traits and abstract classes can have declared but undefined members".
* | | | Merge pull request #5245 from dwijnand/trailing-commasAdriaan Moors2017-02-082-0/+186
|\ \ \ \ | | | | | | | | | | SI-4986 The glorious return of Comma McTraily
| * | | | SI-4986 SIP-27 Trailing Comma (multi-line only) supportDale Wijnand2016-12-112-0/+186
| | | | |
* | | | | Merge pull request #5646 from som-snytt/issue/8685Adriaan Moors2017-02-071-1/+4
|\ \ \ \ \ | | | | | | | | | | | | SI-8685 Warn on deprecated case ctor
| * | | | | SI-8685 Warn on deprecated case ctorSom Snytt2017-01-161-1/+4
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The narrow use case in the ticket was just to warn on `C.apply` when the constructor has been deprecated. Someone added code to warn after the apply is rewritten, but it wasn't checking the constructor (and the tree was checked before but not after transform).
* | | | | Merge pull request #5585 from som-snytt/issue/10097Adriaan Moors2017-02-0710-2/+45
|\ \ \ \ \ | | | | | | | | | | | | SI-10097 Error if no non-implicit case class param
| * | | | | SI-10097 Adapt unless -Xsource:2.13Som Snytt2016-12-145-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For 2.12 migration, insert missing case class param section, strip caseaccessor from implicit paramsection, and deprecate the adaptation.
| * | | | | SI-8704 Also warn if effectively multiple implicitSom Snytt2016-12-143-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Current semantics are that leading implicit param turns the parameter section into an implicit section (though without making other params implicitly implicit). Warn if more than one head of a param section is implicit, since that results in multiple implicit param sections.
| * | | | | SI-8704 Error on bad implicit sectionsSom Snytt2016-12-144-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of aborting when a class def has extra parameter section, take all parameter sections and sanity check the use of leading implicit to indicate an implicit parameter section.
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-12 02:21:20 +0000