| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
One hundred! One hundred times slower on windows! Ah, ha, ha! Adjusted
test case, no review.
|
| |
|
|
|
|
|
| |
Fix for a big bug in lastIndexOfSlice and some latent negative index
bugs in both that and indexOfSlice. This stuff is taxing. Closes #4348,
no review.
|
| | |
|
| |
|
|
|
|
|
| |
infix implicits to Integral and Fractional. As a bonus this patch
knocked 10,000 long boxings off a specialized test. Who knew. Closes
#4308, #4321, review by community.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing toPar* methods, since we've agreed they're difficult to: -
underestand - maintain
Also, changed the docs and some tests appropriately.
Description:
1) Every collection is now parallelizable - switch to the parallel version of the collection is done via `par`.
- Traversable collections and iterators have `par` return a parallel
- collection of type `ParIterable[A]` with the implementation being the
- representative of `ParIterable`s (currently, `ParArray`). Iterable
- collections do the same thing. Sequences refine `par`'s returns type
- to `ParSeq[A]`. Maps and sets do a similar thing.
The above means that the contract for `par` changed - it is no longer guaranteed to be O(1), nor reflect the same underlying data, as was the case for mutable collections before. Method `par` is now at worst linear.
Furthermore, specific collection implementations override `par` to a more efficient alternative - instead of copying the dataset, the dataset is shared between the old and the new version. Implementation complexity may be sublinear or constant in these cases, and the underlying data structure may be shared. Currently, these data structures include parallel arrays, maps and sets, vectors, hash trie maps and sets, and ranges.
Finally, parallel collections implement `par` trivially.
2) Methods `toMap`, `toSet`, `toSeq` and `toIterable` have been refined
for parallel collections to switch between collection types, however,
they never switch an implementation from parallel to sequential. They
may or may not copy the elements, as is the case with sequential
variants of these methods.
3) The preferred way to switch between different collection types,
whether maps, sets and seqs, or parallel and sequential, is now via use
of methods `toIterable`, `toSeq`, `toSet` and `toMap` in combination
with `par` and `seq`.
Review by odersky.
|
| | |
|
| |
|
|
|
| |
Disabled test not actually doing anything anyway, no review.
|
| |
|
|
|
|
|
|
|
| |
Always forget that checking system properties causes exceptions in
applets and such. Made the system property wrapper wrap its access
checks in some more wrapping. I spent a long time trying to write a
test for the security manager but it's hopeless without knowing all the
details of the test environment. Closes #4346, no review.
|
| |
|
|
|
|
|
|
|
|
|
| |
warnings due to my changing a map from mutable to immutable (which
ought to be the good direction) because "def update" still lingers on
immutable maps. I counted the days elapsed since it was marked for death
(before 2.8.0) and added in the bugliness of what I was looking at and
bid it farewell.
Now removed: def update on immutable maps. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various chronic annoyances with the repl addressed. Much improved
transcript pasting. Now goes back in time to fix the transcript if it
contains self-referential "res0, res1" etc. so that it works as it
originally did. Shows which commands it is running, and places the
commands with their result in a manner suitable for framing.
Also, a new :paste command which accepts input up to ctrl-D, so you can
enter companions without gyrations, or code from people who write in a
repl unfriendly fashion by putting their curly braces on the next line
(I'm looking at you mark harrah) or you name it, it's not picky.
No review.
|
| | |
|
| |
|
|
|
|
|
|
| |
Raised the threshold for the test looking at view performance. I guess
if views are only 50x as slow on windows that's still a lot better than
100,000. (The real issue is more like "it's windows" plus "it's windows
running on virtualbox".) No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
A small addition to the library to address something bugging me forever.
It's a light interface to system properties. It's not intended to solve
all property issues for all time, only to greatly improve on the overly
ad-hoc ways things are presently done. Feedback welcome. Sorry it's
coming in this late but it arises from writing the tools to fix the bugs
to allow that release to happen. That's nature's circle of bugs. Review
by community.
|
| |
|
|
|
| |
for pointing me toward the problem. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all view classes now list parents like
trait Appended[B >: A] extends super.Appended[B] with Transformed[B]
instead of the former
trait Appended[B >: A] extends Transformed[B] with super.Appended[B]
because as it was, the implementation of foreach in
TraversableViewLike#Transformed was repeatedly trumping overrides found
in e.g. IterableLike. This change was not without its own consequences,
and much of the rest of the patch is dealing with that. A more general
issue is clearly revealed here: there is no straightforward way to deal
with trait composition and overrides when some methods should prefer B
over A and some the reverse. (It's more like A through Z in this case.)
That closes #4279, with some views being five orders of magnitude slower
than necessary. There is a test that confirms they'll stay performance
neighbors.
In the view classes (Zipped, Mapped, etc.) I attended to them with
comb and brush until they were reasonably consistent. I only use
"override" where necessary and throw in some "final" in the interests
of trying to anchor the composition outcome. I also switched the
newSliced, newZipped, etc. methods to use early init syntax since a
number have abstract vals and I found at least one bug originating with
uninitialized access.
There was a piece of a parallel collections scalacheck test failing,
which
I disabled out of expedience - am emailing prokopec.
There is plenty of work left to do but paulp must get back to other 2.9
issues. This is the Zurich->SF airplane patch. No review.
|
| |
|
|
|
|
|
|
| |
Adding special take and drop for numeric ranges, and a test. Parallel
numeric ranges are added, but currently disabled.
Review by extempore.
|
| |
|
|
|
|
|
|
|
|
|
| |
An overhaul of slice and related implementations (primarily that is
drop and take.) In the course of trying to get it working consistently
(mostly with respect to negative indices, which were dealt with
arbitrarily differently across the 25+ concrete implementations) I fixed
various bugs.
Closes #4288, no review.
|
| |
|
|
|
| |
No review.
|
| |
|
|
|
|
|
| |
More signature fixes and tests and generally being more sophisticated
about our primitive squashing. These signatures belong in world-class
museums but we are their shepherds for now. Closes #4317, no review.
|
| |
|
|
|
|
| |
More signature work arising from actually looking at the signatures.
Slightly improved the coverage of the tests. No review.
|
| |
|
|
|
|
|
| |
And extempore's original plan carries the day: null.## no longer throws
an NPE. Took advantage of feature to simplify a bunch of sharp-sharp
calculations. Closes #4311, no review.
|
| |
|
|
|
| |
Changed class name from `Main` to `Test` in a failing test case.
|
| |
|
|
|
| |
Review by dragos.
|
| | |
|
| |
|
|
|
|
|
| |
Renamed some methods in icode exception handlers for clarification,
fixed finalizers for 'return' inside a catch block. closes #4240. review
by rytz.
|
| |
|
|
|
|
| |
One still broken. (Very sorry, all laptop and no servers makes jack a
dull tester.) No review.
|
| |
|
|
|
|
|
|
| |
Seem to have made a breakthrough with signature correctness. Most of
the remaining troubles were due to inherited members and their foreign
identifiers, but I think I found a simple way to make everyone happy.
Closes #4238, review by moors.
|
| |
|
|
|
|
|
| |
Glad to see there was a test case; but we have to push harder when
writing tests to include the key characteristics of the function being
tested. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Another lap around the track with generic signatures. At the root of the
issue reported in #4214 is our old friend (fondly remembered from the
days of primitive equality) boxed/primitive unification.
// scala
trait T[A] {
def f(): A
}
// the generic signature spec doesn't allow for parameterizing
// on primitive types, so this cannot remain Char. However
// translating it to Character, as was done, also has issues.
class C extends T[Char] {
def f(): Char = 'a'
}
// Note that neither of the signatures for f, the implementation // or
the bridge method, matches the type parameter. Generic interfaces in
class: T<java.lang.Character> Generic signatures: public char C.f()
public java.lang.Object C.f()
After this commit, primitive type parameters are translated into Object
instead of the boxed type. It was martin's idea, so no review. Closes
#4214.
|
| |
|
|
|
|
|
| |
Break 9 tests, fix 9 tests, realize you broke the test you checked in
between +9 and -9. Fix that and generalize the repl tests a little. I
think we're all the way there. No review.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Altered a check for impl classes to look at the name instead of the
flags, since the flags are wrong. Obviously we should fix the flags or
otherwise better address. Note that the test is well intentioned but
doesn't actually fail with older versions; the crash is not easy to
reproduce even when I simulate the whole repl. Review by dragos.
|
| |
|
|
|
| |
No review.
|
| |
|
|
|
| |
about how to obtain a String and how not to. Closes #4297, no review.
|
| |
|
|
|
|
|
| |
lazy val calls shouldn't be included in pure expressions in general.
closes 4047. fixed also bug in optimizer (was eliminating a.foo call in
the test). review by dragos
|
| |
|
|
|
| |
in future attempts. Closes #4291, references #4214, no review.
|
| | |
|
| |
|
|
|
|
| |
changed test output and comment, because mixed in fields and methods no
longer get a generic signature. Review by extempore.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved unlift to the Function companion object, which might have been
better in the first place. Had to make a minor change to genprod, and
then I couldn't escape that unscathed. Finished the not very complete
undertaking I found there to update the scaladoc. Lots of little changes
to the generated text and code.
I changed genprod to only put a unique stamp on Function0 so we can stop
having a 100 file diff everytime an i is dotted somewhere.
Closes #3825, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Rediscovering that transpose sometimes throws an exception on irregular
lists and sometimes returns an irregular result (depending on whether
the first collection is the longest or not) indicated that this needs a
better resolution than the status quo. Determination: as long as we're
throwing an exception on any invalid input, we should throw an exception
on all invalid input, so that's what it does now. I postpone any attempt
to offer a variation accepting a "hole value". Closes #3597, review by
community.
|
| |
|
|
|
|
|
|
| |
Revert "Added missing string prefixes for names of map and set
collection classes." and related commits.
No review.
|
| |
|
|
|
| |
Fixing tests depending on map and set string representations. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I chased a lot of ghosts before finding the real culprit for why partest
failures have been unfailing.
Process(Seq("bash", "-c", "exit 42")) ! // 42 Process(Seq("bash",
"-c", "exit 42")) #> logFile ! // 0
That behavior is not yet fixed, but I altered partest not to use #> and
fixed the test which should have been failing but wasn't. Closes #4227,
no review.
|
| | |
|
| |
|
|
|
| |
Added all the javap command line options to :javap. No review.
|
| |
|
|
|
|
|
|
| |
After discovering #3376 was fixed I gave in and tried to write a test.
Now that the fiddling is over you can write repl tests without creating
5000 streams and settings. Look at test/files/run/bug3376.scala or
jvm/interpreter.scala to see. Test case closes #3376, no review.
|
| |
|
|
|
|
|
|
|
| |
I keep seeing huge simplifications available in the repl. Lot of
interesting features have come to town since it was first conceived. In
this commit I give the internal names some tips on aesthetics, and put
each line in its own package like civilized artificial constructs. No
review.
|
