| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
| |
Added a test to make sure distinct preserves ordering. No review
|
| | |
|
| |
|
|
|
|
|
| |
symbol does not cause any crashes, but the method using an unknown
symbol will not be used for inlining. Resurrected tests, removed
spec-matrix for the moment. No review.
|
| |
|
|
|
|
| |
way equals was being handled, and hammered it out. New ==/## tests which
covers all types and values. Review by odersky.
|
| |
|
|
|
|
| |
closes #3241 and improves serialization of hash tries. review by
community.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling what I think are the last two failing tests, one each of the
two leading bugs among those we've seen here today on testing theater:
"could not find toMap: (x$1: scala.collection.TraversableOnce,x$2:
Predef$<:<)"
and
"scala.tools.nsc.symtab.Types$TypeError: method react cannot be
accessed in java.lang.Object with scala.actors.Reactor[Any]
No review but hey lets' see if we can re-enable these tests soonish.
|
| |
|
|
|
| |
Disabling some more tests which crash under -optimise. No review.
|
| |
|
|
|
| |
Disabled the test which is hanging the -optimise run. No review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
instead of a flaky string, it now takes a
repeated parameter list of primitive types:
@specialized("Int, Double") becomes @specialized(Int, Double). No
review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
can have a collection containing all the even numbers in the universe
and still be home in time for tea. Threw in some Stream cleanups for
free. Closes #3265, review by community.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
As a brief diversion from real work, implemented Damerau–Levenshtein
and ran it on trunk to elicit obvious misspellings. Unfortunately
they're mostly in places like compiler comments which real people never
see, but I fixed them anyway. All those English Lit majors who peruse
our sources are sure to be pleased. No review.
|
| |
|
|
|
|
|
|
| |
Fix for the partest task to fail the build when a test fails, and fixes
for 2/3 of the quietly failing tests. I'm not quite sure what to do
about the view ones, it doesn't look like a simple rename is going to
cut it, so: review by odersky.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If I work on this patch any longer without checking in I will go
stark raving mad. It is broken up into a couple pieces. This one is
the changes to test/. It includes fixing a bunch of tests, removing
deprecated constructs, moving jars used by tests to the most specific
plausible location rather than having all jars on the classpath of all
tests, and some filesystem layout change (continuations get their whole
own srcpath.) This would be the world's most tedious review, so let's
say no review.
[Note: after this commit, I doubt things will build very smoothly until
the rest of the partest changes follow. Which should only be seconds,
but just in case.]
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
closes #3203, overriding more of the TraversableLike methods. also
tightened access privileges to internal fields and methods. review by
community.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While working on partest discovered that CompilerCommand ignores half
its constructor arguments and a couple dozen places blithely pass it
those arguments as if they're being used. Then there were setups like
this:
class OfflineCompilerCommand(
arguments: List[String],
settings: Settings,
error: String => Unit,
interactive: Boolean)
extends CompilerCommand(arguments, new Settings(error), error, false)
Hey offline compiler command, why throw away the perfectly good settings
you were given? Ever heard 'reduce, reuse, recycle'? How did you ever
work... or do you? No review.
|
| |
|
|
|
| |
Apparently I can't fix a test case to save my life. No review.
|
| | |
|
| |
|
|
|
|
| |
Fixed an issue with no-parameter-list methods not being elided. No
review.
|
| | |
|
| |
|
|
|
|
| |
Although it was working fine, a test case for @elidable to make sure
that state of affairs continues. No review.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Went ahead and implemented classpaths as described in email to
scala-internals on the theory that at this point I must know what I'm
doing.
** PUBLIC SERVICE ANNOUNCEMENT **
If your code of whatever kind stopped working with this commit (most
likely the error is something like "object scala not found") you can get
it working again with either of:
passing -usejavacp on the command line
set system property "scala.usejavacp" to "true"
Either of these will alert scala that you want the java application
classpath to be utilized by scala as well.
Review by community.
|
| |
|
|
|
|
|
|
|
| |
During my last look at r21224 I noticed what must be a long standing
bug in Array.update handling. Fixing this probably never to be noticed
corner case (see bug3175.scala) seduced me into drumming out some
duplication. At least we got some nice commenting out of it. Review by
dubochet.
|
| |
|
|
|
|
|
| |
Some work on the Array methods as they manifest in refinement types:
tightening when Array code is generated and also what code is generated.
Review by dubochet.
|
| |
|
|
|
|
|
|
| |
Returning to the thrilling world of equality and hashCodes now
that Any.## is a reality. Moved the hash functions from Predef to
ScalaRunTime, and made what appears to be an optimization to equals by
not losing the result of an instanceof test. Review by community.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to BufferLike (++ and similar now create a new collection.)
Removed MapLikeBase. Annotated all the methods in mutable.{ Map, Set }
which mutated in-place in 2.7 to note that they create new
collections, and implemented same.
At this point the only +/- like method which mutates in place which I am
aware of is BufferLike.+ (see source comment for my observations.)
Also tweaked some collections return types as necessitated by these
changes, such as mutable.Set.clone() now returning "This" rather than
mutable.Set[A].
References #3089, closes #3179. Review by odersky.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leveraged -Xmigration to burn off some warts which arose in the new
collections. Warnings put in place for behavioral changes, allowing the
following. 1) Buffers: create new collections on
++ and -- like all the other collections. 2) Maps: eliminated
never-shipped redundant method valuesIterable and supplied these
return types:
def keys: Iterable[A]
def keysIterator: Iterator[A]
def values: Iterable[B]
def valuesIterator: Iterator[B]
def keySet: Set[A]
I concluded that keys should return Iterable because keySet also exists
on Map, and is not solely in the province of Maps even if we wanted to
change it: it's defined on Sorted and also appears in some Sets. So it
seems sensible to have keySet return a Set and keys return the more
general type.
Closes #3089, #3145. Review by odersky.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Temporarily disabling failing test until I can finish my partest work.
No review.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
- new immutable HashMap implementation based on a hash trie. this is the
first iteration, more optimizations will be added later. - updated test
cases to reflect new ordering of elements - made Map.empty and Set.empty
singletons, deprecating classes Map.EmptyMap and Set.EmptySet Review by
extempore, odersky.
|
| |
|
|
|
|
| |
null, and thrown MatchErrors don't NPE trying to stringify null. No
review.
|
| |
|
|
|
|
|
|
|
| |
Fix for #3136 by reverting the line in r18184 which caused this and
other regressions. The downside is that the #1697 test case no longer
passes, but protracted shrug because it wasn't entirely fixed anyway.
Review by moors. (Can you triangulate your way to a patch where both
work simultaneously? It's today's bonus challenge!)
|
| | |
|
| |
|
|
|
|
| |
ScalaRunTime method to perform sameElements as fix for #2867. Review by
odersky.
|
| |
|
|
|
|
|
|
| |
what must be legacy scalatest.* properties to partest.*, boldly assuming
that the fact that partest is pretty much unusable outside of scalac
means there are no users outside of scalac who might be disrupted by
eliminating old property names. Review by community.
|
