| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
gives fewer insensible warnings about actually sensible things, etc.
Large test case with 30 warnings elicited.
Closes #282 (again), no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes #3582: typedTypeDef needs to run in a new typer for TypeDefs with
type parameters
this was honored when typedTypeDef was called by typed1, but other
callers did not this would cause higher-order type parameters to be
re-entered in the scope of a method or a class
(by the way, should we recycle scopes for higher-order type params? now
new scopes are created, symbols entered, and tree's symbols updated)
changed some spurious vars to vals
review by odersky
|
|
|
|
|
|
| |
Modified r22702 to avoid tarring overloads with the same brush. No
review.
|
|
|
|
|
|
|
|
|
|
| |
Disallowed super.XX calls to Any methods which are presently either
crashing the compiler (isInstanceOf) or leading to runtime failure (==
and !=) in addition to one which was being rewritten to a this call but
makes more sense disallowed like the others (##).
Closes #3736, review by odersky.
|
| |
|
| |
|
|
|
|
|
|
| |
fixes names/defaults when using :_* for specifying repeated parameters.
close #3697, no review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scala> def ser(o: AnyRef) = new java.io.ObjectOutputStream(new java.io.ByteArrayOutputStream()).writeObject(o)
ser: (o: AnyRef)Unit
scala> @serializable class Outer {
| case class Inner(x: Int)
| }
defined class Outer
scala> val o = new Outer
o: Outer = Outer@34469729
scala> ser(new o.Inner(1))
scala> o.Inner // initialize the Inner$module field of o
res1: o.Inner.type = Inner
scala> ser(new o.Inner(1))
java.io.NotSerializableException: Outer$Inner$
review by extempore.
|
| |
|
| |
|
|
|
|
|
|
| |
added @deprecatedName annotation, allowing to deprecate parameter names.
review by prokopec.
|
|
|
|
|
|
|
| |
Parse ordering issue prevented passing properties containing a :. There
is a test case included, but note that partest passes it with or without
the patch: see ticket #3712. Closes #3495, no review.
|
|
|
|
|
| |
Fixes priority queues and makes them iterables now.
|
| |
|
| |
|
|
|
|
|
|
| |
Moved the burden of forgivingness for string slices into StringOps where
it belongs. Review by odersky.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
no review
Author: Mark Harrah <dmharrah@gmail.com>
Date: Thu Jul 8 10:30:57 2010 -0400
Source: http://github.com/harrah/scala-starrless/commit/0c7759c95b47cebc6d9fa77cefd34ef638e2706e
Reviewer: moors
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
closes #3622: refchecks erased types without uncurrying them first
review by odersky
|
|
|
|
|
| |
review by extempore
|
|
|
|
|
|
| |
closes #3507: don't generate manifests where we can't refer to the
existentially bound value
|
|
|
|
|
| |
review by prokopec
|
|
|
|
|
|
|
|
|
| |
fixed by having mixin do the cloning at the beginning of erasure and
then updating the symbol's info to transform it to be valid in current
phase
review by odersky
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
note that all type parameters must be reported in error messages about
failing type inference, but only type parameters that were inferred
successfully should be substituted
the idea of mapping type parameter symbols to the corresponding type
ref in order to make substitution the identity does not seem to work,
leading to errors like:
src/library/scala/collection/immutable/SortedMap.scala:38:
error: type mismatch; found :
scala.collection.immutable.SortedMap[A,B(in method empty)]
required: scala.collection.immutable.SortedMap[A,B(in trait
SortedMap)]
override def empty: SortedMap[A, B] = SortedMap.empty
^
(I guess that's why they were retracted before, but that wasn't done consistently, leading to #3152 -- my first attempt at fixing the latter lead to this bug... I've assigned #3152 to you Martin, as I can't decide how to fix it.)
review by odersky
|
|
|
|
|
|
|
| |
this broke the invariant that argss is a regular matrix
review by odersky
|
|
|
|
|
| |
review by odersky
|
|
|
|
|
| |
review by dragos
|
|
|
|
|
|
| |
closes #3247: syntax error regarding context bounds generalized to
include view bounds as we cannot easily be more specific no review
|
|
|
|
|
|
|
|
|
|
| |
this patch introduces a new subclass of TypeTree: TypeTreeWithDeferredRefCheck, which tracks the type args and type params of a type application when it was beta-reduced during typing without checking that the application was well-kinded -- that check must wait until refchecks, but was never performed since the application had been beta-reduced away
caveat discovered while working on the fix: adapt turned all trees for
which _.isType holds into TypeTree's
review by odersky
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes #2331: the pre-transform in Erasure did not correctly recurse in
the case of a TypeApply.
It simply returned the function, which might very well have been, say,
a Select node, which had to be erased in case the qualifier's type is a
refinement.
(sorry about the whitespace changes)
review by odersky
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When compilation fails because of an unimplemented abstract var, give
a more precise error message about what happened. Also avoid issuing
the same error twice because neither getter nor setter is implemented.
Closes #36, review by rytz.
|
|
|
|
|
|
| |
Closes #1766 (structural method dispatch broken in class with multiple
constructors). Review by prokopec.
|
|
|
|
|
|
|
| |
Made a null output sink and applied it to the recently failing test,
which is displaying non-deterministic output by way of the underlying
parser. No review.
|
|
|
|
|
|
|
| |
Some more improvement on the error messages when @tailrec fails. Now it
gives a sensible message if the recursive target is actually a supertype
of this, rather than saying the call is not in tail position. No review.
|
| |
|
|
|
|
|
| |
(That's right, multiple two digit tickets.)
|
|
|
|
|
|
| |
Fail more gracefully on > 22 case class parameters. Closes #3631, no
review.
|
|
|
|
|
|
| |
Fixed an infinite loop in the xml parser on invalid input. Also found an
off by one bug in Source while fixing it. No review.
|
|
|
|
|
|
| |
A crasher in the pattern matcher revealed a flaw in how equality
comparisons were constructed. Closes #3570, no review.
|
|
|
|
|
|
|
|
| |
Test case for #1974, which was fixed at some point even though martin
says in the comments it wouldn't be fixed for 2.8. Take that, things
which think they won't be fixed which really will be. Closes #1974, no
review.
|
| |
|
|
|
|
|
|
| |
Warded off a parser crash on certain invalid programs. Closes #3209, no
review.
|