summaryrefslogtreecommitdiff
path: root/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #1487 from dragos/issue/fix-6505Josh Suereth2012-10-111-0/+33
|\ | | | | Fixed SI-6505. Respond to ask calls by immediate failure after compiler shutdown.
| * Fixed SI-6505. Respond to ask calls by immediate failure even after compiler ↵Iulian Dragos2012-10-101-0/+33
| | | | | | | | | | | | | | shutdown. When the compiler is asked to shutdown, it may still have items on the working queue, and more can be added by clients in other thread that don't *know* the compiler is down yet. These requests were never serviced, leading to deadlocks or timeouts. review by @odersky, @hubertp
* | Fix for SI-6499, regression in type inference.Paul Phillips2012-10-101-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | I can't do any better than a reproduced comment: For some reason which is still a bit fuzzy, we must let Nothing through as a lower bound despite the fact that Nothing is always a lower bound. My current supposition is that the side-effecting type constraint accumulation mechanism depends on these subtype tests being performed to make forward progress when there are mutally recursive type vars. See pos/t6367 and pos/t6499 for the competing test cases.
* | Merge pull request #1483 from gkossakowski/SI-6440Josh Suereth2012-10-102-0/+8
|\ \ | | | | | | SI-6440: Revert change to `TraversableLike.filterNot`
| * | SI-6440: Revert change to `TraversableLike.filterNot`Grzegorz Kossakowski2012-10-092-0/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit df9f470f14262b9b1002f022c2620d8c38835805 introduced a change to `TraversableLike.filterNot` which broke Stream implementation that does override `filter` implementation but does not override `filterNot` implementation. This shows clearly that reusing code for strict and non-strict collections is very problematic. Added a test-case covering this problem. Closes SI-6440. Review by @retronym.
* | Merge pull request #1471 from retronym/ticket/6483Josh Suereth2012-10-092-0/+33
|\ \ | | | | | | SI-6483 Prohibit super[T] references in value classes.
| * | SI-6483 Prohibit super[T] references in value classes.Jason Zaugg2012-10-072-0/+33
| | | | | | | | | | | | This seems the safest course of action for 2.10.0.
* | | Merge pull request #1458 from scalamacros/pullrequest/reflectionJosh Suereth2012-10-094-4/+16
|\ \ \ | |_|/ |/| | Another reflection bomb
| * | removes EmptyTermName and EmptyTypeNameEugene Burmako2012-10-031-1/+1
| | | | | | | | | | | | We have nme.EMPTY and tpnme.EMPTY for that.
| * | renames macros.TypeError to TypecheckExceptionEugene Burmako2012-10-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Again, this is not a fatal error, so it should end with an Error, and it should subclass not Throwable, but Exception. Also moved the exception outside the cake to simplify error handling, along the same lines of what've been done for parsing and reification exceptions.
| * | turns on documentation of scala.reflect.runtimeEugene Burmako2012-10-032-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | We definitely need to document scala.reflect.runtime.universe, therefore adding scala.reflect.runtime to skipPackages was a mistake. But then we need to make a bunch of internal classes private to reflect or to scala. Not very pretty, but it works.
* | | Merge pull request #1442 from adriaanm/ticket-6215Grzegorz Kossakowski2012-10-082-8/+9
|\ \ \ | | | | | | | | SI-6215 Fix compiler crash on private method in value class
| * | | SI-6215 Fix compiler crash on private method in value classMartin Odersky2012-10-022-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes the problem with private defs in value classes by moving the $extension after the name proper rather than before. The previous scheme did not commute with makeNonPrivate: I.e. if -ext-> is "generate extension name" and -mnp-> is "make not private" we did get for method foo in value class Foo: foo -ext-> extension$foo -mnp-> Foo$$extension$foo but foo -mnp-> Foo$$foo -ext-> extension$Foo$$foo With the change both variations give the same name: foo -ext-> foo$extension -mnp-> Foo$$foo$extension but foo -mnp-> Foo$$foo -ext-> Foo$$foo$extension
* | | | SI-6485 stops creating extmethods for macrosEugene Burmako2012-10-083-0/+20
| | | | | | | | | | | | | | | | | | | | Macros don't correspond to bytecode-level methods, therefore there's no need to undergo any transformations past typer.
* | | | MethodSymbol.params => MethodSymbol.paramssEugene Burmako2012-10-073-12/+12
| |_|/ |/| | | | | | | | | | | | | | | | | | | | This matter was discussed at scala-internals: http://groups.google.com/group/scala-internals/browse_thread/thread/6414d200cf31c357 And I am convinced with Paul's argument: consistency of the convention is very important.
* | | Merge pull request #1455 from scalamacros/topic/manifestsJosh Suereth2012-10-054-38/+18
|\ \ \ | | | | | | | | undeprecates manifests for 2.10.0
| * | | undeprecates manifests for 2.10.0Eugene Burmako2012-10-034-38/+18
| | |/ | |/| | | | | | | | | | | | | | | | | | | Since scala-reflect.jar is going to be declared experimental for 2.10.0, it doesn't make sense to deprecate manifests in favor of type tags. Class manifests, however, ARE deprecated for class tags, because class tags don't require scala-reflect.jar and are generated independently of type tags.
* | | Merge pull request #1451 from gkossakowski/SI-6451Grzegorz Kossakowski2012-10-042-64/+64
|\ \ \ | |/ / |/| | SI-6451: Rename classes in `unchecked-abstract.scala` test.
| * | SI-6451: Rename classes in `unchecked-abstract.scala` test.Grzegorz Kossakowski2012-10-032-64/+64
| |/ | | | | | | | | | | | | | | | | | | As reported Miguel, `Con` is problematic name of a class on Windows and makes this test to fail. Renamed classes to something else which hopefully make Windows build happy again. Closes SI-6451. Review by @magarciaEPFL or @paulp.
* | Merge pull request #1443 from gkossakowski/anyval-restrictionsGrzegorz Kossakowski2012-10-0310-21/+92
|\ \ | | | | | | AnyVal/value classes restrictions
| * | Put more implementation restrictions on value classes.Grzegorz Kossakowski2012-10-036-4/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nested objects, classes and lazy vals are disallowed at any nesting level in value classes; e.g. lazy vals local to a method defined in a value class. There are still allowed in universal traits. This is a temporary, implementation restriction that is planned to be addressed in future releases of Scala. Error messages has been updated to communicate that intent. Moved tests for SI-5582 and SI-6408 to pending folder. They have to stay there until implementation restrictions are addressed. Closes SI-6408 and SI-6432. Review by @odersky, @harrah and @adriaanm.
| * | Fixed problem in SI-6408Martin Odersky2012-10-031-0/+11
| | | | | | | | | | | | Fixed problem reported in comment, where inner classes of value classe caused a compiler crash.
| * | Revised restrictions for value classes and unversal traitsMartin Odersky2012-10-036-19/+26
| |/ | | | | | | | | | | | | | | | | and brought compiler in line with them. One thing we can accept IMO are nested classes (nested objects are still a problem). In fact, it makes no sense to exclude nested classes from value classes but not from universal traits. A class nested in universal trait will becomes a class nested in a value class by inheritance. Note that the reflection library already contains a universal trait with a nested class (IndexedSeqLike), so we should accept them if we can.
* | Merge pull request #1446 from retronym/ticket/6436-2Grzegorz Kossakowski2012-10-034-0/+38
|\ \ | |/ |/| SI-6436 Handle ambiguous string processors
| * SI-6436 Handle ambiguous string processorsJason Zaugg2012-10-024-0/+38
| | | | | | | | | | | | | | | | Before, we got in an inifinite loop by chasing the error typed result of adaptToMemberWithArgs. One point of befuddlement remains: why did t6436 and t6436b behave differently before this change?
* | Merge pull request #1425 from phaller/issue/6442Grzegorz Kossakowski2012-10-0211-78/+68
|\ \ | | | | | | SI-6442 - Add ActorDSL object for actor migration kit
| * | SI-6442 - Add ActorDSL object for actor migration kitphaller2012-09-2911-78/+68
| |/ | | | | | | Removes MigrationSystem, since ActorDSL replaces it.
* | Test case for SI-6311.Paul Phillips2012-09-291-0/+5
| | | | | | | | | | This covers the situation which broke in 5c5e8d4dcd, reverted in the previous commit.
* | Revert "SI-4881 infer variance from formals, then result"Paul Phillips2012-09-292-32/+4
|/ | | | This reverts commit 5c5e8d4dcd151a6e2bf9e7c259c618b9b4eff00f.
* Merge pull request #1415 from scalamacros/is-value-typeEugene Burmako2012-09-288-0/+99
|\ | | | | a fork of isValueType and isNonValueType
| * fully initializes symbols on `typeSignature`Eugene Burmako2012-09-281-1/+1
| | | | | | | | | | | | only affects runtime reflection, because Symbol.typeSignature is only defined in the reflection API. the rest of the compiler uses Symbol.info instead.
| * Fix for failing test.Paul Phillips2012-09-282-7/+18
| | | | | | | | | | | | | | | | | | | | There's some very sketchy behavior visible - I'm printing a method signature and getting this: [B <: <?>, That <: <?>](f: <?>)(implicit cbf: <?>)That But there's no exposed way to force the info. Am I supposed to call isSealed or something?
| * Implementations of isValueType and isNonValueType.Paul Phillips2012-09-283-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Restrictions regarding how non-value types can be used have generally not been enforced explicitly, depending instead on the fact that the compiler wouldn't attempt to use them in strange ways like offering a method type as a type argument. Since users can now create most types from scratch, it has become important to enforce the restrictions in a more direct fashion. This was a lot harder than it probably should have been because there are so many types which go unmentioned by the specification. Hopefully a useful exercise in any case.
| * SI-6417 correctly reifies non-value typesEugene Burmako2012-09-284-0/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we're reifying non-value types (e.g. MethodTypes), we can't use them as type arguments for TypeTag/WeakTypeTag factory methods, otherwise the macro expansion won't typecheck: http://groups.google.com/group/scala-internals/browse_thread/thread/2d7bb85bfcdb2e2 This situation is impossible if one uses only reify and type tags, but c.reifyTree and c.reifyType exposes in the macro API let anyone feed anything into the reifier. Therefore I now check the tpe that is about to be used in TypeApply wrapping TypeTag/WeakTypeTag factory methods and replace it with AnyTpe if it doesn't fit.
| * showRaw no longer crashes on NoSymbolEugene Burmako2012-09-282-0/+6
| |
* | Merge pull request #1347 from soc/SI-6380Grzegorz Kossakowski2012-09-282-0/+27
|\ \ | |/ |/| SI-6380 Add @throws[Exception]
| * SI-6380 #1 Add @throws[Exception]Simon Ochsenreither2012-09-212-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change allows an additional notation of the @throws annotation: Old-style: @throws(classOf[Exception]) New-style: @throws[Exception] The optional String argument moves @throws in line with @deprecated, @migration, etc. and prevents confusion caused by the default inheritance of ScalaDoc comments and the non-inheritance of annotations. Before: /** This method does ... * @throws IllegalArgumentException if `a` is less than 0. */ @throws(classOf[IllegalArgumentException]) def foo(a: Int) = ... Now: /** This method does ... */ @throws[IllegalArgumentException]("if `a` is less than 0") def foo(a: Int) = ... ScalaDoc @throws tags remain supported for cases where documentation of thrown exceptions is needed, but are not supposed to be added to the exception attribute of the class file. In this commit the necessary compiler support is added. The code to extract exceptions from annotations is now shared instead of being duplicated all over the place. The change is completely source and binary compatible, except that the code is now enforcing that the type thrown is a subtype of Throwable as mandated by the JVM spec instead of allowing something like @throws(classOf[String]). Not in this commit: - ScalaDoc support to add the String argument to ScalaDoc's exception list - Adaption of the library
* | Merge pull request #1399 from paulp/210-uncheckedGrzegorz Kossakowski2012-09-2833-34/+528
|\ \ | | | | | | Much better unchecked warnings.
| * | Added logic and tests for unchecked refinements.Paul Phillips2012-09-273-0/+41
| | |
| * | Moved two tests to less breaky locations.Paul Phillips2012-09-274-0/+0
| | | | | | | | | | | | | | | When there is a test called pos/t1107.scala and also a test called pos/t1107, it is bad.
| * | Nailed down the "impossible match" logic.Paul Phillips2012-09-2712-6/+185
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I will again defer to a comment. /** Given classes A and B, can it be shown that nothing which is * an A will ever be a subclass of something which is a B? This * entails not only showing that !(A isSubClass B) but that the * same is true of all their subclasses. Restated for symmetry: * the same value cannot be a member of both A and B. * * 1) A must not be a subclass of B, nor B of A (the trivial check) * 2) One of A or B must be completely knowable (see isKnowable) * 3) Assuming A is knowable, the proposition is true if * !(A' isSubClass B) for all A', where A' is a subclass of A. * * Due to symmetry, the last condition applies as well in reverse. */
| * | Restored warning for impossible type tests.Paul Phillips2012-09-261-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I had this in before, then removed it since it is sometimes redundant with an error message later issued by the pattern matcher (e.g. scrutinee is incompatible with pattern type.) However it also catches a lot of cases which are not errors, so I think the modest redundancy is tolerable for now. I also enhanced the logic for recognizing impossible type tests, taking sealedness into account.
| * | Yet more tests for unchecked warnings.Paul Phillips2012-09-262-1/+75
| | |
| * | Additional new tests for unchecked warnings.Paul Phillips2012-09-259-0/+151
| | |
| * | Improvements to unchecked warnings.Paul Phillips2012-09-256-33/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes SI-6275, SI-5762. The comment says is better than I can. /** On pattern matcher checkability: * * Consider a pattern match of this form: (x: X) match { case _: P => } * * There are four possibilities to consider: * [P1] X will always conform to P * [P2] x will never conform to P * [P3] X <: P if some runtime test is true * [P4] X cannot be checked against P * * The first two cases correspond to those when there is enough static * information to say X <: P or that !(X <: P) for all X and P. * The fourth case includes unknown abstract types or structural * refinements appearing within a pattern. * * The third case is the interesting one. We designate another type, XR, * which is essentially the intersection of X and |P|, where |P| is * the erasure of P. If XR <: P, then no warning is emitted. * * Examples of how this info is put to use: * sealed trait A[T] ; class B[T] extends A[T] * def f(x: B[Int]) = x match { case _: A[Int] if true => } * def g(x: A[Int]) = x match { case _: B[Int] => } * * `f` requires no warning because X=B[Int], P=A[Int], and B[Int] <:< A[Int]. * `g` requires no warning because X=A[Int], P=B[Int], XR=B[Int], and B[Int] <:< B[Int]. * XR=B[Int] because a value of type A[Int] which is tested to be a B can * only be a B[Int], due to the definition of B (B[T] extends A[T].) * * This is something like asSeenFrom, only rather than asking what a type looks * like from the point of view of one of its base classes, we ask what it looks * like from the point of view of one of its subclasses. */
* | | Merge pull request #994 from phaller/issue/5314Grzegorz Kossakowski2012-09-2816-0/+230
|\ \ \ | | | | | | | | SI-5314 - CPS transform of return statement fails (resubmission of #987)
| * | | Simplify the adaptation of types of return expressionsphaller2012-08-124-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `adaptTypeOfReturn` hook to `AnnotationCheckers`. Move adaptation of types of return expressions from `addAnnotations` to `typedReturn` via `adaptTypeOfReturn` hook. This resolves an inconsistency where previously types could have a plus marker without additional CPS annotations. This also adds additional test cases.
| * | | Revert "Add missing cases in tail return transform"phaller2012-08-092-15/+0
| | | | | | | | | | | | | | | | This reverts commit 8d020fab9758ced93eb18fa51c906b95ec104aed.
| * | | Add missing cases in tail return transformphaller2012-08-092-0/+15
| | | | | | | | | | | | | | | | | | | | Disabled warnings that no longer apply because of tail returns. Add several test cases.
| * | | Replace CheckCPSMethodTraverser with additional parameter on transformer methodsphaller2012-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Other fixes: - remove CPSUtils.allCPSMethods - add clarifying comment about adding a plus marker to a return expression