| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
| |
[scaladoc] Add HtmlFactoryTest and reorganize directory structure.
Reviewed by pedrofurla.
|
| |
|
|
|
| |
no review.
|
| |
|
|
|
|
|
| |
Fix for a big bug in lastIndexOfSlice and some latent negative index
bugs in both that and indexOfSlice. This stuff is taxing. Closes #4348,
no review.
|
| | |
|
| |
|
|
|
|
|
| |
I'm going to assume the patch I dropped off five months ago for #3938
was merely overlooked. Fixes an issue with java types which extend inner
classes. Closes #3938, review by odersky.
|
| |
|
|
|
|
|
| |
Prevent a divergent implicit from terminating implicit search, so that
there can still be a winner, as endorsed by martin over a cheese plate.
Closes #3883, review by dmharrah.
|
| |
|
|
|
| |
extempore. References #4305, no review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Removed long deprecated and obscure CloneableCollection. Discovered
we have a scala.collection.mutable.Cloneable which does not extend
java.lang.Cloneable, which is why Array is not considered cloneable.
That seems wrong, but to be conservative I gave Array the Cloneable
interface without altering the scala trait.
Also, if @serializable is deprecated in favor of Serializable,
should not @cloneable be deprecated analogously? Closes #4307, and a
commit-question review by rytz.
|
| |
|
|
|
|
|
| |
infix implicits to Integral and Fractional. As a bonus this patch
knocked 10,000 long boxings off a specialized test. Who knew. Closes
#4308, #4321, review by community.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing toPar* methods, since we've agreed they're difficult to: -
underestand - maintain
Also, changed the docs and some tests appropriately.
Description:
1) Every collection is now parallelizable - switch to the parallel version of the collection is done via `par`.
- Traversable collections and iterators have `par` return a parallel
- collection of type `ParIterable[A]` with the implementation being the
- representative of `ParIterable`s (currently, `ParArray`). Iterable
- collections do the same thing. Sequences refine `par`'s returns type
- to `ParSeq[A]`. Maps and sets do a similar thing.
The above means that the contract for `par` changed - it is no longer guaranteed to be O(1), nor reflect the same underlying data, as was the case for mutable collections before. Method `par` is now at worst linear.
Furthermore, specific collection implementations override `par` to a more efficient alternative - instead of copying the dataset, the dataset is shared between the old and the new version. Implementation complexity may be sublinear or constant in these cases, and the underlying data structure may be shared. Currently, these data structures include parallel arrays, maps and sets, vectors, hash trie maps and sets, and ranges.
Finally, parallel collections implement `par` trivially.
2) Methods `toMap`, `toSet`, `toSeq` and `toIterable` have been refined
for parallel collections to switch between collection types, however,
they never switch an implementation from parallel to sequential. They
may or may not copy the elements, as is the case with sequential
variants of these methods.
3) The preferred way to switch between different collection types,
whether maps, sets and seqs, or parallel and sequential, is now via use
of methods `toIterable`, `toSeq`, `toSet` and `toMap` in combination
with `par` and `seq`.
Review by odersky.
|
| | |
|
| |
|
|
|
| |
Disabled test not actually doing anything anyway, no review.
|
| |
|
|
|
| |
Reenabled the commented out bits of the test for #1642. No review.
|
| |
|
|
|
|
|
|
|
| |
Always forget that checking system properties causes exceptions in
applets and such. Made the system property wrapper wrap its access
checks in some more wrapping. I spent a long time trying to write a
test for the security manager but it's hopeless without knowing all the
details of the test environment. Closes #4346, no review.
|
| |
|
|
|
|
|
|
|
|
|
| |
warnings due to my changing a map from mutable to immutable (which
ought to be the good direction) because "def update" still lingers on
immutable maps. I counted the days elapsed since it was marked for death
(before 2.8.0) and added in the bugliness of what I was looking at and
bid it farewell.
Now removed: def update on immutable maps. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leveraged having a place to put some useful implicits which we sensibly
are reluctant to introduce in the default scope. The test case pretty
much sums it up.
import Ordering.Implicits._
import Numeric.Implicits._
def f1[T: Numeric](x: T, y: T, z: T) = x + y + z
def f2[T: Ordering](x: T, y: T, z: T) = if (x < y) (z > y) else (x < z)
No review.
|
| | |
|
| |
|
|
|
| |
Slight tweak to case class deprecation message, no review.
|
| |
|
|
|
|
|
|
|
|
|
| |
Addresses the issues swirling around Double.Epsilon and friends which
were battled out in more than one venue and then aptly summarized by
retronym in #3791. Thanks to Simon Ochsenreither for submitting a patch;
I wasn't able to use too much of it because the source code for these
types is generated, but effort is always appreciated. Closes #3791, and
I'm tired and I'd hate to blow this one at this late date: review by
rytz.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various chronic annoyances with the repl addressed. Much improved
transcript pasting. Now goes back in time to fix the transcript if it
contains self-referential "res0, res1" etc. so that it works as it
originally did. Shows which commands it is running, and places the
commands with their result in a manner suitable for framing.
Also, a new :paste command which accepts input up to ctrl-D, so you can
enter companions without gyrations, or code from people who write in a
repl unfriendly fashion by putting their curly braces on the next line
(I'm looking at you mark harrah) or you name it, it's not picky.
No review.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Raised the threshold for the test looking at view performance. I guess
if views are only 50x as slow on windows that's still a lot better than
100,000. (The real issue is more like "it's windows" plus "it's windows
running on virtualbox".) No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
A small addition to the library to address something bugging me forever.
It's a light interface to system properties. It's not intended to solve
all property issues for all time, only to greatly improve on the overly
ad-hoc ways things are presently done. Feedback welcome. Sorry it's
coming in this late but it arises from writing the tools to fix the bugs
to allow that release to happen. That's nature's circle of bugs. Review
by community.
|
| |
|
|
|
| |
for pointing me toward the problem. No review.
|
| |
|
|
|
|
|
| |
Fixes the broken test, introduced in the view patch commit.
No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all view classes now list parents like
trait Appended[B >: A] extends super.Appended[B] with Transformed[B]
instead of the former
trait Appended[B >: A] extends Transformed[B] with super.Appended[B]
because as it was, the implementation of foreach in
TraversableViewLike#Transformed was repeatedly trumping overrides found
in e.g. IterableLike. This change was not without its own consequences,
and much of the rest of the patch is dealing with that. A more general
issue is clearly revealed here: there is no straightforward way to deal
with trait composition and overrides when some methods should prefer B
over A and some the reverse. (It's more like A through Z in this case.)
That closes #4279, with some views being five orders of magnitude slower
than necessary. There is a test that confirms they'll stay performance
neighbors.
In the view classes (Zipped, Mapped, etc.) I attended to them with
comb and brush until they were reasonably consistent. I only use
"override" where necessary and throw in some "final" in the interests
of trying to anchor the composition outcome. I also switched the
newSliced, newZipped, etc. methods to use early init syntax since a
number have abstract vals and I found at least one bug originating with
uninitialized access.
There was a piece of a parallel collections scalacheck test failing,
which
I disabled out of expedience - am emailing prokopec.
There is plenty of work left to do but paulp must get back to other 2.9
issues. This is the Zurich->SF airplane patch. No review.
|
| |
|
|
|
|
|
|
| |
Adding special take and drop for numeric ranges, and a test. Parallel
numeric ranges are added, but currently disabled.
Review by extempore.
|
| |
|
|
|
|
| |
One last build break and unbreak so I can be fondly remembered as that
guy who kept breaking the build. No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
An overhaul of slice and related implementations (primarily that is
drop and take.) In the course of trying to get it working consistently
(mostly with respect to negative indices, which were dealt with
arbitrarily differently across the 25+ concrete implementations) I fixed
various bugs.
Closes #4288, no review.
|
| |
|
|
|
|
|
| |
Modify BufferedSource to use a BufferedLineIterator to speed up
line-by-line reads on large files. Updated testfile which used this
class. Closes #4186. Review (of fft.check) by prokopec.
|
| |
|
|
|
|
| |
Made the .opts file in presentation compiler tests be 'platform
independent'. Paths are given in Unix notation. no review.
|
| |
|
|
|
| |
No review.
|
| |
|
|
|
|
|
| |
More signature fixes and tests and generally being more sophisticated
about our primitive squashing. These signatures belong in world-class
museums but we are their shepherds for now. Closes #4317, no review.
|
| |
|
|
|
|
|
| |
Raised the scariness of the case class deprecation message. (I hope
you don't mind, hubert, I like writing scary messages.) Closes #4109 I
suppose, no review.
|
| |
|
|
|
|
| |
More signature work arising from actually looking at the signatures.
Slightly improved the coverage of the tests. No review.
|
| | |
|
| |
|
|
|
|
|
| |
And extempore's original plan carries the day: null.## no longer throws
an NPE. Took advantage of feature to simplify a bunch of sharp-sharp
calculations. Closes #4311, no review.
|
| |
|
|
|
|
|
|
| |
Another corner involving generic signatures and java interop flushed out
by seth tisue. Keep that detector fired up seth or the rebel alliance
will surely be crushed. (In fact, I nominate you to write a test suite!)
Closes #4317, no review.
|
| |
|
|
|
|
|
| |
Re-enabling the disabled signature test along with changes which allow
it to pass. Closes #4238 again, no review. (But would anyone like to
expand the signature tests? Great idea, extempore!)
|
| | |
|
| | |
|
| |
|
|
|
| |
Changed class name from `Main` to `Test` in a failing test case.
|
| |
|
|
|
| |
Review by dragos.
|
| | |
|
| |
|
|
|
|
|
| |
Renamed some methods in icode exception handlers for clarification,
fixed finalizers for 'return' inside a catch block. closes #4240. review
by rytz.
|
