| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
review by prokopec
|
|
|
|
|
|
|
|
|
| |
fixed by having mixin do the cloning at the beginning of erasure and
then updating the symbol's info to transform it to be valid in current
phase
review by odersky
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
note that all type parameters must be reported in error messages about
failing type inference, but only type parameters that were inferred
successfully should be substituted
the idea of mapping type parameter symbols to the corresponding type
ref in order to make substitution the identity does not seem to work,
leading to errors like:
src/library/scala/collection/immutable/SortedMap.scala:38:
error: type mismatch; found :
scala.collection.immutable.SortedMap[A,B(in method empty)]
required: scala.collection.immutable.SortedMap[A,B(in trait
SortedMap)]
override def empty: SortedMap[A, B] = SortedMap.empty
^
(I guess that's why they were retracted before, but that wasn't done consistently, leading to #3152 -- my first attempt at fixing the latter lead to this bug... I've assigned #3152 to you Martin, as I can't decide how to fix it.)
review by odersky
|
|
|
|
|
|
|
| |
this broke the invariant that argss is a regular matrix
review by odersky
|
|
|
|
|
| |
review by odersky
|
|
|
|
|
| |
review by dragos
|
|
|
|
|
|
| |
closes #3247: syntax error regarding context bounds generalized to
include view bounds as we cannot easily be more specific no review
|
|
|
|
|
|
|
|
|
|
| |
this patch introduces a new subclass of TypeTree: TypeTreeWithDeferredRefCheck, which tracks the type args and type params of a type application when it was beta-reduced during typing without checking that the application was well-kinded -- that check must wait until refchecks, but was never performed since the application had been beta-reduced away
caveat discovered while working on the fix: adapt turned all trees for
which _.isType holds into TypeTree's
review by odersky
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes #2331: the pre-transform in Erasure did not correctly recurse in
the case of a TypeApply.
It simply returned the function, which might very well have been, say,
a Select node, which had to be erased in case the qualifier's type is a
refinement.
(sorry about the whitespace changes)
review by odersky
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When compilation fails because of an unimplemented abstract var, give
a more precise error message about what happened. Also avoid issuing
the same error twice because neither getter nor setter is implemented.
Closes #36, review by rytz.
|
|
|
|
|
|
| |
Closes #1766 (structural method dispatch broken in class with multiple
constructors). Review by prokopec.
|
|
|
|
|
|
|
| |
Made a null output sink and applied it to the recently failing test,
which is displaying non-deterministic output by way of the underlying
parser. No review.
|
|
|
|
|
|
|
| |
Some more improvement on the error messages when @tailrec fails. Now it
gives a sensible message if the recursive target is actually a supertype
of this, rather than saying the call is not in tail position. No review.
|
| |
|
|
|
|
|
| |
(That's right, multiple two digit tickets.)
|
|
|
|
|
|
| |
Fail more gracefully on > 22 case class parameters. Closes #3631, no
review.
|
|
|
|
|
|
| |
Fixed an infinite loop in the xml parser on invalid input. Also found an
off by one bug in Source while fixing it. No review.
|
|
|
|
|
|
| |
A crasher in the pattern matcher revealed a flaw in how equality
comparisons were constructed. Closes #3570, no review.
|
|
|
|
|
|
|
|
| |
Test case for #1974, which was fixed at some point even though martin
says in the comments it wouldn't be fixed for 2.8. Take that, things
which think they won't be fixed which really will be. Closes #1974, no
review.
|
| |
|
|
|
|
|
|
| |
Warded off a parser crash on certain invalid programs. Closes #3209, no
review.
|
| |
|
|
|
|
|
| |
Removed a test from pending which is also in files. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly simply by inspecting method signatures (because a Value from
a different Enumeration stored in a val looks identical to one from
this Enumeration) so I have Value store the outer Enum for comparison
purposes. This won't make anything new uncollectable because they
already have an $outer pointing there. This also simplified the
reflection logic: it's an eq test rather than a series of heuristics.
Closes #3616, #3615. Review by phaller.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Moved parallel collections to library dir, changed sabbus script. Added
`par` to some of the classes. No review.
|
| |
|
|
|
|
|
|
|
|
|
| |
The inliner now looks harder for method implementations. In addition
to the receiver, it will find those in directly mixed in traits and
in superclasses. It still won't find those in traits mixed only into
superclasses, as that didn't come quite so easily. Closes #3234 but I'll
be opening up another ticket. Review by dragos.
|
|
|
|
|
|
|
|
| |
A wholesale reversion of the pattern matcher to r21939, motivated by
the appearance of #3578. Closes #3578, reopens #2800, #3050. Review by
moors. (I can't keep saying "no review" when every move I make in here
seems to break something.)
|
| |
|
|
|
|
|
|
| |
removed integration of placeholder syntax and named arguments. review by
odersky
|
|
|
|
|
|
| |
temporarily reversing r22260; will be shortly re-committed in two
separate portions.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Disables NotNull checking unless -Ynotnull is given. Closes #3568,
review by odersky.
|
|
|
|
|
| |
No review.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Made getters treated more like private members when debating whether to
inline. Closes #3420, review by dragos.
|
| |
|
|
|
|
|
|
| |
Further improved combine for hash tries, cutting of another 30ms (160
downto 130). Review by rompf.
|