aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Or <andrew@databricks.com>2015-06-12 11:14:55 -0700
committerAndrew Or <andrew@databricks.com>2015-06-12 11:14:55 -0700
commit88604051511c788d7abb41a49e3eb3a8330c09a9 (patch)
treea28872b33fdfa6d81256aeb53588f24f0d14171e
parent19834fa9184f0365a160bcb54bcd33eaa87c70dc (diff)
downloadspark-88604051511c788d7abb41a49e3eb3a8330c09a9.tar.gz
spark-88604051511c788d7abb41a49e3eb3a8330c09a9.tar.bz2
spark-88604051511c788d7abb41a49e3eb3a8330c09a9.zip
[SPARK-8330] DAG visualization: trim whitespace from input
Safeguard against DOM rewriting. Author: Andrew Or <andrew@databricks.com> Closes #6787 from andrewor14/dag-viz-trim and squashes the following commits: 0fb4afe [Andrew Or] Trim input metadata from DOM
-rw-r--r--core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js5
1 files changed, 3 insertions, 2 deletions
diff --git a/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js b/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
index 7a0dec2a3e..9fa53baaf4 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
@@ -140,7 +140,8 @@ function renderDagViz(forJob) {
// Find cached RDDs and mark them as such
metadataContainer().selectAll(".cached-rdd").each(function(v) {
- var nodeId = VizConstants.nodePrefix + d3.select(this).text();
+ var rddId = d3.select(this).text().trim();
+ var nodeId = VizConstants.nodePrefix + rddId;
svg.selectAll("g." + nodeId).classed("cached", true);
});
@@ -150,7 +151,7 @@ function renderDagViz(forJob) {
/* Render the RDD DAG visualization on the stage page. */
function renderDagVizForStage(svgContainer) {
var metadata = metadataContainer().select(".stage-metadata");
- var dot = metadata.select(".dot-file").text();
+ var dot = metadata.select(".dot-file").text().trim();
var containerId = VizConstants.graphPrefix + metadata.attr("stage-id");
var container = svgContainer.append("g").attr("id", containerId);
renderDot(dot, container, false);