diff options
author | Dongjoon Hyun <dongjoon@apache.org> | 2016-03-27 20:07:31 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2016-03-27 20:07:31 +0100 |
commit | 0f02a5c6e63a95f910e6aba572729ca8085ac3ab (patch) | |
tree | 0e2b233db1482c8ff74737b5cd395ee61fa088d7 | |
parent | cfcca732b403b1af406c2507f3efab928e8b9c6c (diff) | |
download | spark-0f02a5c6e63a95f910e6aba572729ca8085ac3ab.tar.gz spark-0f02a5c6e63a95f910e6aba572729ca8085ac3ab.tar.bz2 spark-0f02a5c6e63a95f910e6aba572729ca8085ac3ab.zip |
[MINOR][MLLIB] Remove TODO comment DecisionTreeModel.scala
## What changes were proposed in this pull request?
This PR fixes the following line and the related code. Historically, this code was added in [SPARK-5597](https://issues.apache.org/jira/browse/SPARK-5597). After [SPARK-5597](https://issues.apache.org/jira/browse/SPARK-5597) was committed, [SPARK-3365](https://issues.apache.org/jira/browse/SPARK-3365) is fixed now. Now, we had better remove the comment without changing persistent code.
```scala
- categories: Seq[Double]) { // TODO: Change to List once SPARK-3365 is fixed
+ categories: Seq[Double]) {
```
## How was this patch tested?
Pass the Jenkins tests.
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes #11966 from dongjoon-hyun/change_categories_type.
-rw-r--r-- | mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala index ea68ff64a8..a87f8a6cde 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala @@ -156,7 +156,7 @@ object DecisionTreeModel extends Loader[DecisionTreeModel] with Logging { feature: Int, threshold: Double, featureType: Int, - categories: Seq[Double]) { // TODO: Change to List once SPARK-3365 is fixed + categories: Seq[Double]) { def toSplit: Split = { new Split(feature, threshold, FeatureType(featureType), categories.toList) } |