diff options
| author | Cheng Lian <lian@databricks.com> | 2015-05-16 20:55:10 +0800 |
|---|---|---|
| committer | Cheng Lian <lian@databricks.com> | 2015-05-16 20:55:17 +0800 |
| commit | ce6391296a061bc352386080a2ee96bb63fcc4ac (patch) | |
| tree | eaeaab67c8889d5d748f0b41dff9668b1a5b6120 | |
| parent | 47e7ffe36b8a8a246fe9af522aff480d19c0c8a6 (diff) | |
| download | spark-ce6391296a061bc352386080a2ee96bb63fcc4ac.tar.gz spark-ce6391296a061bc352386080a2ee96bb63fcc4ac.tar.bz2 spark-ce6391296a061bc352386080a2ee96bb63fcc4ac.zip | |
[HOTFIX] [SQL] Fixes DataFrameWriter.mode(String)
We forgot an assignment there.
/cc rxin
Author: Cheng Lian <lian@databricks.com>
Closes #6212 from liancheng/fix-df-writer and squashes the following commits:
711fbb0 [Cheng Lian] Adds a test case
3b72d78 [Cheng Lian] Fixes DataFrameWriter.mode(String)
| -rw-r--r-- | sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 | ||||
| -rw-r--r-- | sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala index b1fc18ac3c..9f42f0f1f4 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala @@ -55,7 +55,7 @@ final class DataFrameWriter private[sql](df: DataFrame) { * @since 1.4.0 */ def mode(saveMode: String): DataFrameWriter = { - saveMode.toLowerCase match { + this.mode = saveMode.toLowerCase match { case "overwrite" => SaveMode.Overwrite case "append" => SaveMode.Append case "ignore" => SaveMode.Ignore diff --git a/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala index 7a28e9af36..274c652dd1 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala @@ -75,6 +75,13 @@ class SaveLoadSuite extends DataSourceTest with BeforeAndAfterAll { checkLoad() } + test("save with string mode and path, and load") { + conf.setConf(SQLConf.DEFAULT_DATA_SOURCE_NAME, "org.apache.spark.sql.json") + path.createNewFile() + df.write.mode("overwrite").save(path.toString) + checkLoad() + } + test("save with path and datasource, and load") { conf.setConf(SQLConf.DEFAULT_DATA_SOURCE_NAME, "not a source name") df.write.json(path.toString) |