diff options
| author | Xiangrui Meng <meng@databricks.com> | 2015-02-02 17:10:01 -0800 |
|---|---|---|
| committer | Xiangrui Meng <meng@databricks.com> | 2015-02-02 17:10:01 -0800 |
| commit | ef65cf09b04f915ab463a6d3bac12795318897f2 (patch) | |
| tree | 46f2107a0d6787ea07b94aea8cb153067c0eef48 | |
| parent | f133dece569f7faedb06a0da6e9f86c5d615e9be (diff) | |
| download | spark-ef65cf09b04f915ab463a6d3bac12795318897f2.tar.gz spark-ef65cf09b04f915ab463a6d3bac12795318897f2.tar.bz2 spark-ef65cf09b04f915ab463a6d3bac12795318897f2.zip | |
[SPARK-5540] hide ALS.solveLeastSquares
This method survived the code review and it has been there since v1.1.0. It exposes jblas types. Let's remove it from the public API. I think no one calls it directly.
Author: Xiangrui Meng <meng@databricks.com>
Closes #4318 from mengxr/SPARK-5540 and squashes the following commits:
586ade6 [Xiangrui Meng] hide ALS.solveLeastSquares
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala | 2 | ||||
| -rw-r--r-- | project/MimaExcludes.scala | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala index 5f84677be2..a5ffe888ca 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala @@ -615,7 +615,7 @@ class ALS private ( * Given A^T A and A^T b, find the x minimising ||Ax - b||_2, possibly subject * to nonnegativity constraints if `nonnegative` is true. */ - def solveLeastSquares(ata: DoubleMatrix, atb: DoubleMatrix, + private def solveLeastSquares(ata: DoubleMatrix, atb: DoubleMatrix, ws: NNLS.Workspace): Array[Double] = { if (!nonnegative) { Solve.solvePositive(ata, atb).data diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index 45be1db9a5..78de1f0652 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -67,6 +67,10 @@ object MimaExcludes { ProblemFilters.exclude[MissingMethodProblem]( "org.apache.spark.mllib.linalg.Matrix.foreachActive") ) ++ Seq( + // SPARK-5540 + ProblemFilters.exclude[MissingMethodProblem]( + "org.apache.spark.mllib.recommendation.ALS.solveLeastSquares") + ) ++ Seq( // SPARK-3325 ProblemFilters.exclude[MissingMethodProblem]( "org.apache.spark.streaming.api.java.JavaDStreamLike.print"), |