diff options
author | Brennon York <brennon.york@capitalone.com> | 2015-03-24 10:33:04 +0000 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2015-03-24 10:33:04 +0000 |
commit | 37fac1dcd2b0f2845d2952a417fcf85d40351f57 (patch) | |
tree | aaccba9616ca841baf6212d3e9d90eca76c91d3d | |
parent | 1afcf773d0cafdfd9bf106fdc5c429ed2ba3dd36 (diff) | |
download | spark-37fac1dcd2b0f2845d2952a417fcf85d40351f57.tar.gz spark-37fac1dcd2b0f2845d2952a417fcf85d40351f57.tar.bz2 spark-37fac1dcd2b0f2845d2952a417fcf85d40351f57.zip |
[SPARK-6477][Build]: Run MIMA tests before the Spark test suite
This moves the MIMA checks to before the full Spark test suite such that, if new PR's fail the MIMA check, they will return much faster having not run the entire test suite. This is preferable to the current scenario where a user would have to wait until the entire test suite completes before realizing it failed on a MIMA check in which case, once the MIMA issues are fixed, the user would have to resubmit and rerun the full test suite again.
Author: Brennon York <brennon.york@capitalone.com>
Closes #5145 from brennonyork/SPARK-6477 and squashes the following commits:
12b0aee [Brennon York] updated to put the mima checks before the spark test suite
-rwxr-xr-x | dev/run-tests | 18 | ||||
-rw-r--r-- | dev/run-tests-codes.sh | 6 | ||||
-rwxr-xr-x | dev/run-tests-jenkins | 4 |
3 files changed, 14 insertions, 14 deletions
diff --git a/dev/run-tests b/dev/run-tests index d6935a61c6..561d7fc9e7 100755 --- a/dev/run-tests +++ b/dev/run-tests @@ -180,6 +180,15 @@ CURRENT_BLOCK=$BLOCK_BUILD echo "" echo "=========================================================================" +echo "Detecting binary incompatibilities with MiMa" +echo "=========================================================================" + +CURRENT_BLOCK=$BLOCK_MIMA + +./dev/mima + +echo "" +echo "=========================================================================" echo "Running Spark unit tests" echo "=========================================================================" @@ -227,12 +236,3 @@ echo "=========================================================================" CURRENT_BLOCK=$BLOCK_PYSPARK_UNIT_TESTS ./python/run-tests - -echo "" -echo "=========================================================================" -echo "Detecting binary incompatibilities with MiMa" -echo "=========================================================================" - -CURRENT_BLOCK=$BLOCK_MIMA - -./dev/mima diff --git a/dev/run-tests-codes.sh b/dev/run-tests-codes.sh index 1348e0609d..8ab6db6925 100644 --- a/dev/run-tests-codes.sh +++ b/dev/run-tests-codes.sh @@ -22,6 +22,6 @@ readonly BLOCK_RAT=11 readonly BLOCK_SCALA_STYLE=12 readonly BLOCK_PYTHON_STYLE=13 readonly BLOCK_BUILD=14 -readonly BLOCK_SPARK_UNIT_TESTS=15 -readonly BLOCK_PYSPARK_UNIT_TESTS=16 -readonly BLOCK_MIMA=17 +readonly BLOCK_MIMA=15 +readonly BLOCK_SPARK_UNIT_TESTS=16 +readonly BLOCK_PYSPARK_UNIT_TESTS=17 diff --git a/dev/run-tests-jenkins b/dev/run-tests-jenkins index 5f4000e839..3a937b637e 100755 --- a/dev/run-tests-jenkins +++ b/dev/run-tests-jenkins @@ -199,12 +199,12 @@ done failing_test="Python style tests" elif [ "$test_result" -eq "$BLOCK_BUILD" ]; then failing_test="to build" + elif [ "$test_result" -eq "$BLOCK_MIMA" ]; then + failing_test="MiMa tests" elif [ "$test_result" -eq "$BLOCK_SPARK_UNIT_TESTS" ]; then failing_test="Spark unit tests" elif [ "$test_result" -eq "$BLOCK_PYSPARK_UNIT_TESTS" ]; then failing_test="PySpark unit tests" - elif [ "$test_result" -eq "$BLOCK_MIMA" ]; then - failing_test="MiMa tests" else failing_test="some tests" fi |