aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhyukjinkwon <gurwls223@gmail.com>2016-09-18 19:18:49 +0100
committerSean Owen <sowen@cloudera.com>2016-09-18 19:18:49 +0100
commit7151011b38a841d9d4bc2e453b9a7cfe42f74f8f (patch)
tree5dd9f9ee57277283b8f42a9683fe2cd70c17460a
parent342c0e65bec4b9a715017089ab6ea127f3c46540 (diff)
downloadspark-7151011b38a841d9d4bc2e453b9a7cfe42f74f8f.tar.gz
spark-7151011b38a841d9d4bc2e453b9a7cfe42f74f8f.tar.bz2
spark-7151011b38a841d9d4bc2e453b9a7cfe42f74f8f.zip
[SPARK-17586][BUILD] Do not call static member via instance reference
## What changes were proposed in this pull request? This PR fixes a warning message as below: ``` [WARNING] .../UnsafeInMemorySorter.java:284: warning: [static] static method should be qualified by type name, TaskMemoryManager, instead of by an expression [WARNING] currentPageNumber = memoryManager.decodePageNumber(recordPointer) ``` by referencing the static member via class not instance reference. ## How was this patch tested? Existing tests should cover this - Jenkins tests. Author: hyukjinkwon <gurwls223@gmail.com> Closes #15141 from HyukjinKwon/SPARK-17586.
-rw-r--r--core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
index be382955c0..3b1ece4373 100644
--- a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
+++ b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
@@ -281,7 +281,7 @@ public final class UnsafeInMemorySorter {
public void loadNext() {
// This pointer points to a 4-byte record length, followed by the record's bytes
final long recordPointer = array.get(offset + position);
- currentPageNumber = memoryManager.decodePageNumber(recordPointer);
+ currentPageNumber = TaskMemoryManager.decodePageNumber(recordPointer);
baseObject = memoryManager.getPage(recordPointer);
baseOffset = memoryManager.getOffsetInPage(recordPointer) + 4; // Skip over record length
recordLength = Platform.getInt(baseObject, baseOffset - 4);