diff options
author | Reynold Xin <reynoldx@gmail.com> | 2013-09-21 22:42:46 -0700 |
---|---|---|
committer | Reynold Xin <reynoldx@gmail.com> | 2013-09-21 22:42:46 -0700 |
commit | 7bb12a2af3245db938f1b46382a3e12c4e18c53d (patch) | |
tree | 5a851e2f1ae8976eda78e02dc72f3a18412c73b8 | |
parent | cd7222c3dd2211ce790fa52110db911b862bb63b (diff) | |
parent | 026dba6abaaf6314a79ce873bb38b73a9b7fd1a7 (diff) | |
download | spark-7bb12a2af3245db938f1b46382a3e12c4e18c53d.tar.gz spark-7bb12a2af3245db938f1b46382a3e12c4e18c53d.tar.bz2 spark-7bb12a2af3245db938f1b46382a3e12c4e18c53d.zip |
Merge pull request #940 from ankurdave/clear-port-properties-after-tests
After unit tests, clear port properties unconditionally
-rw-r--r-- | core/src/test/scala/org/apache/spark/LocalSparkContext.scala | 10 | ||||
-rw-r--r-- | core/src/test/scala/org/apache/spark/SharedSparkContext.scala | 6 |
2 files changed, 7 insertions, 9 deletions
diff --git a/core/src/test/scala/org/apache/spark/LocalSparkContext.scala b/core/src/test/scala/org/apache/spark/LocalSparkContext.scala index 6ec124da9c..459e257d79 100644 --- a/core/src/test/scala/org/apache/spark/LocalSparkContext.scala +++ b/core/src/test/scala/org/apache/spark/LocalSparkContext.scala @@ -40,17 +40,17 @@ trait LocalSparkContext extends BeforeAndAfterEach with BeforeAndAfterAll { self } def resetSparkContext() = { - if (sc != null) { - LocalSparkContext.stop(sc) - sc = null - } + LocalSparkContext.stop(sc) + sc = null } } object LocalSparkContext { def stop(sc: SparkContext) { - sc.stop() + if (sc != null) { + sc.stop() + } // To avoid Akka rebinding to the same port, since it doesn't unbind immediately on shutdown System.clearProperty("spark.driver.port") System.clearProperty("spark.hostPort") diff --git a/core/src/test/scala/org/apache/spark/SharedSparkContext.scala b/core/src/test/scala/org/apache/spark/SharedSparkContext.scala index 97cbca09bf..288aa14eeb 100644 --- a/core/src/test/scala/org/apache/spark/SharedSparkContext.scala +++ b/core/src/test/scala/org/apache/spark/SharedSparkContext.scala @@ -33,10 +33,8 @@ trait SharedSparkContext extends BeforeAndAfterAll { self: Suite => } override def afterAll() { - if (_sc != null) { - LocalSparkContext.stop(_sc) - _sc = null - } + LocalSparkContext.stop(_sc) + _sc = null super.afterAll() } } |