diff options
author | zsxwing <zsxwing@gmail.com> | 2014-04-23 14:12:20 -0700 |
---|---|---|
committer | Reynold Xin <rxin@apache.org> | 2014-04-23 14:12:20 -0700 |
commit | a66460661303bd652b5c5d32860216cc3ceb7f98 (patch) | |
tree | a7ae0787ea78eda0c6df8420432ba3882009304a | |
parent | cd4ed293262e2349794c13467d1737974385c019 (diff) | |
download | spark-a66460661303bd652b5c5d32860216cc3ceb7f98.tar.gz spark-a66460661303bd652b5c5d32860216cc3ceb7f98.tar.bz2 spark-a66460661303bd652b5c5d32860216cc3ceb7f98.zip |
SPARK-1583: Fix a bug that using java.util.HashMap by mistake
JIRA: https://issues.apache.org/jira/browse/SPARK-1583
Does anyone know why using `java.util.HashMap` rather than `mutable.HashMap`? Some methods of `java.util.HashMap` are not generics and compiler can not help us find similar problems.
Author: zsxwing <zsxwing@gmail.com>
Closes #500 from zsxwing/SPARK-1583 and squashes the following commits:
7bfd74d [zsxwing] SPARK-1583: Fix a bug that using java.util.HashMap by mistake
-rw-r--r-- | core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala b/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala index c57b6e8391..63fa5d3eb6 100644 --- a/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala +++ b/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala @@ -203,7 +203,7 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf, listenerBus val locations = blockLocations.get(blockId) locations -= blockManagerId if (locations.size == 0) { - blockLocations.remove(locations) + blockLocations.remove(blockId) } } listenerBus.post(SparkListenerBlockManagerRemoved(blockManagerId)) |