diff options
| author | Reynold Xin <rxin@databricks.com> | 2015-05-30 23:36:32 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2015-05-30 23:36:37 -0700 |
| commit | adfc9d1fa0eee008d3c05a6c44526c3c9b6558d0 (patch) | |
| tree | 550acb703422b38f65bec8511eb5dabbb2b01ebd | |
| parent | 5e268d3956b408dc961f1cbb8a13126612e9773b (diff) | |
| download | spark-adfc9d1fa0eee008d3c05a6c44526c3c9b6558d0.tar.gz spark-adfc9d1fa0eee008d3c05a6c44526c3c9b6558d0.tar.bz2 spark-adfc9d1fa0eee008d3c05a6c44526c3c9b6558d0.zip | |
[SPARK-7976] Add style checker to disallow overriding finalize.
Author: Reynold Xin <rxin@databricks.com>
Closes #6528 from rxin/style-finalizer and squashes the following commits:
a2211ca [Reynold Xin] [SPARK-7976] Enable NoFinalizeChecker.
(cherry picked from commit 084fef76e90116c6465cd6fad7c0197c3e4d4313)
Signed-off-by: Reynold Xin <rxin@databricks.com>
| -rw-r--r-- | core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala | 2 | ||||
| -rw-r--r-- | scalastyle-config.xml | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala b/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala index a77bf42ce1..51388f01a3 100644 --- a/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala +++ b/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala @@ -843,6 +843,7 @@ private class PythonAccumulatorParam(@transient serverHost: String, serverPort: * An Wrapper for Python Broadcast, which is written into disk by Python. It also will * write the data into disk after deserialization, then Python can read it from disks. */ +// scalastyle:off no.finalize private[spark] class PythonBroadcast(@transient var path: String) extends Serializable { /** @@ -884,3 +885,4 @@ private[spark] class PythonBroadcast(@transient var path: String) extends Serial } } } +// scalastyle:on no.finalize diff --git a/scalastyle-config.xml b/scalastyle-config.xml index 68c8ce3b7e..6e27035a38 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -96,7 +96,7 @@ <!-- <check level="error" class="org.scalastyle.scalariform.ReturnChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NullChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NoCloneChecker" enabled="true"></check> --> - <!-- <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check> --> + <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check> <!-- <check level="error" class="org.scalastyle.scalariform.CovariantEqualsChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.StructuralTypeChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> --> |