aboutsummaryrefslogtreecommitdiff
path: root/R/install-dev.sh
diff options
context:
space:
mode:
authorXin Ren <iamshrek@126.com>2016-05-26 21:25:13 -0500
committerSean Owen <sowen@cloudera.com>2016-05-26 21:25:13 -0500
commit6ab973ec51f3db72de1766ad8d8316b7a58ed0a0 (patch)
tree3a3c7fbdf749b85a3f707b6df19dcde33b5ad7a5 /R/install-dev.sh
parent008a5377d57ce6692eca4a41539fb27978b58e01 (diff)
downloadspark-6ab973ec51f3db72de1766ad8d8316b7a58ed0a0.tar.gz
spark-6ab973ec51f3db72de1766ad8d8316b7a58ed0a0.tar.bz2
spark-6ab973ec51f3db72de1766ad8d8316b7a58ed0a0.zip
[SPARK-15542][SPARKR] Make error message clear for script './R/install-dev.sh' when R is missing on Mac
https://issues.apache.org/jira/browse/SPARK-15542 ## What changes were proposed in this pull request? When running`./R/install-dev.sh` in **Mac OS EI Captain** environment, I got ``` mbp185-xr:spark xin$ ./R/install-dev.sh usage: dirname path ``` This message is very confusing to me, and then I found R is not properly configured on my Mac when this script is using `$(which R)` to get R home. I tried similar situation on CentOS with R missing, and it's giving me very clear error message while MacOS is not. on CentOS: ``` [rootip-xxx-31-9-xx spark]# which R /usr/bin/which: no R in (/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/lib/jvm/java-1.7.0-openjdk.x86_64/bin:/root/bin) ``` but on Mac, if not found then nothing returned and this is causing the confusing message for R build failure and running R/install-dev.sh: ``` mbp185-xr:spark xin$ which R mbp185-xr:spark xin$ ``` Here I just added a clear message for this miss configuration for R when running `R/install-dev.sh`. ``` mbp185-xr:spark xin$ ./R/install-dev.sh Cannot find R home by running 'which R', please make sure R is properly installed. ``` ## How was this patch tested? Manually tested on local machine. Author: Xin Ren <iamshrek@126.com> Closes #13308 from keypointt/SPARK-15542.
Diffstat (limited to 'R/install-dev.sh')
-rwxr-xr-xR/install-dev.sh7
1 files changed, 6 insertions, 1 deletions
diff --git a/R/install-dev.sh b/R/install-dev.sh
index befd413c4c..ada6303a72 100755
--- a/R/install-dev.sh
+++ b/R/install-dev.sh
@@ -38,7 +38,12 @@ pushd $FWDIR > /dev/null
if [ ! -z "$R_HOME" ]
then
R_SCRIPT_PATH="$R_HOME/bin"
- else
+ else
+ # if system wide R_HOME is not found, then exit
+ if [ ! `command -v R` ]; then
+ echo "Cannot find 'R_HOME'. Please specify 'R_HOME' or make sure R is properly installed."
+ exit 1
+ fi
R_SCRIPT_PATH="$(dirname $(which R))"
fi
echo "USING R_HOME = $R_HOME"