diff options
| author | Josh Rosen <joshrosen@databricks.com> | 2015-12-28 10:40:03 -0800 |
|---|---|---|
| committer | Josh Rosen <joshrosen@databricks.com> | 2015-12-28 10:40:03 -0800 |
| commit | ab6bedd85dc29906ac2f175f603ae3b43ab03535 (patch) | |
| tree | 31188e5e122671722dbf11ab935456bc80f85938 /R | |
| parent | 8e23d8db7f28a97e2f4394cdf9d4c4260abbd750 (diff) | |
| download | spark-ab6bedd85dc29906ac2f175f603ae3b43ab03535.tar.gz spark-ab6bedd85dc29906ac2f175f603ae3b43ab03535.tar.bz2 spark-ab6bedd85dc29906ac2f175f603ae3b43ab03535.zip | |
[SPARK-12508][PROJECT-INFRA] Fix minor bugs in dev/tests/pr_public_classes.sh script
This patch fixes a handful of minor bugs in the `dev/tests/pr_public_classes.sh` script, which is used by the `run_tests_jenkins` script to detect the addition of new public classes:
- Account for differences between BSD and GNU `sed` in order to allow the script to run on OS X.
- Diff `$ghprbActualCommit^...$ghprbActualCommit ` instead of `master...$ghprbActualCommit`: since `ghprbActualCommit` is a merge commit which results from merging the PR into the target branch, this will give us the desired diff and will avoid certain race-conditions which could lead to false-positives.
- Use `echo -e` instead of `echo` so that newline characters are handled correctly in output. This should fix a formatting glitch which caused the output to appear on a single line in the GitHub comment (see [the SC2028 page](https://github.com/koalaman/shellcheck/wiki/SC2028) on the Shellcheck wiki for more details).
Author: Josh Rosen <joshrosen@databricks.com>
Closes #10455 from JoshRosen/fix-pr-public-classes-test.
Diffstat (limited to 'R')
0 files changed, 0 insertions, 0 deletions