diff options
| author | petermaxlee <petermaxlee@gmail.com> | 2016-09-18 15:22:01 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2016-09-18 15:22:01 -0700 |
| commit | 8f0c35a4d0dd458719627be5f524792bf244d70a (patch) | |
| tree | 5f953e797c1c75d192df4178952f8ad90dc6d0d7 /R | |
| parent | 1dbb725dbef30bf7633584ce8efdb573f2d92bca (diff) | |
| download | spark-8f0c35a4d0dd458719627be5f524792bf244d70a.tar.gz spark-8f0c35a4d0dd458719627be5f524792bf244d70a.tar.bz2 spark-8f0c35a4d0dd458719627be5f524792bf244d70a.zip | |
[SPARK-17571][SQL] AssertOnQuery.condition should always return Boolean value
## What changes were proposed in this pull request?
AssertOnQuery has two apply constructor: one that accepts a closure that returns boolean, and another that accepts a closure that returns Unit. This is actually very confusing because developers could mistakenly think that AssertOnQuery always require a boolean return type and verifies the return result, when indeed the value of the last statement is ignored in one of the constructors.
This pull request makes the two constructor consistent and always require boolean value. It will overall make the test suites more robust against developer errors.
As an evidence for the confusing behavior, this change also identified a bug with an existing test case due to file system time granularity. This pull request fixes that test case as well.
## How was this patch tested?
This is a test only change.
Author: petermaxlee <petermaxlee@gmail.com>
Closes #15127 from petermaxlee/SPARK-17571.
Diffstat (limited to 'R')
0 files changed, 0 insertions, 0 deletions