diff options
| author | Joseph K. Bradley <joseph@databricks.com> | 2015-08-12 10:48:52 -0700 |
|---|---|---|
| committer | Xiangrui Meng <meng@databricks.com> | 2015-08-12 10:50:11 -0700 |
| commit | b515f890defe96149e56580e8ed2c00febf7dc8e (patch) | |
| tree | cdae6ef81a1416b7bd5c24c403935839e330795d /bagel | |
| parent | e9641f192dc6a949cfb8fa1614d446026c7bf4b3 (diff) | |
| download | spark-b515f890defe96149e56580e8ed2c00febf7dc8e.tar.gz spark-b515f890defe96149e56580e8ed2c00febf7dc8e.tar.bz2 spark-b515f890defe96149e56580e8ed2c00febf7dc8e.zip | |
[SPARK-9847] [ML] Modified copyValues to distinguish between default, explicit param values
From JIRA: Currently, Params.copyValues copies default parameter values to the paramMap of the target instance, rather than the defaultParamMap. It should copy to the defaultParamMap because explicitly setting a parameter can change the semantics.
This issue arose in SPARK-9789, where 2 params "threshold" and "thresholds" for LogisticRegression can have mutually exclusive values. If thresholds is set, then fit() will copy the default value of threshold as well, easily resulting in inconsistent settings for the 2 params.
CC: mengxr
Author: Joseph K. Bradley <joseph@databricks.com>
Closes #8115 from jkbradley/copyvalues-fix.
(cherry picked from commit 70fe558867ccb4bcff6ec673438b03608bb02252)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
Diffstat (limited to 'bagel')
0 files changed, 0 insertions, 0 deletions