diff options
author | Reynold Xin <rxin@apache.org> | 2013-10-14 14:20:01 -0700 |
---|---|---|
committer | Reynold Xin <rxin@apache.org> | 2013-10-14 14:20:01 -0700 |
commit | 3b11f43e36e2aca2346db7542c52fcbbeee70da2 (patch) | |
tree | 847214037325bbd674ab0a0f4b81aeb8c89f3578 /bin | |
parent | 99796904ae9d00405584ac518b6144973a876e3c (diff) | |
parent | 4a45019fb0458b5f943253c0c16c9e257ef2c129 (diff) | |
download | spark-3b11f43e36e2aca2346db7542c52fcbbeee70da2.tar.gz spark-3b11f43e36e2aca2346db7542c52fcbbeee70da2.tar.bz2 spark-3b11f43e36e2aca2346db7542c52fcbbeee70da2.zip |
Merge pull request #57 from aarondav/bid
Refactor BlockId into an actual type
Converts all of our BlockId strings into actual BlockId types. Here are some advantages of doing this now:
+ Type safety
+ Code clarity - it's now obvious what the key of a shuffle or rdd block is, for instance. Additionally, appearing in tuple/map type signatures is a big readability bonus. A Seq[(String, BlockStatus)] is not very clear. Further, we can now use more Scala features, like matching on BlockId types.
+ Explicit usage - we can now formally tell where various BlockIds are being used (without doing string searches); this makes updating current BlockIds a much clearer process, and compiler-supported.
(I'm looking at you, shuffle file consolidation.)
+ It will only get harder to make this change as time goes on.
Downside is, of course, that this is a very invasive change touching a lot of different files, which will inevitably lead to merge conflicts for many.
Diffstat (limited to 'bin')
0 files changed, 0 insertions, 0 deletions