diff options
| author | Sean Owen <sowen@cloudera.com> | 2016-03-03 09:54:09 +0000 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-03-03 09:54:09 +0000 |
| commit | e97fc7f176f8bf501c9b3afd8410014e3b0e1602 (patch) | |
| tree | 23a11a3646b13195aaf50078a0f35fad96190618 /checkstyle.xml | |
| parent | 02b7677e9584f5ccd68869abdb0bf980dc847ce1 (diff) | |
| download | spark-e97fc7f176f8bf501c9b3afd8410014e3b0e1602.tar.gz spark-e97fc7f176f8bf501c9b3afd8410014e3b0e1602.tar.bz2 spark-e97fc7f176f8bf501c9b3afd8410014e3b0e1602.zip | |
[SPARK-13423][WIP][CORE][SQL][STREAMING] Static analysis fixes for 2.x
## What changes were proposed in this pull request?
Make some cross-cutting code improvements according to static analysis. These are individually up for discussion since they exist in separate commits that can be reverted. The changes are broadly:
- Inner class should be static
- Mismatched hashCode/equals
- Overflow in compareTo
- Unchecked warnings
- Misuse of assert, vs junit.assert
- get(a) + getOrElse(b) -> getOrElse(a,b)
- Array/String .size -> .length (occasionally, -> .isEmpty / .nonEmpty) to avoid implicit conversions
- Dead code
- tailrec
- exists(_ == ) -> contains find + nonEmpty -> exists filter + size -> count
- reduce(_+_) -> sum map + flatten -> map
The most controversial may be .size -> .length simply because of its size. It is intended to avoid implicits that might be expensive in some places.
## How was the this patch tested?
Existing Jenkins unit tests.
Author: Sean Owen <sowen@cloudera.com>
Closes #11292 from srowen/SPARK-13423.
Diffstat (limited to 'checkstyle.xml')
0 files changed, 0 insertions, 0 deletions