diff options
| author | Dongjoon Hyun <dongjoon@apache.org> | 2016-03-09 10:12:23 +0000 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-03-09 10:12:23 +0000 |
| commit | f3201aeeb06aae3b11e8cf6ee9693182dd896b32 (patch) | |
| tree | 1c78b5e1218f3c851743914f1e2444ce59549217 /common/unsafe | |
| parent | 035d3acdf3c1be5b309a861d5c5beb803b946b5e (diff) | |
| download | spark-f3201aeeb06aae3b11e8cf6ee9693182dd896b32.tar.gz spark-f3201aeeb06aae3b11e8cf6ee9693182dd896b32.tar.bz2 spark-f3201aeeb06aae3b11e8cf6ee9693182dd896b32.zip | |
[SPARK-13692][CORE][SQL] Fix trivial Coverity/Checkstyle defects
## What changes were proposed in this pull request?
This issue fixes the following potential bugs and Java coding style detected by Coverity and Checkstyle.
- Implement both null and type checking in equals functions.
- Fix wrong type casting logic in SimpleJavaBean2.equals.
- Add `implement Cloneable` to `UTF8String` and `SortedIterator`.
- Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`.
- Fix coding style: Add '{}' to single `for` statement in mllib examples.
- Remove unused imports in `ColumnarBatch` and `JavaKinesisStreamSuite`.
- Remove unused fields in `ChunkFetchIntegrationSuite`.
- Add `stop()` to prevent resource leak.
Please note that the last two checkstyle errors exist on newly added commits after [SPARK-13583](https://issues.apache.org/jira/browse/SPARK-13583).
## How was this patch tested?
manual via `./dev/lint-java` and Coverity site.
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes #11530 from dongjoon-hyun/SPARK-13692.
Diffstat (limited to 'common/unsafe')
| -rw-r--r-- | common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java b/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java index 87706d0b68..427a8315e0 100644 --- a/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java +++ b/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java @@ -44,7 +44,8 @@ import static org.apache.spark.unsafe.Platform.*; * <p> * Note: This is not designed for general use cases, should not be used outside SQL. */ -public final class UTF8String implements Comparable<UTF8String>, Externalizable, KryoSerializable { +public final class UTF8String implements Comparable<UTF8String>, Externalizable, KryoSerializable, + Cloneable { // These are only updated by readExternal() or read() @Nonnull |