diff options
author | Xin Ren <iamshrek@126.com> | 2016-07-19 11:59:46 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2016-07-19 11:59:46 +0100 |
commit | 21a6dd2aef65a23d92f93c43fa731c0505250363 (patch) | |
tree | 8a5590b9b3200a2263d2279ba3e0d0350b48a198 /common | |
parent | 556a9437ac7b55079f5a8a91e669dcc36ca02696 (diff) | |
download | spark-21a6dd2aef65a23d92f93c43fa731c0505250363.tar.gz spark-21a6dd2aef65a23d92f93c43fa731c0505250363.tar.bz2 spark-21a6dd2aef65a23d92f93c43fa731c0505250363.zip |
[SPARK-16535][BUILD] In pom.xml, remove groupId which is redundant definition and inherited from the parent
https://issues.apache.org/jira/browse/SPARK-16535
## What changes were proposed in this pull request?
When I scan through the pom.xml of sub projects, I found this warning as below and attached screenshot
```
Definition of groupId is redundant, because it's inherited from the parent
```
![screen shot 2016-07-13 at 3 13 11 pm](https://cloud.githubusercontent.com/assets/3925641/16823121/744f893e-4916-11e6-8a52-042f83b9db4e.png)
I've tried to remove some of the lines with groupId definition, and the build on my local machine is still ok.
```
<groupId>org.apache.spark</groupId>
```
As I just find now `<maven.version>3.3.9</maven.version>` is being used in Spark 2.x, and Maven-3 supports versionless parent elements: Maven 3 will remove the need to specify the parent version in sub modules. THIS is great (in Maven 3.1).
ref: http://stackoverflow.com/questions/3157240/maven-3-worth-it/3166762#3166762
## How was this patch tested?
I've tested by re-building the project, and build succeeded.
Author: Xin Ren <iamshrek@126.com>
Closes #14189 from keypointt/SPARK-16535.
Diffstat (limited to 'common')
-rw-r--r-- | common/network-common/pom.xml | 1 | ||||
-rw-r--r-- | common/network-shuffle/pom.xml | 1 | ||||
-rw-r--r-- | common/network-yarn/pom.xml | 1 | ||||
-rw-r--r-- | common/sketch/pom.xml | 1 | ||||
-rw-r--r-- | common/tags/pom.xml | 1 | ||||
-rw-r--r-- | common/unsafe/pom.xml | 1 |
6 files changed, 0 insertions, 6 deletions
diff --git a/common/network-common/pom.xml b/common/network-common/pom.xml index b1a37e8472..81f0c6e226 100644 --- a/common/network-common/pom.xml +++ b/common/network-common/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-network-common_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Networking</name> diff --git a/common/network-shuffle/pom.xml b/common/network-shuffle/pom.xml index 51c06b9e5a..d211bd5bd1 100644 --- a/common/network-shuffle/pom.xml +++ b/common/network-shuffle/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-network-shuffle_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Shuffle Streaming Service</name> diff --git a/common/network-yarn/pom.xml b/common/network-yarn/pom.xml index d43eb71aa5..606ad15739 100644 --- a/common/network-yarn/pom.xml +++ b/common/network-yarn/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-network-yarn_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project YARN Shuffle Service</name> diff --git a/common/sketch/pom.xml b/common/sketch/pom.xml index 6f2fdd538f..626f023a5b 100644 --- a/common/sketch/pom.xml +++ b/common/sketch/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-sketch_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Sketch</name> diff --git a/common/tags/pom.xml b/common/tags/pom.xml index 842a1c80e0..1c60d510e5 100644 --- a/common/tags/pom.xml +++ b/common/tags/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-tags_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Tags</name> diff --git a/common/unsafe/pom.xml b/common/unsafe/pom.xml index 08af461f19..45af98d94e 100644 --- a/common/unsafe/pom.xml +++ b/common/unsafe/pom.xml @@ -26,7 +26,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-unsafe_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Unsafe</name> |