aboutsummaryrefslogtreecommitdiff
path: root/conf
diff options
context:
space:
mode:
authorAaron Davidson <aaron@databricks.com>2013-10-12 12:18:23 -0700
committerAaron Davidson <aaron@databricks.com>2013-10-12 22:44:57 -0700
commita3959111387ae955c63284b389cc888cbd19e399 (patch)
tree1b17b4b4a87a8ac6d50c299dfe3a5b82ddb4d3d5 /conf
parentdca80094d317363e1e0d7e32bc7dfd99faf943cf (diff)
downloadspark-a3959111387ae955c63284b389cc888cbd19e399.tar.gz
spark-a3959111387ae955c63284b389cc888cbd19e399.tar.bz2
spark-a3959111387ae955c63284b389cc888cbd19e399.zip
Refactor BlockId into an actual type
This is an unfortunately invasive change which converts all of our BlockId strings into actual BlockId types. Here are some advantages of doing this now: + Type safety + Code clarity - it's now obvious what the key of a shuffle or rdd block is, for instance. Additionally, appearing in tuple/map type signatures is a big readability bonus. A Seq[(String, BlockStatus)] is not very clear. Further, we can now use more Scala features, like matching on BlockId types. + Explicit usage - we can now formally tell where various BlockIds are being used (without doing string searches); this makes updating current BlockIds a much clearer process, and compiler-supported. (I'm looking at you, shuffle file consolidation.) + It will only get harder to make this change as time goes on. Since this touches a lot of files, it'd be best to either get this patch in quickly or throw it on the ground to avoid too many secondary merge conflicts.
Diffstat (limited to 'conf')
0 files changed, 0 insertions, 0 deletions