diff options
| author | WangTaoTheTonic <wangtao111@huawei.com> | 2016-11-14 12:22:36 +0100 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-11-14 12:22:36 +0100 |
| commit | 637a0bb88f74712001f32a53ff66fd0b8cb67e4a (patch) | |
| tree | 9b6a47d798202cecc19755ec2b405adf609bd20f /core/src/main/resources | |
| parent | ae6cddb78742be94aa0851ce719f293e0a64ce4f (diff) | |
| download | spark-637a0bb88f74712001f32a53ff66fd0b8cb67e4a.tar.gz spark-637a0bb88f74712001f32a53ff66fd0b8cb67e4a.tar.bz2 spark-637a0bb88f74712001f32a53ff66fd0b8cb67e4a.zip | |
[SPARK-18396][HISTORYSERVER] Duration" column makes search result confused, maybe we should make it unsearchable
## What changes were proposed in this pull request?
When we search data in History Server, it will check if any columns contains the search string. Duration is represented as long value in table, so if we search simple string like "003", "111", the duration containing "003", ‘111“ will be showed, which make not much sense to users.
We cannot simply transfer the long value to meaning format like "1 h", "3.2 min" because they are also used for sorting. Better way to handle it is ban "Duration" columns from searching.
## How was this patch tested
manually tests.
Before("local-1478225166651" pass the filter because its duration in long value, which is "257244245" contains search string "244"):
After:
Author: WangTaoTheTonic <wangtao111@huawei.com>
Closes #15838 from WangTaoTheTonic/duration.
Diffstat (limited to 'core/src/main/resources')
| -rw-r--r-- | core/src/main/resources/org/apache/spark/ui/static/historypage.js | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/core/src/main/resources/org/apache/spark/ui/static/historypage.js b/core/src/main/resources/org/apache/spark/ui/static/historypage.js index 6c0ec8d5fc..8fd91865b0 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/historypage.js +++ b/core/src/main/resources/org/apache/spark/ui/static/historypage.js @@ -139,6 +139,9 @@ $(document).ready(function() { {name: 'eighth'}, {name: 'ninth'}, ], + "columnDefs": [ + {"searchable": false, "targets": [5]} + ], "autoWidth": false, "order": [[ 4, "desc" ]] }; |