diff options
| author | Dongjoon Hyun <dongjoon@apache.org> | 2016-04-24 20:40:03 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2016-04-24 20:40:03 -0700 |
| commit | d34d6503786bbe429c10ddb1879519cc9bd709b6 (patch) | |
| tree | 885752ae5137e5a2f87dd8802c2e789ea271ee77 /core/src/main/scala/org/apache/spark | |
| parent | d0ca5797a8fc55a3046cdfad8860ba3a29f72b51 (diff) | |
| download | spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.tar.gz spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.tar.bz2 spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.zip | |
[SPARK-14868][BUILD] Enable NewLineAtEofChecker in checkstyle and fix lint-java errors
## What changes were proposed in this pull request?
Spark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most Java code also comply with the rule. This PR aims to enforce the same rule `NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java errors since SPARK-14465. The followings are the items.
- Adds a new line at the end of the files (19 files)
- Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2 LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder)
## How was this patch tested?
After the Jenkins test succeeds, `dev/lint-java` should pass. (Currently, Jenkins dose not run lint-java.)
```bash
$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.
```
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes #12632 from dongjoon-hyun/SPARK-14868.
Diffstat (limited to 'core/src/main/scala/org/apache/spark')
9 files changed, 9 insertions, 9 deletions
diff --git a/core/src/main/scala/org/apache/spark/annotation/package-info.java b/core/src/main/scala/org/apache/spark/annotation/package-info.java index 12c7afe6f1..9efdccf6b0 100644 --- a/core/src/main/scala/org/apache/spark/annotation/package-info.java +++ b/core/src/main/scala/org/apache/spark/annotation/package-info.java @@ -20,4 +20,4 @@ * This package consist of these annotations, which are used project wide and are reflected in * Scala and Java docs. */ -package org.apache.spark.annotation;
\ No newline at end of file +package org.apache.spark.annotation; diff --git a/core/src/main/scala/org/apache/spark/api/java/package-info.java b/core/src/main/scala/org/apache/spark/api/java/package-info.java index 10a480fc78..699181cafa 100644 --- a/core/src/main/scala/org/apache/spark/api/java/package-info.java +++ b/core/src/main/scala/org/apache/spark/api/java/package-info.java @@ -18,4 +18,4 @@ /** * Spark Java programming APIs. */ -package org.apache.spark.api.java;
\ No newline at end of file +package org.apache.spark.api.java; diff --git a/core/src/main/scala/org/apache/spark/broadcast/package-info.java b/core/src/main/scala/org/apache/spark/broadcast/package-info.java index 1510e6e84c..bbf4a684a1 100644 --- a/core/src/main/scala/org/apache/spark/broadcast/package-info.java +++ b/core/src/main/scala/org/apache/spark/broadcast/package-info.java @@ -18,4 +18,4 @@ /** * Spark's broadcast variables, used to broadcast immutable datasets to all nodes. */ -package org.apache.spark.broadcast;
\ No newline at end of file +package org.apache.spark.broadcast; diff --git a/core/src/main/scala/org/apache/spark/executor/package-info.java b/core/src/main/scala/org/apache/spark/executor/package-info.java index dd3b6815fb..fb280964c4 100644 --- a/core/src/main/scala/org/apache/spark/executor/package-info.java +++ b/core/src/main/scala/org/apache/spark/executor/package-info.java @@ -18,4 +18,4 @@ /** * Package for executor components used with various cluster managers. */ -package org.apache.spark.executor;
\ No newline at end of file +package org.apache.spark.executor; diff --git a/core/src/main/scala/org/apache/spark/io/package-info.java b/core/src/main/scala/org/apache/spark/io/package-info.java index bea1bfdb63..1a46660280 100644 --- a/core/src/main/scala/org/apache/spark/io/package-info.java +++ b/core/src/main/scala/org/apache/spark/io/package-info.java @@ -18,4 +18,4 @@ /** * IO codecs used for compression. */ -package org.apache.spark.io;
\ No newline at end of file +package org.apache.spark.io; diff --git a/core/src/main/scala/org/apache/spark/rdd/package-info.java b/core/src/main/scala/org/apache/spark/rdd/package-info.java index 176cc58179..d9aa9bebe5 100644 --- a/core/src/main/scala/org/apache/spark/rdd/package-info.java +++ b/core/src/main/scala/org/apache/spark/rdd/package-info.java @@ -18,4 +18,4 @@ /** * Provides implementation's of various RDDs. */ -package org.apache.spark.rdd;
\ No newline at end of file +package org.apache.spark.rdd; diff --git a/core/src/main/scala/org/apache/spark/scheduler/package-info.java b/core/src/main/scala/org/apache/spark/scheduler/package-info.java index 5b4a628d3c..90fc65251e 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/package-info.java +++ b/core/src/main/scala/org/apache/spark/scheduler/package-info.java @@ -18,4 +18,4 @@ /** * Spark's DAG scheduler. */ -package org.apache.spark.scheduler;
\ No newline at end of file +package org.apache.spark.scheduler; diff --git a/core/src/main/scala/org/apache/spark/util/package-info.java b/core/src/main/scala/org/apache/spark/util/package-info.java index 819f54ee41..4c5d33d88d 100644 --- a/core/src/main/scala/org/apache/spark/util/package-info.java +++ b/core/src/main/scala/org/apache/spark/util/package-info.java @@ -18,4 +18,4 @@ /** * Spark utilities. */ -package org.apache.spark.util;
\ No newline at end of file +package org.apache.spark.util; diff --git a/core/src/main/scala/org/apache/spark/util/random/package-info.java b/core/src/main/scala/org/apache/spark/util/random/package-info.java index 62c3762dd1..e4f0c0febb 100644 --- a/core/src/main/scala/org/apache/spark/util/random/package-info.java +++ b/core/src/main/scala/org/apache/spark/util/random/package-info.java @@ -18,4 +18,4 @@ /** * Utilities for random number generation. */ -package org.apache.spark.util.random;
\ No newline at end of file +package org.apache.spark.util.random; |