diff options
author | François Garillot <francois@garillot.net> | 2015-07-30 18:14:08 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2015-07-30 18:14:08 +0100 |
commit | 7bbf02f0bddefd19985372af79e906a38bc528b6 (patch) | |
tree | bf72aafd97fe59ee37382fde93f4c49f42262760 /core | |
parent | c0cc0eaec67208c087a30c1b1f50c00b2c1ebf08 (diff) | |
download | spark-7bbf02f0bddefd19985372af79e906a38bc528b6.tar.gz spark-7bbf02f0bddefd19985372af79e906a38bc528b6.tar.bz2 spark-7bbf02f0bddefd19985372af79e906a38bc528b6.zip |
[SPARK-9267] [CORE] Retire stringify(Partial)?Value from Accumulators
cc srowen
Author: François Garillot <francois@garillot.net>
Closes #7678 from huitseeker/master and squashes the following commits:
5e99f57 [François Garillot] [SPARK-9267][Core] Retire stringify(Partial)?Value from Accumulators
Diffstat (limited to 'core')
-rw-r--r-- | core/src/main/scala/org/apache/spark/Accumulators.scala | 3 | ||||
-rw-r--r-- | core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala | 6 |
2 files changed, 2 insertions, 7 deletions
diff --git a/core/src/main/scala/org/apache/spark/Accumulators.scala b/core/src/main/scala/org/apache/spark/Accumulators.scala index 2f4fcac890..eb75f26718 100644 --- a/core/src/main/scala/org/apache/spark/Accumulators.scala +++ b/core/src/main/scala/org/apache/spark/Accumulators.scala @@ -341,7 +341,4 @@ private[spark] object Accumulators extends Logging { } } - def stringifyPartialValue(partialValue: Any): String = "%s".format(partialValue) - - def stringifyValue(value: Any): String = "%s".format(value) } diff --git a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala index cdf6078421..c4fa277c21 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala @@ -916,11 +916,9 @@ class DAGScheduler( // To avoid UI cruft, ignore cases where value wasn't updated if (acc.name.isDefined && partialValue != acc.zero) { val name = acc.name.get - val stringPartialValue = Accumulators.stringifyPartialValue(partialValue) - val stringValue = Accumulators.stringifyValue(acc.value) - stage.latestInfo.accumulables(id) = AccumulableInfo(id, name, stringValue) + stage.latestInfo.accumulables(id) = AccumulableInfo(id, name, s"${acc.value}") event.taskInfo.accumulables += - AccumulableInfo(id, name, Some(stringPartialValue), stringValue) + AccumulableInfo(id, name, Some(s"$partialValue"), s"${acc.value}") } } } catch { |