diff options
| author | Josiah Samuel <josiah_sams@in.ibm.com> | 2015-09-17 10:18:21 -0700 |
|---|---|---|
| committer | Marcelo Vanzin <vanzin@cloudera.com> | 2015-09-17 10:18:21 -0700 |
| commit | 81b4db374dd61b6f1c30511c70b6ab2a52c68faa (patch) | |
| tree | 2a0c01aa5cc3e7e952e58bd0c4580f27fea15e8a /core | |
| parent | 136c77d8bbf48f7c45dd7c3fbe261a0476f455fe (diff) | |
| download | spark-81b4db374dd61b6f1c30511c70b6ab2a52c68faa.tar.gz spark-81b4db374dd61b6f1c30511c70b6ab2a52c68faa.tar.bz2 spark-81b4db374dd61b6f1c30511c70b6ab2a52c68faa.zip | |
[SPARK-10172] [CORE] disable sort in HistoryServer webUI
This pull request is to address the JIRA SPARK-10172 (History Server web UI gets messed up when sorting on any column).
The content of the table gets messed up due to the rowspan attribute of the table data(cell) during sorting.
The current table sort library used in SparkUI (sorttable.js) doesn't support/handle cells(td) with rowspans.
The fix will disable the table sort in the web UI, when there are jobs listed with multiple attempts.
Author: Josiah Samuel <josiah_sams@in.ibm.com>
Closes #8506 from josiahsams/SPARK-10172.
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala index 0830cc1ba1..b347cb3be6 100644 --- a/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala +++ b/core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala @@ -51,7 +51,10 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("") val hasMultipleAttempts = appsToShow.exists(_.attempts.size > 1) val appTable = if (hasMultipleAttempts) { - UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow, appsToShow) + // Sorting is disable here as table sort on rowspan has issues. + // ref. SPARK-10172 + UIUtils.listingTable(appWithAttemptHeader, appWithAttemptRow, + appsToShow, sortable = false) } else { UIUtils.listingTable(appHeader, appRow, appsToShow) } |