diff options
| author | Andrew Or <andrewor14@gmail.com> | 2014-04-12 16:33:38 -0700 |
|---|---|---|
| committer | Patrick Wendell <pwendell@gmail.com> | 2014-04-12 16:33:38 -0700 |
| commit | c2d160fbee2ef90a7683d9771f2f632b68d74aef (patch) | |
| tree | e0ea19e30482c1b5218866f85f1e56a1dfcc0fe3 /core | |
| parent | 6aa08c39cf30fa5c4ed97f4fff16371b9030a2e6 (diff) | |
| download | spark-c2d160fbee2ef90a7683d9771f2f632b68d74aef.tar.gz spark-c2d160fbee2ef90a7683d9771f2f632b68d74aef.tar.bz2 spark-c2d160fbee2ef90a7683d9771f2f632b68d74aef.zip | |
[Fix #204] Update out-dated comments
This PR is self-explanatory.
Author: Andrew Or <andrewor14@gmail.com>
Closes #381 from andrewor14/master and squashes the following commits:
3e8dde2 [Andrew Or] Fix comments for #204
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/org/apache/spark/SparkContext.scala | 6 | ||||
| -rw-r--r-- | core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala | 4 |
2 files changed, 3 insertions, 7 deletions
diff --git a/core/src/main/scala/org/apache/spark/SparkContext.scala b/core/src/main/scala/org/apache/spark/SparkContext.scala index a764c174d5..5a36e6f5c1 100644 --- a/core/src/main/scala/org/apache/spark/SparkContext.scala +++ b/core/src/main/scala/org/apache/spark/SparkContext.scala @@ -1191,11 +1191,7 @@ class SparkContext(config: SparkConf) extends Logging { listenerBus.post(SparkListenerApplicationStart(appName, startTime, sparkUser)) } - /** - * Post the application end event to all listeners immediately, rather than adding it - * to the event queue for it to be asynchronously processed eventually. Otherwise, a race - * condition exists in which the listeners may stop before this event has been propagated. - */ + /** Post the application end event */ private def postApplicationEnd() { listenerBus.post(SparkListenerApplicationEnd(System.currentTimeMillis)) } diff --git a/core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala b/core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala index f868e772cf..f89724d4ea 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala @@ -31,8 +31,8 @@ import org.apache.spark.util.JsonProtocol /** * A SparkListenerBus that replays logged events from persisted storage. * - * This class expects files to be appropriately prefixed as specified in EventLoggingListener. - * There exists a one-to-one mapping between ReplayListenerBus and event logging applications. + * This assumes the given paths are valid log files, where each line can be deserialized into + * exactly one SparkListenerEvent. */ private[spark] class ReplayListenerBus( logPaths: Seq[Path], |