diff options
author | Russell Cardullo <russellcardullo@gmail.com> | 2013-11-18 08:37:09 -0800 |
---|---|---|
committer | Russell Cardullo <russellcardullo@gmail.com> | 2013-11-18 08:53:39 -0800 |
commit | 1360f62d15170bd295ceaba85f39401fd8109e51 (patch) | |
tree | 95283a9265fef3c4b21679c2c192fd4f6da5b733 /core | |
parent | ef85a51f85c9720bc091367a0d4f80e7ed6b9778 (diff) | |
download | spark-1360f62d15170bd295ceaba85f39401fd8109e51.tar.gz spark-1360f62d15170bd295ceaba85f39401fd8109e51.tar.bz2 spark-1360f62d15170bd295ceaba85f39401fd8109e51.zip |
Cleanup GraphiteSink.scala based on feedback
* Reorder imports according to the style guide
* Consistently use propertyToOption in all places
Diffstat (limited to 'core')
-rw-r--r-- | core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala b/core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala index eb1315e6de..cdcfec8ca7 100644 --- a/core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala +++ b/core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala @@ -17,13 +17,13 @@ package org.apache.spark.metrics.sink -import com.codahale.metrics.MetricRegistry -import com.codahale.metrics.graphite.{GraphiteReporter, Graphite} - import java.util.Properties import java.util.concurrent.TimeUnit import java.net.InetSocketAddress +import com.codahale.metrics.MetricRegistry +import com.codahale.metrics.graphite.{GraphiteReporter, Graphite} + import org.apache.spark.metrics.MetricsSystem class GraphiteSink(val property: Properties, val registry: MetricRegistry) extends Sink { @@ -50,12 +50,12 @@ class GraphiteSink(val property: Properties, val registry: MetricRegistry) exten val host = propertyToOption(GRAPHITE_KEY_HOST).get val port = propertyToOption(GRAPHITE_KEY_PORT).get.toInt - val pollPeriod = Option(property.getProperty(GRAPHITE_KEY_PERIOD)) match { + val pollPeriod = propertyToOption(GRAPHITE_KEY_PERIOD) match { case Some(s) => s.toInt case None => GRAPHITE_DEFAULT_PERIOD } - val pollUnit = Option(property.getProperty(GRAPHITE_KEY_UNIT)) match { + val pollUnit = propertyToOption(GRAPHITE_KEY_UNIT) match { case Some(s) => TimeUnit.valueOf(s.toUpperCase()) case None => TimeUnit.valueOf(GRAPHITE_DEFAULT_UNIT) } |